From: Krzysztof Kozlowski Date: Mon, 7 Oct 2024 13:05:07 +0200 Subject: =?UTF-8?B?UmU6IOWbnuimhjogW1BBVENIIHYxIDA4LzEwXSBhcm02NDogZHRzOiBh?= =?UTF-8?Q?speed=3A_Add_initial_AST27XX_device_tree?= In-Reply-To: References: <20240726110355.2181563-1-kevin_chen@aspeedtech.com> <20240726110355.2181563-9-kevin_chen@aspeedtech.com> Message-ID: <843b411f-8a71-4766-a657-70d326676f9c@kernel.org> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 07/10/2024 11:26, Kevin Chen wrote: >>>>> diff --git a/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >>>>> b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >>>>> new file mode 100644 >>>>> index 000000000000..858ab95251e4 >>>>> --- /dev/null >>>>> +++ b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >>>>> @@ -0,0 +1,217 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0-or-later #include >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +/ { >>>>> + model = "Aspeed BMC"; >>>> >>>> Model of what? No, drop. >>> Can I change to "model = "AST2700 EVB"" >> >> Model of what? No, it does not make sense here. > Should I change to model = "Aspeed BMC SoC"; SoCs do not have models. Please take a look how *every* other SoC is doing. Best regards, Krzysztof