From: Michael Trimarchi Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch Date: Tue, 16 Sep 2008 14:57:16 +0000 (GMT) Message-ID: <84867.22024.qm@web26206.mail.ukl.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Hisashi Hifumi , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from web26206.mail.ukl.yahoo.com ([217.12.10.243]:23377 "HELO web26206.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753827AbYIPO5R convert rfc822-to-8bit (ORCPT ); Tue, 16 Sep 2008 10:57:17 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, ----- Messaggio originale ----- > Da: Nick Piggin > A: Michael Trimarchi > Cc: Hisashi Hifumi ; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org > Inviato: Marted=EC 16 settembre 2008, 16:11:21 > Oggetto: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arc= h >=20 =2E.. > > i was thinking about introducing a file_pos_update() not implement= ed using > > file_pos_read()/file_pos_write() and taking the seq_lock or > > disabling preemption only one time >=20 > AFAIK, the only way to do an atomic 64 bit store on 32-bit x86 is > "cmpxchg8b" (with lock prefix on SMP). That would be far slower > I'm sure. Maybe it is clear with an example: =20 +/* + * file_pos_read/write is atomic by using sequence lock on 32bit arch. + */ +static inline loff_t file_pos_read(struct file *file) +{ +#if BITS_PER_LONG =3D=3D 32 && defined(CONFIG_SMP) + loff_t pos; + unsigned int seq; + + do { + seq =3D read_seqbegin(&file->f_pos_seqlock); + pos =3D file->f_pos; + } while (read_seqretry(&file->f_pos_seqlock, seq)); + return pos; +#elif BITS_PER_LONG =3D=3D 32 && defined(CONFIG_PREEMPT) + loff_t pos; + + preempt_disable(); + pos =3D file->f_pos; + preempt_enable(); + return pos; +#else + return file->f_pos; +#endif +} + +static inline void file_pos_write(struct file *file, loff_t pos) +{ +#if BITS_PER_LONG =3D=3D 32 && defined(CONFIG_SMP) + write_seqlock(&file->f_pos_seqlock); + file->f_pos =3D pos; + write_sequnlock(&file->f_pos_seqlock); +#elif BITS_PER_LONG =3D=3D 32 && defined(CONFIG_PREEMPT) + preempt_disable(); + file->f_pos =3D pos; + preempt_enable(); +#else + file->f_pos =3D pos; +#endif +} + if (offset !=3D file_pos_read(file)) file_pos_write(file, offset); Compile with: BITS_PER_LONG=3D32 CONFIG_PREEMPT The code does: file_pos_read(...) preempt_disable =2E... preempt_enable file_pos_write(...) preempt_disable =2E... preempt_enable with the file_pos_update() the code does: preempt_disable =2E.. =2E.. preempt_enable Regards Michael __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da ta= nto spazio gratuito per i tuoi file e i messaggi=20 http://mail.yahoo.it=20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html