From: Chris Wilson Subject: Re: [PATCH] drm/i915: the PCH reference clocks are global, so dont clobber unconditionally Date: Mon, 07 Feb 2011 12:16:47 +0000 Message-ID: <849307$bf8r06@azsmga001.ch.intel.com> References: <1296856650-2591-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id E86479E765 for ; Mon, 7 Feb 2011 04:16:50 -0800 (PST) In-Reply-To: <1296856650-2591-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 4 Feb 2011 13:57:30 -0800, Jesse Barnes wrote: > The PCH can drive several reference clocks simultaneously, and needs to > with multiple display configurations. So we can't just clobber the > existing state everytime we set a mode, we need to take into account > what the other CRTCs are doing at the time. > > Doing so fixes an issue where you'd lose the LVDS display at boot if you > had an LVDS+DP config. This fixes the warning, but sadly the U160 still does not work correctly. A step in the right direction, we now have VGA! Applied to -next, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre