From: Chris Wilson Subject: Re: [PATCH] drm/i915: cleanup per-pipe reg usage Date: Mon, 07 Feb 2011 23:25:58 +0000 Message-ID: <849307$bfi69s@azsmga001.ch.intel.com> References: <1297110412-11892-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id CA5A19E79E for ; Mon, 7 Feb 2011 15:26:02 -0800 (PST) In-Reply-To: <1297110412-11892-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 7 Feb 2011 12:26:52 -0800, Jesse Barnes wrote: > We had some conversions over to the _PIPE macros, but didn't get > everything. So hide the per-pipe regs with an _ (still used in a few > places for legacy) and add a few _PIPE based macros, then make sure > everyone uses them. In the end, I tabled a couple of amendments to the patch to perform some drive-by stylistic changes admist the general slaughter. (Including the mixing of too many metaphors.) Boot tested on gen2-6 and applied to -next, thanks! -Chris -- Chris Wilson, Intel Open Source Technology Centre