From: Tvrtko Ursulin Subject: Re: [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Date: Tue, 19 Mar 2019 13:15:49 +0000 Message-ID: <84c6ab05-63cb-0477-4bfd-a482c4e0fd8c@linux.intel.com> References: <20190318165633.28924-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81CCF89C08 for ; Tue, 19 Mar 2019 13:15:51 +0000 (UTC) In-Reply-To: <20190318165633.28924-1-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMTY6NTYsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBnMzMvaTk2NGcv ZzQ1IGFyZSB0aGUgZXhjZXB0aW9uYWwgY2FzZXMgd2hlbiBpdCBjb21lcyB0bwo+IHRoZSBzd2l6 emxlIGRldGVjdGlvbmcuIExldCdzIHJlb3JkZXIgdGhlIGNvZGUgdG8gaGFuZGxlCj4gdGhlbSBm aXJzdCBhbmQgbGV0IGV2ZXJ5dGhpbmcgZWxzZSBiZSBoYW5kbGVkIGJ5IHRoZQo+IGVsc2UgYnJh bmNoLiBUaGlzIGFsbG93cyB1cyB0byB1bnNldCAuaXNfbW9iaWxlIGZvciB0aGUKPiBkZXNrdG9w IFBOViB2YXJpYW50ICh3aGljaCBzdXBwb3NlZGx5IG11c3QgZm9sbG93IHRoZQo+ICJtb2JpbGUi IHBhdGggaGVyZSkuCj4gCj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51 eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2ZlbmNlX3JlZy5jIHwgNjUgKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBj aGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2VfcmVnLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9mZW5jZV9yZWcuYwo+IGluZGV4IDY1NjI0YjhlNGQxNS4uOTQx OGFkNDk5YjdlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2Zl bmNlX3JlZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2VfcmVn LmMKPiBAQCAtNTg1LDggKzU4NSwzOCBAQCBpOTE1X2dlbV9kZXRlY3RfYml0XzZfc3dpenpsZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJCSAqLwo+ICAgCQlzd2l6emxl X3ggPSBJOTE1X0JJVF82X1NXSVpaTEVfTk9ORTsKPiAgIAkJc3dpenpsZV95ID0gSTkxNV9CSVRf Nl9TV0laWkxFX05PTkU7Cj4gLQl9IGVsc2UgaWYgKElTX01PQklMRShkZXZfcHJpdikgfHwKPiAt CQkgICBJU19JOTE1RyhkZXZfcHJpdikgfHwgSVNfSTk0NUcoZGV2X3ByaXYpKSB7Cj4gKwl9IGVs c2UgaWYgKElTX0c0NShkZXZfcHJpdikgfHwgSVNfSTk2NUcoZGV2X3ByaXYpIHx8IElTX0czMyhk ZXZfcHJpdikpIHsKPiArCQkvKiBUaGUgOTY1LCBHMzMsIGFuZCBuZXdlciwgaGF2ZSBhIHZlcnkg ZmxleGlibGUgbWVtb3J5Cj4gKwkJICogY29uZmlndXJhdGlvbi4gIEl0IHdpbGwgZW5hYmxlIGR1 YWwtY2hhbm5lbCBtb2RlCj4gKwkJICogKGludGVybGVhdmluZykgb24gYXMgbXVjaCBtZW1vcnkg YXMgaXQgY2FuLCBhbmQgdGhlIEdQVQo+ICsJCSAqIHdpbGwgYWRkaXRpb25hbGx5IHNvbWV0aW1l cyBlbmFibGUgZGlmZmVyZW50IGJpdCA2Cj4gKwkJICogc3dpenpsaW5nIGZvciB0aWxlZCBvYmpl Y3RzIGZyb20gdGhlIENQVS4KPiArCQkgKgo+ICsJCSAqIEhlcmUncyB3aGF0IEkgZm91bmQgb24g dGhlIEc5NjU6Cj4gKwkJICogICAgc2xvdCBmaWxsICAgICAgICAgbWVtb3J5IHNpemUgIHN3aXp6 bGluZwo+ICsJCSAqIDBBICAgMEIgICAxQSAgIDFCICAgIDEtY2ggICAyLWNoCj4gKwkJICogNTEy ICAwICAgIDAgICAgMCAgICAgNTEyICAgIDAgICAgIE8KPiArCQkgKiA1MTIgIDAgICAgNTEyICAw ICAgICAxNiAgICAgMTAwOCAgWAo+ICsJCSAqIDUxMiAgMCAgICAwICAgIDUxMiAgIDE2ICAgICAx MDA4ICBYCj4gKwkJICogMCAgICA1MTIgIDAgICAgNTEyICAgMTYgICAgIDEwMDggIFgKPiArCQkg KiAxMDI0IDEwMjQgMTAyNCAwICAgICAyMDQ4ICAgMTAyNCAgTwo+ICsJCSAqCj4gKwkJICogV2Ug Y291bGQgcHJvYmFibHkgZGV0ZWN0IHRoaXMgYmFzZWQgb24gZWl0aGVyIHRoZSBEUkIKPiArCQkg KiBtYXRjaGluZywgd2hpY2ggd2FzIHRoZSBjYXNlIGZvciB0aGUgc3dpenpsaW5nIHJlcXVpcmVk IGluCj4gKwkJICogdGhlIHRhYmxlIGFib3ZlLCBvciBmcm9tIHRoZSAxLWNoIHZhbHVlIGJlaW5n IGxlc3MgdGhhbgo+ICsJCSAqIHRoZSBtaW5pbXVtIHNpemUgb2YgYSByYW5rLgo+ICsJCSAqCj4g KwkJICogUmVwb3J0cyBpbmRpY2F0ZSB0aGF0IHRoZSBzd2l6emxpbmcgYWN0dWFsbHkKPiArCQkg KiB2YXJpZXMgZGVwZW5kaW5nIHVwb24gcGFnZSBwbGFjZW1lbnQgaW5zaWRlIHRoZQo+ICsJCSAq IGNoYW5uZWxzLCBpLmUuIHdlIHNlZSBzd2l6emxlZCBwYWdlcyB3aGVyZSB0aGUKPiArCQkgKiBi YW5rcyBvZiBtZW1vcnkgYXJlIHBhaXJlZCBhbmQgdW5zd2l6emxlZCBvbiB0aGUKPiArCQkgKiB1 bmV2ZW4gcG9ydGlvbiwgc28gbGVhdmUgdGhhdCBhcyB1bmtub3duLgo+ICsJCSAqLwo+ICsJCWlm IChJOTE1X1JFQUQxNihDMERSQjMpID09IEk5MTVfUkVBRDE2KEMxRFJCMykpIHsKPiArCQkJc3dp enpsZV94ID0gSTkxNV9CSVRfNl9TV0laWkxFXzlfMTA7Cj4gKwkJCXN3aXp6bGVfeSA9IEk5MTVf QklUXzZfU1dJWlpMRV85Owo+ICsJCX0KPiArCX0gZWxzZSB7Cj4gICAJCXUzMiBkY2M7Cj4gICAK PiAgIAkJLyogT24gOXh4IGNoaXBzZXRzLCBjaGFubmVsIGludGVybGVhdmUgYnkgdGhlIENQVSBp cwo+IEBAIC02MzYsMzcgKzY2Niw2IEBAIGk5MTVfZ2VtX2RldGVjdF9iaXRfNl9zd2l6emxlKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkJCXN3aXp6bGVfeCA9IEk5MTVf QklUXzZfU1dJWlpMRV9VTktOT1dOOwo+ICAgCQkJc3dpenpsZV95ID0gSTkxNV9CSVRfNl9TV0la WkxFX1VOS05PV047Cj4gICAJCX0KPiAtCX0gZWxzZSB7Cj4gLQkJLyogVGhlIDk2NSwgRzMzLCBh bmQgbmV3ZXIsIGhhdmUgYSB2ZXJ5IGZsZXhpYmxlIG1lbW9yeQo+IC0JCSAqIGNvbmZpZ3VyYXRp b24uICBJdCB3aWxsIGVuYWJsZSBkdWFsLWNoYW5uZWwgbW9kZQo+IC0JCSAqIChpbnRlcmxlYXZp bmcpIG9uIGFzIG11Y2ggbWVtb3J5IGFzIGl0IGNhbiwgYW5kIHRoZSBHUFUKPiAtCQkgKiB3aWxs IGFkZGl0aW9uYWxseSBzb21ldGltZXMgZW5hYmxlIGRpZmZlcmVudCBiaXQgNgo+IC0JCSAqIHN3 aXp6bGluZyBmb3IgdGlsZWQgb2JqZWN0cyBmcm9tIHRoZSBDUFUuCj4gLQkJICoKPiAtCQkgKiBI ZXJlJ3Mgd2hhdCBJIGZvdW5kIG9uIHRoZSBHOTY1Ogo+IC0JCSAqICAgIHNsb3QgZmlsbCAgICAg ICAgIG1lbW9yeSBzaXplICBzd2l6emxpbmcKPiAtCQkgKiAwQSAgIDBCICAgMUEgICAxQiAgICAx LWNoICAgMi1jaAo+IC0JCSAqIDUxMiAgMCAgICAwICAgIDAgICAgIDUxMiAgICAwICAgICBPCj4g LQkJICogNTEyICAwICAgIDUxMiAgMCAgICAgMTYgICAgIDEwMDggIFgKPiAtCQkgKiA1MTIgIDAg ICAgMCAgICA1MTIgICAxNiAgICAgMTAwOCAgWAo+IC0JCSAqIDAgICAgNTEyICAwICAgIDUxMiAg IDE2ICAgICAxMDA4ICBYCj4gLQkJICogMTAyNCAxMDI0IDEwMjQgMCAgICAgMjA0OCAgIDEwMjQg IE8KPiAtCQkgKgo+IC0JCSAqIFdlIGNvdWxkIHByb2JhYmx5IGRldGVjdCB0aGlzIGJhc2VkIG9u IGVpdGhlciB0aGUgRFJCCj4gLQkJICogbWF0Y2hpbmcsIHdoaWNoIHdhcyB0aGUgY2FzZSBmb3Ig dGhlIHN3aXp6bGluZyByZXF1aXJlZCBpbgo+IC0JCSAqIHRoZSB0YWJsZSBhYm92ZSwgb3IgZnJv bSB0aGUgMS1jaCB2YWx1ZSBiZWluZyBsZXNzIHRoYW4KPiAtCQkgKiB0aGUgbWluaW11bSBzaXpl IG9mIGEgcmFuay4KPiAtCQkgKgo+IC0JCSAqIFJlcG9ydHMgaW5kaWNhdGUgdGhhdCB0aGUgc3dp enpsaW5nIGFjdHVhbGx5Cj4gLQkJICogdmFyaWVzIGRlcGVuZGluZyB1cG9uIHBhZ2UgcGxhY2Vt ZW50IGluc2lkZSB0aGUKPiAtCQkgKiBjaGFubmVscywgaS5lLiB3ZSBzZWUgc3dpenpsZWQgcGFn ZXMgd2hlcmUgdGhlCj4gLQkJICogYmFua3Mgb2YgbWVtb3J5IGFyZSBwYWlyZWQgYW5kIHVuc3dp enpsZWQgb24gdGhlCj4gLQkJICogdW5ldmVuIHBvcnRpb24sIHNvIGxlYXZlIHRoYXQgYXMgdW5r bm93bi4KPiAtCQkgKi8KPiAtCQlpZiAoSTkxNV9SRUFEMTYoQzBEUkIzKSA9PSBJOTE1X1JFQUQx NihDMURSQjMpKSB7Cj4gLQkJCXN3aXp6bGVfeCA9IEk5MTVfQklUXzZfU1dJWlpMRV85XzEwOwo+ IC0JCQlzd2l6emxlX3kgPSBJOTE1X0JJVF82X1NXSVpaTEVfOTsKPiAtCQl9Cj4gICAJfQo+ICAg Cj4gICAJaWYgKHN3aXp6bGVfeCA9PSBJOTE1X0JJVF82X1NXSVpaTEVfVU5LTk9XTiB8fAo+IAoK T2xkL25ldy9mdXR1cmUgYmVoYXZpb3VyIGNoZWNrcyBvdXQgYXMgZmFyIGFzIEkgY2FuIHNlZS4K ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZng=