From: =?UTF-8?Q?Juha-Pekka_Heikkil=c3=a4?= Subject: Re: [PATCH v3 4/4] drm/i915/icl: Enable Y210, Y212, Y216 format for primary and sprite planes Date: Tue, 27 Nov 2018 23:10:09 +0200 Message-ID: <84c6ef66-ff47-c889-e3f1-a04607a23510@gmail.com> References: <1540186308-4390-1-git-send-email-swati2.sharma@intel.com> <1540186308-4390-5-git-send-email-swati2.sharma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1540186308-4390-5-git-send-email-swati2.sharma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Swati Sharma , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpTd2F0aSBTaGFybWEga2lyam9pdHRpIDIyLjEwLjIwMTgga2xvIDguMzE6Cj4gRnJvbTogVmlk eWEgU3Jpbml2YXMgPHZpZHlhLnNyaW5pdmFzQGludGVsLmNvbT4KPiAKPiBJbiB0aGlzIHBhdGNo LCBhIGxpc3QgZm9yIGljbCBzcGVjaWZpYyBwaXhlbCBmb3JtYXRzIGlzIGNyZWF0ZWQKPiBpbiB3 aGljaCBZMjEwLCBZMjEyIGFuZCBZMjE2IHBpeGVsIGZvcm1hdHMgYXJlIGFkZGVkIGFsb25nIHdp dGgKPiBsZWdhY3kgcGl4ZWwgZm9ybWF0cyBmb3IgcHJpbWFyeSBhbmQgc3ByaXRlIHBsYW5lLgo+ IAo+IHYzOiBzaW5jZSBzdXBwb3J0IGZvciBwbGFuYXIgZm9ybWF0cyBvbiBJQ0wgd2FzIGdldHRp bmcgdG90YWxseQo+ICAgICAgc2tpcHBlZCwgYWRkZWQgc3VwcG9ydCBmb3IgdGhlIHNhbWUgaW4g aW50ZWxfZGlzcGxheS5jIGFuZAo+ICAgICAgaW50ZWxfc3ByaXRlLmMuIChqdWhhKQo+IAo+IFNp Z25lZC1vZmYtYnk6IFN3YXRpIFNoYXJtYSA8c3dhdGkyLnNoYXJtYUBpbnRlbC5jb20+Cj4gU2ln bmVkLW9mZi1ieTogVmlkeWEgU3Jpbml2YXMgPHZpZHlhLnNyaW5pdmFzQGludGVsLmNvbT4KPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDU4ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfc3ByaXRlLmMgIHwgNDIgKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgIDIgZmlsZXMg Y2hhbmdlZCwgOTIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggOThmMjkzOS4uZjgzZmJiNCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTA1LDYgKzEwNSw0MiBAQAo+ICAg CURSTV9GT1JNQVRfTlYxMiwKPiAgIH07Cj4gICAKPiArc3RhdGljIGNvbnN0IHVpbnQzMl90IGlj bF9wcmltYXJ5X2Zvcm1hdHNbXSA9IHsKPiArCURSTV9GT1JNQVRfQzgsCj4gKwlEUk1fRk9STUFU X1JHQjU2NSwKPiArCURSTV9GT1JNQVRfWFJHQjg4ODgsCj4gKwlEUk1fRk9STUFUX1hCR1I4ODg4 LAo+ICsJRFJNX0ZPUk1BVF9BUkdCODg4OCwKPiArCURSTV9GT1JNQVRfQUJHUjg4ODgsCj4gKwlE Uk1fRk9STUFUX1hSR0IyMTAxMDEwLAo+ICsJRFJNX0ZPUk1BVF9YQkdSMjEwMTAxMCwKPiArCURS TV9GT1JNQVRfWVVZViwKPiArCURSTV9GT1JNQVRfWVZZVSwKPiArCURSTV9GT1JNQVRfVVlWWSwK PiArCURSTV9GT1JNQVRfVllVWSwKPiArCURSTV9GT1JNQVRfWTIxMCwKPiArCURSTV9GT1JNQVRf WTIxMiwKPiArCURSTV9GT1JNQVRfWTIxNiwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCB1aW50 MzJfdCBpY2xfcHJpX3BsYW5hcl9mb3JtYXRzW10gPSB7Cj4gKwlEUk1fRk9STUFUX0M4LAo+ICsJ RFJNX0ZPUk1BVF9SR0I1NjUsCj4gKwlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ICsJRFJNX0ZPUk1B VF9YQkdSODg4OCwKPiArCURSTV9GT1JNQVRfQVJHQjg4ODgsCj4gKwlEUk1fRk9STUFUX0FCR1I4 ODg4LAo+ICsJRFJNX0ZPUk1BVF9YUkdCMjEwMTAxMCwKPiArCURSTV9GT1JNQVRfWEJHUjIxMDEw MTAsCj4gKwlEUk1fRk9STUFUX1lVWVYsCj4gKwlEUk1fRk9STUFUX1lWWVUsCj4gKwlEUk1fRk9S TUFUX1VZVlksCj4gKwlEUk1fRk9STUFUX1ZZVVksCj4gKwlEUk1fRk9STUFUX1kyMTAsCj4gKwlE Uk1fRk9STUFUX1kyMTIsCj4gKwlEUk1fRk9STUFUX1kyMTYsCj4gK307Cj4gKwo+ICAgc3RhdGlj IGNvbnN0IHVpbnQ2NF90IHNrbF9mb3JtYXRfbW9kaWZpZXJzX25vY2NzW10gPSB7Cj4gICAJSTkx NV9GT1JNQVRfTU9EX1lmX1RJTEVELAo+ICAgCUk5MTVfRk9STUFUX01PRF9ZX1RJTEVELAo+IEBA IC0xMzc4OCwxNiArMTM4MjQsMjYgQEAgYm9vbCBza2xfcGxhbmVfaGFzX3BsYW5hcihzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCWZiYy0+cG9zc2libGVfZnJhbWVidWZm ZXJfYml0cyB8PSBwcmltYXJ5LT5mcm9udGJ1ZmZlcl9iaXQ7Cj4gICAJfQo+ICAgCj4gKwpeXiBz dHJheSBuZXdsaW5lPwoKVGhlIG5leHQgaWYoKXt9ZWxzZXt9IEkgd291bGQgd3JpdGUgc2VwYXJh dGluZyBnZW4xMSBmcm9tIGdlbjkgYmVjYXVzZSAKeW91IG5lZWQgYm90aCB0YWJsZXMsIHByaW1h cnlfZm9ybWF0cyBhcyB3ZWxsIGFzIHByaV9wbGFuYXJfZm9ybWF0cywgZm9yIApnZW4xMS4KClNv LCBpbnN0ZWFkIG9mIGhhdmluZwoKaWYoPj1nZW45KSB7CiAgIGlmKD49Z2VuMTEpIHsKICAgLi4K ICAgfSBlbHNlIHsKICAgLi4KICAgfQp9CgpJJ2Qgd3JpdGUgaXQgbGlrZQoKaWYoPj1nZW4xMSkg ewogICAuLgp9IGVsc2UgaWYoPj1nZW45KSB7CiAgIC4uCn0gZWxzLi4uCgpJIHRoaW5rIGl0IHdp bGwgYmUgbXVjaCBlYXNpZXIgdG8gcmVhZC4gU2FtZSBiZWxvdyBpbiBpbnRlbF9zcHJpdGUuYwoK L0p1aGEtUGVra2EKCj4gICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkgewo+ICAgCQlw cmltYXJ5LT5oYXNfY2NzID0gc2tsX3BsYW5lX2hhc19jY3MoZGV2X3ByaXYsIHBpcGUsCj4gLQkJ CQkJCSAgICAgUExBTkVfUFJJTUFSWSk7Cj4gLQo+IC0JCWlmIChza2xfcGxhbmVfaGFzX3BsYW5h cihkZXZfcHJpdiwgcGlwZSwgUExBTkVfUFJJTUFSWSkpIHsKPiArCQkJCVBMQU5FX1BSSU1BUlkp Owo+ICsKPiArCQlpZiAoc2tsX3BsYW5lX2hhc19wbGFuYXIoZGV2X3ByaXYsIHBpcGUsCj4gKwkJ CQkJUExBTkVfUFJJTUFSWSkpIHsKPiArCQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEp IHsKPiArCQkJCWludGVsX3ByaW1hcnlfZm9ybWF0cyA9IGljbF9wcmltYXJ5X2Zvcm1hdHM7Cj4g KwkJCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoaWNsX3ByaW1hcnlfZm9ybWF0cyk7Cj4gKwkJ CX0gZWxzZSB7Cj4gKwkJCQlpbnRlbF9wcmltYXJ5X2Zvcm1hdHMgPSBza2xfcHJpbWFyeV9mb3Jt YXRzOwo+ICsJCQkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKHNrbF9wcmltYXJ5X2Zvcm1hdHMp Owo+ICsJCQl9Cj4gKwkJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKSB7Cj4g KwkJCWludGVsX3ByaW1hcnlfZm9ybWF0cyA9IGljbF9wcmlfcGxhbmFyX2Zvcm1hdHM7Cj4gKwkJ CW51bV9mb3JtYXRzID0gQVJSQVlfU0laRShpY2xfcHJpX3BsYW5hcl9mb3JtYXRzKTsKPiArCQl9 IGVsc2Ugewo+ICAgCQkJaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2tsX3ByaV9wbGFuYXJfZm9y bWF0czsKPiAgIAkJCW51bV9mb3JtYXRzID0gQVJSQVlfU0laRShza2xfcHJpX3BsYW5hcl9mb3Jt YXRzKTsKPiAtCQl9IGVsc2Ugewo+IC0JCQlpbnRlbF9wcmltYXJ5X2Zvcm1hdHMgPSBza2xfcHJp bWFyeV9mb3JtYXRzOwo+IC0JCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3ByaW1hcnlf Zm9ybWF0cyk7Cj4gICAJCX0KPiAgIAo+ICAgCQlpZiAocHJpbWFyeS0+aGFzX2NjcykKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGM4MzEzNjAuLjdkOWIzZTQgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xNTY0LDYgKzE1NjQsMzYgQEAg aW50IGludGVsX3Nwcml0ZV9zZXRfY29sb3JrZXlfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgdm9pZCAqZGF0YSwKPiAgIAlEUk1fRk9STUFUX05WMTIsCj4gICB9Owo+ICAgCj4gK3N0YXRp YyB1aW50MzJfdCBpY2xfcGxhbmVfZm9ybWF0c1tdID0gewo+ICsJRFJNX0ZPUk1BVF9SR0I1NjUs Cj4gKwlEUk1fRk9STUFUX0FCR1I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9BUkdCODg4OCwKPiArCURS TV9GT1JNQVRfWEJHUjg4ODgsCj4gKwlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ICsJRFJNX0ZPUk1B VF9ZVVlWLAo+ICsJRFJNX0ZPUk1BVF9ZVllVLAo+ICsJRFJNX0ZPUk1BVF9VWVZZLAo+ICsJRFJN X0ZPUk1BVF9WWVVZLAo+ICsJRFJNX0ZPUk1BVF9ZMjEwLAo+ICsJRFJNX0ZPUk1BVF9ZMjEyLAo+ ICsJRFJNX0ZPUk1BVF9ZMjE2LAo+ICt9Owo+ICsKPiArc3RhdGljIHVpbnQzMl90IGljbF9wbGFu YXJfZm9ybWF0c1tdID0gewo+ICsJRFJNX0ZPUk1BVF9SR0I1NjUsCj4gKwlEUk1fRk9STUFUX0FC R1I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9BUkdCODg4OCwKPiArCURSTV9GT1JNQVRfWEJHUjg4ODgs Cj4gKwlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9ZVVlWLAo+ICsJRFJNX0ZP Uk1BVF9ZVllVLAo+ICsJRFJNX0ZPUk1BVF9VWVZZLAo+ICsJRFJNX0ZPUk1BVF9WWVVZLAo+ICsJ RFJNX0ZPUk1BVF9ZMjEwLAo+ICsJRFJNX0ZPUk1BVF9ZMjEyLAo+ICsJRFJNX0ZPUk1BVF9ZMjE2 LAo+ICt9Owo+ICsKPiAgIHN0YXRpYyBjb25zdCB1aW50NjRfdCBza2xfcGxhbmVfZm9ybWF0X21v ZGlmaWVyc19ub2Njc1tdID0gewo+ICAgCUk5MTVfRk9STUFUX01PRF9ZZl9USUxFRCwKPiAgIAlJ OTE1X0ZPUk1BVF9NT0RfWV9USUxFRCwKPiBAQCAtMTgyMiw4ICsxODUyLDE2IEBAIHN0cnVjdCBp bnRlbF9wbGFuZSAqCj4gICAKPiAgIAkJaWYgKHNrbF9wbGFuZV9oYXNfcGxhbmFyKGRldl9wcml2 LCBwaXBlLAo+ICAgCQkJCQkgUExBTkVfU1BSSVRFMCArIHBsYW5lKSkgewo+IC0JCQlwbGFuZV9m b3JtYXRzID0gc2tsX3BsYW5hcl9mb3JtYXRzOwo+IC0JCQludW1fcGxhbmVfZm9ybWF0cyA9IEFS UkFZX1NJWkUoc2tsX3BsYW5hcl9mb3JtYXRzKTsKPiArCQkJaWYgKElOVEVMX0dFTihkZXZfcHJp dikgPj0gMTEpIHsKPiArCQkJCXBsYW5lX2Zvcm1hdHMgPSBpY2xfcGxhbmFyX2Zvcm1hdHM7Cj4g KwkJCQludW1fcGxhbmVfZm9ybWF0cyA9IEFSUkFZX1NJWkUoaWNsX3BsYW5hcl9mb3JtYXRzKTsK PiArCQkJfSBlbHNlIHsKPiArCQkJCXBsYW5lX2Zvcm1hdHMgPSBza2xfcGxhbmFyX2Zvcm1hdHM7 Cj4gKwkJCQludW1fcGxhbmVfZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3BsYW5hcl9mb3JtYXRz KTsKPiArCQkJfQo+ICsJCX0gZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkgewo+ ICsJCQlwbGFuZV9mb3JtYXRzID0gaWNsX3BsYW5lX2Zvcm1hdHM7Cj4gKwkJCW51bV9wbGFuZV9m b3JtYXRzID0gQVJSQVlfU0laRShpY2xfcGxhbmVfZm9ybWF0cyk7Cj4gICAJCX0gZWxzZSB7Cj4g ICAJCQlwbGFuZV9mb3JtYXRzID0gc2tsX3BsYW5lX2Zvcm1hdHM7Cj4gICAJCQludW1fcGxhbmVf Zm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3BsYW5lX2Zvcm1hdHMpOwo+IApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK