Message-ID: <84f85177-538a-d1b4-040d-b2a0080251d7@...1227...> Date: Fri, 6 Jan 2023 16:04:33 +0100 MIME-Version: 1.0 Content-Language: en-GB References: <20230103202330.1835-1-a@...2181...> <20230103202330.1835-2-a@...2181...> From: Arne Schwabe In-Reply-To: <20230103202330.1835-2-a@...2181...> Subject: Re: [Openvpn-devel] [PATCH 2/3] dco: bail out when no peer-specific message is delivered List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Antonio Quartulli , openvpn-devel@lists.sourceforge.net Am 03.01.23 um 21:23 schrieb Antonio Quartulli: > multi_process_incoming_dco() is currently partly processing > messages that were actually discarded. This results in a bogus > message being printed: > > "Received packet for peer-id unknown to OpenVPN: -1, type 0, reason 2" > > Change the flow so that we bail out immediately when we know that no > message was truly delivered by DCO. > Currently this can be verified by chacking that the peed_is is greater > than -1. I think we should somewhere properly document that peer-id = -1 has this meaning. Acked-By: Arne Schwabe Arne