Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B723E225761 for ; Mon, 7 Apr 2025 09:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744016864; cv=none; b=p4J59wDUmLl5p1NvRNaiLisLCOy+LwkcNutxzOSjtBDb3ECLk5HFcRMATn1JVOmDkEa6dWp1Ah3q6YUNG6nCPKzI0XNYheOrSAdq8+xTBszImyY/06kUwRgBxT8eSrc0xzxiuG9sW/OtDpOLySuK/xaX7rg8ACgnC2vUcIsTyMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744016864; c=relaxed/simple; bh=D5vh0G8BLUsXb6aOCtMv9JV9NfdUSV8ykeIPOeKOtu0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=pvSuCeXpym2Y2DbVzJJYeYJYD+wojr0zsqphu8vZOOTAxtO+jkgsADyzyiwLxiXC4ouJ97czfp3UgqppYGibVY0sYMLSDoV0ZonrR6w4cOXbQVlWELsNcYMU2lI0r8dEgiLVyS6OmkIsFcsmRGCvCkxPdubnvawYOLW1UGo8qBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TRRnAtLg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TRRnAtLg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C08BC4CEDD; Mon, 7 Apr 2025 09:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744016864; bh=D5vh0G8BLUsXb6aOCtMv9JV9NfdUSV8ykeIPOeKOtu0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=TRRnAtLghoWZ3WZsK2IcggpXSBu+jG2aZ3rIqFon8QLCHcdU++r8c3OQnIKOY1eJN W17ryZRk0eBrBUT9zh0S4Jq+6X//mBF2fNbZpmlhCT6GPtW3ojUwX85FrMdjUS0Un6 Kc2xlb37YoLlnb1/Q+NZQxAewMQgYcadQUSQctFf24nXiAm6RatpW/L9+HzXfivLqO EY7LUxPzcff0DtQevwhN7YH/e6FdlLh7PJmcVy27rR/JcSt+DtjE/ztOuDY5srRPqf CEZSYcAcY4lFgquvc1Vbnlbw1jUW+24Eo1vd2PpupGk+Jl0+LrkFuTlQPUwQrdLLsa 8AqZ5m00fO5Xw== Message-ID: <851297ad-5e66-4374-9914-cd48868c4c7b@kernel.org> Date: Mon, 7 Apr 2025 11:07:41 +0200 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH 1/2] BCC: Python: Support 'fmod_ret' method for eBPF Content-Language: en-GB, fr-BE To: Gang Yan , mptcp@lists.linux.dev References: <766ea5e9772f92d97100f8b52e70b2895c3de628.1743988616.git.yangang@kylinos.cn> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <766ea5e9772f92d97100f8b52e70b2895c3de628.1743988616.git.yangang@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Gang, On 07/04/2025 04:37, Gang Yan wrote: > In kernel, there exists a lot of 'fmod_ret' functions, such as > 'update_socket_protocol'. But it cannot be attached in BCC-python > directly, so this patch provides an interface for Python to use > 'fmod_ret' attaching method. > > Signed-off-by: Gang Yan > --- > src/python/bcc/__init__.py | 43 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/src/python/bcc/__init__.py b/src/python/bcc/__init__.py > index 8bc85516..96de3d40 100644 > --- a/src/python/bcc/__init__.py > +++ b/src/python/bcc/__init__.py > @@ -461,6 +461,7 @@ class BPF(object): > self.raw_tracepoint_fds = {} > self.kfunc_entry_fds = {} > self.kfunc_exit_fds = {} > + self.fmod_ret_fds = {} > self.lsm_fds = {} > self.perf_buffers = {} > self.open_perf_events = {} > @@ -1157,6 +1158,21 @@ class BPF(object): > return True > return False > > + @staticmethod > + def support_fmod_ret(): > + if not BPF.support_kfunc(): > + return False > + > + kernel_version = platform.release() > + major, minor, _ = kernel_version.split(".") > + > + if int(major) > 5: > + return True > + elif int(major) ==5 and int(minor) >= 6: Was it not introduced in v5.7 instead of v5.6? return int(major) > 5 or (int(major) == 5 and int(minor) >= 7) https://lore.kernel.org/20200304191853.1529-1-kpsingh@chromium.org But also, it feels wrong to look at the kernel version, in case of backports, etc. Can you not look at something else? e.g. kallsyms? Cheers, Matt -- Sponsored by the NGI0 Core fund.