From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 3/6] drm/i915/psr: Move intel_psr_disable_source() code to intel_psr_disable_locked() Date: Fri, 19 Oct 2018 13:55:29 -0700 Message-ID: <85e97f62be123dde63ea506cc157d894781121fa.camel@intel.com> References: <20181011004124.4110-1-jose.souza@intel.com> <20181011004124.4110-3-jose.souza@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 574AA6E55D for ; Fri, 19 Oct 2018 20:55:47 +0000 (UTC) In-Reply-To: <20181011004124.4110-3-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTEwLTEwIGF0IDE3OjQxIC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXph IHdyb3RlOgo+IEluIHRoZSBwYXN0IHdlIGhhZCBob29rcyB0byBjb25maWd1cmUgSFcgZm9yIFZM Vi9DSFYgdG9vLCBpbiB0aGUgZHJvcAo+IG9mIFZMVi9DSFYgc3VwcG9ydCB0aGUgaW50ZWxfcHNy X2Rpc2FibGVfc291cmNlKCkgY29kZSB3YXMgbm90IG1vdmVkCj4gdG8gdGhlIGNhbGxlciwgc28g ZG9pbmcgaXQgaGVyZS4KPiAKPiBTdWdnZXN0ZWQtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRo aW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IERoaW5ha2FyYW4gUGFu ZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgoKQ2M6IERoaW5ha2FyYW4gUGFu ZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpv c8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDI1ICsrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IDE2ZDBlM2RmN2RlMC4uNzBkNGUy NmUxN2I1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtNjgwLDEzICs2ODAs MjAgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX2V4aXQoc3RydWN0Cj4gZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gIAlkZXZfcHJpdi0+cHNyLmFjdGl2ZSA9IGZhbHNlOwo+ICB9Cj4gIAo+ IC1zdGF0aWMgdm9pZAo+IC1pbnRlbF9wc3JfZGlzYWJsZV9zb3VyY2Uoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCkKPiArc3RhdGljIHZvaWQgaW50ZWxfcHNyX2Rpc2FibGVfbG9ja2VkKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+ICAJaTkxNV9yZWdfdCBwc3Jfc3RhdHVz Owo+ICAJdTMyIHBzcl9zdGF0dXNfbWFzazsKPiAgCj4gKwlsb2NrZGVwX2Fzc2VydF9oZWxkKCZk ZXZfcHJpdi0+cHNyLmxvY2spOwo+ICsKPiArCWlmICghZGV2X3ByaXYtPnBzci5lbmFibGVkKQo+ ICsJCXJldHVybjsKPiArCj4gKwlEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcgUFNSJXNcbiIsCj4g KwkJICAgICAgZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQgPyAiMiIgOiAiMSIpOwo+ICsKPiAg CWludGVsX3Bzcl9leGl0KGRldl9wcml2KTsKClRoZSBhYm92ZSBsb2NrZGVwX2Fzc2VydF9oZWxk KCZkZXZfcHJpdi0+cHNyLmxvY2spIG1hZGUgbWUgdGhpbmsgd2UKbmVlZCBvbmUgaW4gaW5zaWRl IHBzcl9leGl0KCkgdG9vLiBOb3QgaW4gdGhpcyB0aG91Z2gsIGNvdWxkIHBlcmhhcHMgYmUKYWRk ZWQgaW4gcGF0Y2ggMS4KCgo+ICAKPiAgCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkg ewo+IEBAIC03MDEsMjAgKzcwOCw2IEBAIGludGVsX3Bzcl9kaXNhYmxlX3NvdXJjZShzdHJ1Y3Qg aW50ZWxfZHAKPiAqaW50ZWxfZHApCj4gIAlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2 X3ByaXYsIHBzcl9zdGF0dXMsCj4gcHNyX3N0YXR1c19tYXNrLCAwLAo+ICAJCQkJICAgIDIwMDAp KQo+ICAJCURSTV9FUlJPUigiVGltZWQgb3V0IHdhaXRpbmcgZm9yIFBTUiBJZGxlIFN0YXRlXG4i KTsKPiAtfQo+IC0KPiAtc3RhdGljIHZvaWQgaW50ZWxfcHNyX2Rpc2FibGVfbG9ja2VkKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gLXsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+IC0KPiAtCWxvY2tkZXBfYXNzZXJ0X2hl bGQoJmRldl9wcml2LT5wc3IubG9jayk7Cj4gLQo+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLmVuYWJs ZWQpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCURSTV9ERUJVR19LTVMoIkRpc2FibGluZyBQU1Ilc1xu IiwKPiAtCQkgICAgICBkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCA/ICIyIiA6ICIxIik7Cj4g LQlpbnRlbF9wc3JfZGlzYWJsZV9zb3VyY2UoaW50ZWxfZHApOwo+ICAKPiAgCS8qIERpc2FibGUg UFNSIG9uIFNpbmsgKi8KPiAgCWRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBf UFNSX0VOX0NGRywgMCk7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK