From: "cron2 (Code Review)" Date: Mon, 14 Jul 2025 09:22:03 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <85ea2948fd4116ee48929409886bec23012d7c08-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="lb9uknvPrbI="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix compiler warning in reliable.c with --disable-debug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --lb9uknvPrbI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1082?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Fix compiler warning in reliable.c with --disable-debug ...................................................................... Fix compiler warning in reliable.c with --disable-debug Use the easy way out. Using pre-compiler to completely avoid n_active seems like overkill. Change-Id: Icad1a52d14311a6f06bda081cab2f4bded8d47ed Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20250711100405.240625-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 107.html Signed-off-by: Gert Doering --- M src/openvpn/reliable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/82/1082/2 diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c index 6aef112..424d194 100644 --- a/src/openvpn/reliable.c +++ b/src/openvpn/reliable.c @@ -648,6 +648,7 @@ } } } + (void)n_active; /* dmsg might not generate code */ dmsg(D_REL_DEBUG, "ACK reliable_can_send active=3D%d current=3D%d : %s= ", n_active, n_current, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1082?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icad1a52d14311a6f06bda081cab2f4bded8d47ed Gerrit-Change-Number: 1082 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --lb9uknvPrbI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by plaisthos

Fix compiler warning in reliable.c with --disabl=
e-debug

Use the easy way out. Using pre-compiler to completely
av= oid n_active seems like overkill.

Change-Id: Icad1a52d14311a6f06bda0= 81cab2f4bded8d47ed
Signed-off-by: Frank Lichtenheld <frank@...2641...= >
Acked-by: Arne Schwabe <arne-openvpn@...1227...>
Message-I= d: <20250711100405.240625-1-frank@...2641...>
URL: https://www.mai= l-archive.com/openvpn-devel@lists.sourceforge.net/msg32107.html
Signed-o= ff-by: Gert Doering <gert@...1296...>
---
M src/openvpn/reliabl= e.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ss=
h://gerrit.openvpn.net:29418/openvpn refs/changes/82/1082/2
diff --=
git a/src/openvpn/reliable.c b/src/openvpn/reliable.c
index= 6aef112..424d194 100644
--- a/src/openvpn/reliable.c
+++ b/src/openvpn/reliable.c
@@ -648,6 +648,7 @@=
}
}
= }
+ (void)n_a= ctive; /* dmsg might not generate code */
dmsg(D_REL_D= EBUG, "ACK reliable_can_send active=3D%d current=3D%d : %s",
n_active,
n_current,=

To view, visit change 1082. To unsubscribe, or fo= r help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icad1a52d14311a6f06bda081cab= 2f4bded8d47ed
Gerrit-Change-Number: 1082
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--lb9uknvPrbI=--