Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B7B6C3062E for ; Thu, 17 Aug 2023 14:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LObFFktGSPRpGK9I9e6h+1oD2447ctnkTwi5voX4tDM=; b=dPMW9tml8aw56S lp1nK2TdruejqE02maizK4rHpopynrjXMvqVTfBfXQI2X+g4kawtsxbTAsNQqoQ0rgeUuLq2xQpaJ c0jsNyxQ2/17R58iDyByHcavwqa1UiqsXIuAmsck8VkjdCYzZx9qVss2kEzgLPNR3TZeoPhMlOozn 3diepOVa7xC5D9Xy7VGIf5MpWSOQC8bIu/dWy2Ptv4/4BSBr7lSqtx/Tefn5Mwf35Da9IBHdU51gk lAq9kLnHMOuFtkni6e9v9ZsTpGj8JcqIGbckY/kzw/3x7s6OP2UV+Gj3TqNofpUv1qZNJFeFQmorL Udy/mZ1NVbblXJ2eBWLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWeJz-006b7x-00; Thu, 17 Aug 2023 14:49:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWeJv-006b5w-2H for linux-arm-kernel@lists.infradead.org; Thu, 17 Aug 2023 14:49:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C294C1063; Thu, 17 Aug 2023 07:50:33 -0700 (PDT) Received: from [10.57.34.77] (unknown [10.57.34.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D2613F6C4; Thu, 17 Aug 2023 07:49:51 -0700 (PDT) Message-ID: <8609486c-0807-7ab2-8497-c8d105de4b2b@arm.com> Date: Thu, 17 Aug 2023 15:49:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] coresight: core: fix memory leak in dict->fwnode_list To: James Clark , Junhao He , mike.leach@linaro.org, leo.yan@linaro.org Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, jonathan.cameron@huawei.com, yangyicong@huawei.com, prime.zeng@hisilicon.com References: <20230817085937.55590-1-hejunhao3@huawei.com> <20230817085937.55590-3-hejunhao3@huawei.com> <16d7c933-ef2f-682e-742e-641c6a076ac0@arm.com> From: Suzuki K Poulose In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_074955_863089_2EA85392 X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTcvMDgvMjAyMyAxNTo0NiwgSmFtZXMgQ2xhcmsgd3JvdGU6Cj4gCj4gCj4gT24gMTcvMDgv MjAyMyAxNTozOSwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPj4gT24gMTcvMDgvMjAyMyAwOTo1 OSwgSnVuaGFvIEhlIHdyb3RlOgo+Pj4gVGhlcmUgYXJlIG1lbW9yeSBsZWFrcyByZXBvcnRlZCBi eSBrbWVtbGVhazoKPj4+IC4uLgo+Pj4gdW5yZWZlcmVuY2VkIG9iamVjdCAweGZmZmYyMDIwMTAz YzMyMDAgKHNpemUgMjU2KToKPj4+ICDCoMKgIGNvbW0gImluc21vZCIsIHBpZCA0NDc2LCBqaWZm aWVzIDQyOTQ5NzgyNTIgKGFnZSA1MDA3Mi41MzZzKQo+Pj4gIMKgwqAgaGV4IGR1bXAgKGZpcnN0 IDMyIGJ5dGVzKToKPj4+ICDCoMKgwqDCoCAxMCA2MCA0MCAwNiAyOCAyMCBmZiBmZiAxMCBjMCA1 OSAwNiAyMCAyMCBmZiBmZsKgIC5gQC4oIC4uLi5ZLsKgIC4uCj4+PiAgwqDCoMKgwqAgMTAgZTAg NDcgMDYgMjggMjAgZmYgZmYgMTAgMDAgNDkgMDYgMjggMjAgZmYgZmbCoCAuLkcuKCAuLi4uSS4o IC4uCj4+PiAgwqDCoCBiYWNrdHJhY2U6Cj4+PiAgwqDCoMKgwqAgWzwwMDAwMDAwMDM0ZWM0NzI0 Pl0gX19rbWVtX2NhY2hlX2FsbG9jX25vZGUrMHgyZjgvMHgzNDgKPj4+ICDCoMKgwqDCoCBbPDAw MDAwMDAwNTdmYmMxNWQ+XSBfX2ttYWxsb2Nfbm9kZV90cmFja19jYWxsZXIrMHg1Yy8weDExMAo+ Pj4gIMKgwqDCoMKgIFs8MDAwMDAwNTVkNWUzNGI+XSBrcmVhbGxvYysweDhjLzB4MTc4Cj4+PiAg wqDCoMKgwqAgWzwwMDAwMDAwMGE0NjM1YmViPl0gY29yZXNpZ2h0X2FsbG9jX2RldmljZV9uYW1l KzB4MTI4LzB4MTg4Cj4+PiBbY29yZXNpZ2h0XQo+Pj4gIMKgwqDCoMKgIFs8MDAwMDAwMDBhOTJk ZGZlZT5dIGZ1bm5lbF9jc19vcHMrMHgxMC8weGZmZmZmZmZmZmZmZWRhYTAKPj4+IFtjb3Jlc2ln aHRfZnVubmVsXQo+Pj4gIMKgwqDCoMKgIFs8MDAwMDAwMDA0NDllMjBmOD5dIGR5bmFtaWNfZnVu bmVsX2lkcysweDgwLzB4ZmZmZmZmZmZmZmZlZDg0MAo+Pj4gW2NvcmVzaWdodF9mdW5uZWxdCj4+ PiAuLi4KPj4+Cj4+PiB3aGVuIHJlbW92ZSBkcml2ZXIsIHRoZSBnb2xhYiB2YXJpYWJsZXMgZGVm aW5lZCBieSB0aGUgbWFjcm8KPj4+IERFRklORV9DT1JFU0lHSFRfREVWTElTVCB3aWxsIGJlIHJl bGVhc2VkLCBkaWN0LT5ucl9pZHggYW5kCj4+PiBkaWN0LT5md25vZGVfbGlzdCBhcmUgY2xlYXJl ZCB0byAwLiBUaGUgbGlmZXRpbWUgb2YgdGhlIGdvbGFiCj4+PiB2YXJpYWJsZSBoYXMgZW5kZWQu IFNvIHRoZSBidWZmZXIgcG9pbnRlciBpcyBsb3N0Lgo+Pj4KPj4+IFVzZSB0aGUgY2FsbGJhY2sg b2YgZGV2bV9hZGRfYWN0aW9uX29yX3Jlc2V0KCkgdG8gZnJlZSBtZW1vcnkuCj4+Cj4+IFRoYW5r cyBmb3IgdGhlIHJlcG9ydC4gQnV0IHBsZWFzZSBzZWUgYmVsb3c6Cj4+Cj4+Pgo+Pj4gRml4ZXM6 IDBmNWY5YjZiYTllMSAoImNvcmVzaWdodDogVXNlIHBsYXRmb3JtIGFnbm9zdGljIG5hbWVzIikK Pj4+IFNpZ25lZC1vZmYtYnk6IEp1bmhhbyBIZSA8aGVqdW5oYW8zQGh1YXdlaS5jb20+Cj4+PiAt LS0KPj4+ICDCoCBkcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LWNvcmUuYyB8 IDIwICsrKysrKysrKysrKysrKysrKystCj4+PiAgwqAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9od3Ry YWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC1jb3JlLmMKPj4+IGIvZHJpdmVycy9od3RyYWNpbmcv Y29yZXNpZ2h0L2NvcmVzaWdodC1jb3JlLmMKPj4+IGluZGV4IDlmYWJlMDBhNDBkNi4uNjg0OWZh YWQ2OTdkIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVz aWdodC1jb3JlLmMKPj4+ICsrKyBiL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2ln aHQtY29yZS5jCj4+PiBAQCAtMTc1Niw2ICsxNzU2LDIwIEBAIGJvb2wgY29yZXNpZ2h0X2xvc2Vz X2NvbnRleHRfd2l0aF9jcHUoc3RydWN0Cj4+PiBkZXZpY2UgKmRldikKPj4+ICDCoCB9Cj4+PiAg wqAgRVhQT1JUX1NZTUJPTF9HUEwoY29yZXNpZ2h0X2xvc2VzX2NvbnRleHRfd2l0aF9jcHUpOwo+ Pj4gIMKgICt2b2lkIGNvcmVzaWdodF9yZWxlYXNlX2Rldl9saXN0KHZvaWQgKmRhdGEpCj4+PiAr ewo+Pj4gK8KgwqDCoCBzdHJ1Y3QgY29yZXNpZ2h0X2Rldl9saXN0ICpkaWN0ID0gZGF0YTsKPj4+ ICsKPj4+ICvCoMKgwqAgbXV0ZXhfbG9jaygmY29yZXNpZ2h0X211dGV4KTsKPj4+ICsKPj4+ICvC oMKgwqAgaWYgKGRpY3QtPm5yX2lkeCkgewo+Pj4gK8KgwqDCoMKgwqDCoMKgIGtmcmVlKGRpY3Qt PmZ3bm9kZV9saXN0KTsKPj4+ICvCoMKgwqDCoMKgwqDCoCBkaWN0LT5ucl9pZHggPSAwOwo+Pj4g K8KgwqDCoCB9Cj4+PiArCj4+PiArwqDCoMKgIG11dGV4X3VubG9jaygmY29yZXNpZ2h0X211dGV4 KTsKPj4+ICt9Cj4+PiArCj4+PiAgwqAgLyoKPj4+ICDCoMKgICogY29yZXNpZ2h0X2FsbG9jX2Rl dmljZV9uYW1lIC0gR2V0IGFuIGluZGV4IGZvciBhIGdpdmVuIGRldmljZSBpbiB0aGUKPj4+ICDC oMKgICogZGV2aWNlIGluZGV4IGxpc3Qgc3BlY2lmaWMgdG8gYSBkcml2ZXIuIEFuIGluZGV4IGlz IGFsbG9jYXRlZCBmb3IgYQo+Pj4gQEAgLTE3NjYsMTIgKzE3ODAsMTYgQEAKPj4+IEVYUE9SVF9T WU1CT0xfR1BMKGNvcmVzaWdodF9sb3Nlc19jb250ZXh0X3dpdGhfY3B1KTsKPj4+ICDCoCBjaGFy ICpjb3Jlc2lnaHRfYWxsb2NfZGV2aWNlX25hbWUoc3RydWN0IGNvcmVzaWdodF9kZXZfbGlzdCAq ZGljdCwKPj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3Qg ZGV2aWNlICpkZXYpCj4+PiAgwqAgewo+Pj4gLcKgwqDCoCBpbnQgaWR4Owo+Pj4gK8KgwqDCoCBp bnQgaWR4LCByZXQ7Cj4+PiAgwqDCoMKgwqDCoCBjaGFyICpuYW1lID0gTlVMTDsKPj4+ICDCoMKg wqDCoMKgIHN0cnVjdCBmd25vZGVfaGFuZGxlICoqbGlzdDsKPj4+ICDCoCDCoMKgwqDCoMKgIG11 dGV4X2xvY2soJmNvcmVzaWdodF9tdXRleCk7Cj4+PiAgwqAgK8KgwqDCoCByZXQgPSBkZXZtX2Fk ZF9hY3Rpb25fb3JfcmVzZXQoZGV2LCBjb3Jlc2lnaHRfcmVsZWFzZV9kZXZfbGlzdCwKPj4+IGRp Y3QpOwo+Pj4gK8KgwqDCoCBpZiAocmV0KQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGdvdG8gZG9uZTsK Pj4KPj4gVGhpcyBsb29rcyB3cm9uZy4gVGhlIGRldmxpc3Qgc2hvdWxkIGJlIG9ubHkgcmVsZWFz ZWQgb24gdGhlICJkcml2ZXIiCj4+IHVubG9hZCwgbm90IG9uIGV2ZXJ5IGRldmljZSByZWxlYXNl LiBUaGUgbGlzdCByZXRhaW5zIHRoZSBmd25vZGUgdG8KPj4gYXNzaWduIHRoZSBzYW1lIG5hbWUg Zm9yIGEgZGV2aWNlLCBpZiBpdCBpcyByZS1wcm9iZWQgKGUuZy4sIGR1ZSB0bwo+PiAtRVBST0JF X0RFRkVSIGVycm9yKS4KPj4KPj4gU3V6dWtpCj4+Cj4gCj4gSSB0aGluayBpbiB0aGF0IGNhc2Ug bXkgc3VnZ2VzdGlvbiB0byBjaGFuZ2UgaXQgdG8gZGV2bV9rcmVhbGxvY19hcnJheQo+IG1pZ2h0 IGJlIHdyb25nIHRoZW4uIFByb2JhYmx5IHdvcnRoIHB1dHRpbmcgYW4gZXhwbGljaXQgY29tbWVu dCB0aGVyZSBpbgo+IGNhc2Ugc29tZW9uZSB0cmllcyB0byB0aWR5IHVwIGFsbCB0aGUgbm9uIGRl dm0gYWxsb2NhdG9ycyB0byBkZXZtIG9uZXMuCj4gCj4gQnV0IGhvdyBkbyB5b3UgcmVsZWFzZSBh IHNpbmdsZSBkZXZpY2Ugd2l0aG91dCByZWxlYXNpbmcgdGhlIHdob2xlIGRyaXZlcj8KCllvdSBj b3VsZCB1bmJpbmQgYSBkZXZpY2UgZnJvbSB0aGUgZHJpdmVyIGFuZCB0aGF0IHdpbGwgbWFrZSBh bm90aGVyIApkcml2ZXIgcHJvYmUgaXQuIEkga25vdyBpdCB3b3JrcyBmb3IgUENJL3BsYXRmb3Jt IHdpdGggVkZJTy4KClN1enVraQoKPiAKPiBKYW1lcwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK