From: Maarten Lankhorst Subject: Re: [PATCH] drm: fix call_kern.cocci warnings v3 Date: Thu, 25 Oct 2018 12:36:42 +0200 Message-ID: <860e509a-1bff-a2b5-2934-6a2125e8fa40@linux.intel.com> References: <20181025102105.15412-1-david1.zhou@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181025102105.15412-1-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , dri-devel@lists.freedesktop.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMjUtMTAtMTggb20gMTI6MjEgc2NocmVlZiBDaHVubWluZyBaaG91Ogo+IGRyaXZlcnMvZ3B1 L2RybS9kcm1fc3luY29iai5jOjIwMjo0LTE0OiBFUlJPUjogZnVuY3Rpb24gZHJtX3N5bmNvYmpf ZmluZF9zaWduYWxfcHRfZm9yX3BvaW50IGNhbGxlZCBvbiBsaW5lIDM5MCBpbnNpZGUgbG9jayBv biBsaW5lIDM4OSBidXQgdXNlcyBHRlBfS0VSTkVMCj4KPiAgIEZpbmQgZnVuY3Rpb25zIHRoYXQg cmVmZXIgdG8gR0ZQX0tFUk5FTCBidXQgYXJlIGNhbGxlZCB3aXRoIGxvY2tzIGhlbGQuCj4KPiBH ZW5lcmF0ZWQgYnk6IHNjcmlwdHMvY29jY2luZWxsZS9sb2Nrcy9jYWxsX2tlcm4uY29jY2kKPgo+ IHYyOgo+IHN5bmNvYmotPnRpbWVsaW5lIHN0aWxsIG5lZWRzIHByb3RlY3QuCj4KPiB2MzoKPiB1 c2UgYSBnbG9iYWwgc2lnbmFsZWQgZmVuY2UgaW5zdGVhZCBvZiByZS1hbGxvY2F0aW9uLgo+Cj4g U2lnbmVkLW9mZi1ieTogQ2h1bm1pbmcgWmhvdSA8ZGF2aWQxLnpob3VAYW1kLmNvbT4KPiBDYzog TWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBD YzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBDaHJpc3RpYW4gS8O2bmln IDxlYXN5MnJlbWVtYmVyLmNoa0Bnb29nbGVtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9kcnYuYyAgICAgfCAgMiArKwo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmou YyB8IDUyICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIGluY2x1ZGUvZHJt L2RybV9zeW5jb2JqLmggICAgIHwgIDEgKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlv bnMoKyksIDIxIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4gaW5kZXggMzZlOGU5Y2JlYzUy Li4wYTZmMTAyM2Q2YzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPiBAQCAtMzcsNiArMzcsNyBAQAo+ICAj aW5jbHVkZSA8ZHJtL2RybV9jbGllbnQuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fZHJ2Lmg+Cj4g ICNpbmNsdWRlIDxkcm0vZHJtUC5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9zeW5jb2JqLmg+Cj4g IAo+ICAjaW5jbHVkZSAiZHJtX2NydGNfaW50ZXJuYWwuaCIKPiAgI2luY2x1ZGUgImRybV9sZWdh Y3kuaCIKPiBAQCAtMTAwMyw2ICsxMDA0LDcgQEAgc3RhdGljIGludCBfX2luaXQgZHJtX2NvcmVf aW5pdCh2b2lkKQo+ICAJaWYgKHJldCA8IDApCj4gIAkJZ290byBlcnJvcjsKPiAgCj4gKwlkcm1f c3luY29ial9zdHViX2ZlbmNlX2luaXQoKTsKPiAgCWRybV9jb3JlX2luaXRfY29tcGxldGUgPSB0 cnVlOwo+ICAKPiAgCURSTV9ERUJVRygiSW5pdGlhbGl6ZWRcbiIpOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29i ai5jCj4gaW5kZXggYjdlYWE2MDNmMzY4Li42YjNmNWEwNmU0ZDMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5 bmNvYmouYwo+IEBAIC04MCw2ICs4MCwyNyBAQCBzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0 IHsKPiAgCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsKPiAgfTsKPiAgCj4gK3N0YXRpYyBzdHJ1Y3Qg ZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZSBzdHViX3NpZ25hbGVkX2ZlbmNlOwo+ICtzdGF0aWMgdm9p ZCBnbG9iYWxfc3R1Yl9mZW5jZV9yZWxlYXNlKHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlKQo+ICt7 Cj4gKwkvKiBpdCBpcyBpbXBvc3NpYmxlIHRvIGNvbWUgaGVyZSAqLwo+ICsJQlVHKCk7Cj4gK30K V0FSTl9PTl9PTkNFKDEpPyBObyBuZWVkIHRvIGhhbHQgdGhlIG1hY2hpbmUuCgo+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IGRtYV9mZW5jZV9vcHMgZ2xvYmFsX3N0dWJfZmVuY2Vfb3BzID0gewo+ICsJ LmdldF9kcml2ZXJfbmFtZSA9IGRybV9zeW5jb2JqX3N0dWJfZmVuY2VfZ2V0X25hbWUsCj4gKwku Z2V0X3RpbWVsaW5lX25hbWUgPSBkcm1fc3luY29ial9zdHViX2ZlbmNlX2dldF9uYW1lLAo+ICsJ LnJlbGVhc2UgPSBnbG9iYWxfc3R1Yl9mZW5jZV9yZWxlYXNlLAo+ICt9Owo+ICsKPiArdm9pZCBk cm1fc3luY29ial9zdHViX2ZlbmNlX2luaXQodm9pZCkKPiArewo+ICsJc3Bpbl9sb2NrX2luaXQo JnN0dWJfc2lnbmFsZWRfZmVuY2UubG9jayk7Cj4gKwlkbWFfZmVuY2VfaW5pdCgmc3R1Yl9zaWdu YWxlZF9mZW5jZS5iYXNlLAo+ICsJCSAgICAgICAmZ2xvYmFsX3N0dWJfZmVuY2Vfb3BzLAo+ICsJ CSAgICAgICAmc3R1Yl9zaWduYWxlZF9mZW5jZS5sb2NrLAo+ICsJCSAgICAgICAwLCAwKTsKPiAr CWRtYV9mZW5jZV9zaWduYWwoJnN0dWJfc2lnbmFsZWRfZmVuY2UuYmFzZSk7Cj4gK30KPiAgLyoq Cj4gICAqIGRybV9zeW5jb2JqX2ZpbmQgLSBsb29rdXAgYW5kIHJlZmVyZW5jZSBhIHN5bmMgb2Jq ZWN0Lgo+ICAgKiBAZmlsZV9wcml2YXRlOiBkcm0gZmlsZSBwcml2YXRlIHBvaW50ZXIKPiBAQCAt MTExLDI0ICsxMzIsMTQgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPiAgCQkJCSAgICAgIHVp bnQ2NF90IHBvaW50KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0ICpzaWdu YWxfcHQ7Cj4gKwlzdHJ1Y3QgZG1hX2ZlbmNlICpmID0gTlVMTDsKPiAgCj4gKwlzcGluX2xvY2so JnN5bmNvYmotPnB0X2xvY2spOwo+ICAJaWYgKChzeW5jb2JqLT50eXBlID09IERSTV9TWU5DT0JK X1RZUEVfVElNRUxJTkUpICYmCj4gIAkgICAgKHBvaW50IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkg ewo+IC0JCXN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlICpmZW5jZSA9Cj4gLQkJCWt6YWxs b2Moc2l6ZW9mKHN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlKSwKPiAtCQkJCUdGUF9LRVJO RUwpOwo+IC0KPiAtCQlpZiAoIWZlbmNlKQo+IC0JCQlyZXR1cm4gTlVMTDsKPiAtCQlzcGluX2xv Y2tfaW5pdCgmZmVuY2UtPmxvY2spOwo+IC0JCWRtYV9mZW5jZV9pbml0KCZmZW5jZS0+YmFzZSwK PiAtCQkJICAgICAgICZkcm1fc3luY29ial9zdHViX2ZlbmNlX29wcywKPiAtCQkJICAgICAgICZm ZW5jZS0+bG9jaywKPiAtCQkJICAgICAgIHN5bmNvYmotPnRpbWVsaW5lX2NvbnRleHQsCj4gLQkJ CSAgICAgICBwb2ludCk7Cj4gLQo+IC0JCWRtYV9mZW5jZV9zaWduYWwoJmZlbmNlLT5iYXNlKTsK PiAtCQlyZXR1cm4gJmZlbmNlLT5iYXNlOwo+ICsJCWRtYV9mZW5jZV9nZXQoJnN0dWJfc2lnbmFs ZWRfZmVuY2UuYmFzZSk7Cj4gKwkJc3Bpbl91bmxvY2soJnN5bmNvYmotPnB0X2xvY2spOwo+ICsJ CXJldHVybiAmc3R1Yl9zaWduYWxlZF9mZW5jZS5iYXNlOwo+ICAJfQo+ICAKPiAgCWxpc3RfZm9y X2VhY2hfZW50cnkoc2lnbmFsX3B0LCAmc3luY29iai0+c2lnbmFsX3B0X2xpc3QsIGxpc3QpIHsK PiBAQCAtMTM3LDkgKzE0OCwxMiBAQCBzdGF0aWMgc3RydWN0IGRtYV9mZW5jZQo+ICAJCWlmICgo c3luY29iai0+dHlwZSA9PSBEUk1fU1lOQ09CSl9UWVBFX0JJTkFSWSkgJiYKPiAgCQkgICAgKHBv aW50ICE9IHNpZ25hbF9wdC0+dmFsdWUpKQo+ICAJCQljb250aW51ZTsKPiAtCQlyZXR1cm4gZG1h X2ZlbmNlX2dldCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJheS0+YmFzZSk7Cj4gKwkJZiA9IGRtYV9m ZW5jZV9nZXQoJnNpZ25hbF9wdC0+ZmVuY2VfYXJyYXktPmJhc2UpOwo+ICsJCWJyZWFrOwo+ICAJ fQo+IC0JcmV0dXJuIE5VTEw7Cj4gKwlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4g Kwo+ICsJcmV0dXJuIGY7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGRybV9zeW5jb2JqX2FkZF9j YWxsYmFja19sb2NrZWQoc3RydWN0IGRybV9zeW5jb2JqICpzeW5jb2JqLAo+IEBAIC0xNjYsOSAr MTgwLDcgQEAgc3RhdGljIHZvaWQgZHJtX3N5bmNvYmpfZmVuY2VfZ2V0X29yX2FkZF9jYWxsYmFj ayhzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosCj4gIAl9Cj4gIAo+ICAJbXV0ZXhfbG9jaygm c3luY29iai0+Y2JfbXV0ZXgpOwo+IC0Jc3Bpbl9sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAg CSpmZW5jZSA9IGRybV9zeW5jb2JqX2ZpbmRfc2lnbmFsX3B0X2Zvcl9wb2ludChzeW5jb2JqLCBw dF92YWx1ZSk7Cj4gLQlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4gIAlpZiAoISpm ZW5jZSkKPiAgCQlkcm1fc3luY29ial9hZGRfY2FsbGJhY2tfbG9ja2VkKHN5bmNvYmosIGNiLCBm dW5jKTsKPiAgCW11dGV4X3VubG9jaygmc3luY29iai0+Y2JfbXV0ZXgpOwo+IEBAIC0zNzksMTEg KzM5MSw5IEBAIGRybV9zeW5jb2JqX3BvaW50X2dldChzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNv YmosIHU2NCBwb2ludCwgdTY0IGZsYWdzLAo+ICAJCWlmIChyZXQgPCAwKQo+ICAJCQlyZXR1cm4g cmV0Owo+ICAJfQo+IC0Jc3Bpbl9sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgCSpmZW5jZSA9 IGRybV9zeW5jb2JqX2ZpbmRfc2lnbmFsX3B0X2Zvcl9wb2ludChzeW5jb2JqLCBwb2ludCk7Cj4g IAlpZiAoISpmZW5jZSkKPiAgCQlyZXQgPSAtRUlOVkFMOwo+IC0Jc3Bpbl91bmxvY2soJnN5bmNv YmotPnB0X2xvY2spOwo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vZHJtX3N5bmNvYmouaCBiL2luY2x1ZGUvZHJtL2RybV9zeW5jb2JqLmgKPiBpbmRl eCAyOTI0NGNiY2QwNWUuLjYzY2ZkMTU0MDI0MSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9k cm1fc3luY29iai5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaAo+IEBAIC0xNDgs NCArMTQ4LDUgQEAgaW50IGRybV9zeW5jb2JqX2dldF9mZChzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5 bmNvYmosIGludCAqcF9mZCk7Cj4gIGludCBkcm1fc3luY29ial9zZWFyY2hfZmVuY2Uoc3RydWN0 IGRybV9zeW5jb2JqICpzeW5jb2JqLCB1NjQgcG9pbnQsIHU2NCBmbGFncywKPiAgCQkJICAgICBz dHJ1Y3QgZG1hX2ZlbmNlICoqZmVuY2UpOwo+ICAKPiArdm9pZCBkcm1fc3luY29ial9zdHViX2Zl bmNlX2luaXQodm9pZCk7Cj4gICNlbmRpZgoKTW92ZSBpdCB0byBkcm1faW50ZXJuYWwuaCA/IFRo aXMgaXMgbm90IGZvciBkcml2ZXIgY29uc3VtcHRpb24uIDopCgppIHdvdWxkIHNwbGl0IHVwIHRo ZSBjaGFuZ2VzIGF0IHRoaXMgcG9pbnQ6CgoxLiBSZXBsYWNlIG1lbW9yeSBhbGxvY2F0aW9uIHdp dGggYSBzdGF0aWMgZmVuY2UsIG5vdCBuZWNlc3NhcmlseSBjaGFuZ2luZyBhbnkgbG9ja2luZywg YWRkIGEgZml4ZXMgdGFnIHRvIHRoaXMgY29tbWl0LgoKMi4gTW92ZSBsb2NraW5nLgoKMy4gRml4 IGRybV9zeW5jb2JqX2ZlbmNlX2dldF9vcl9hZGRfY2FsbGJhY2sgdG8gcmV0dXJuIGFuIGVycm9y LgoKVGhhdCB3YXkgaXQgc2hvdWxkIGJlIG5pY2VseSBiaXNlY3RhYmxlLgoKfk1hYXJ0ZW4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=