From: "reynir (Code Review)" Date: Mon, 22 Apr 2024 11:14:15 +0000 In-Reply-To: References: Reply-To: reynir@...2756..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <86273227cd3500d1217842f034aea27bc3da084d-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="BLLwlk7WIqw="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Only schedule_exit() once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --BLLwlk7WIqw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. reynir has posted comments on this change. ( http://gerrit.openvpn.net/c/op= envpn/+/555?usp=3Demail ) Change subject: Only schedule_exit() once ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/555/comment/b5a7a10b_17482a9e : PS1, Line 529: reset_coarse_timers(c); I am not sure what the above three function calls do and if we should still= call them. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661 Gerrit-Change-Number: 555 Gerrit-PatchSet: 1 Gerrit-Owner: reynir Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: reynir Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 22 Apr 2024 11:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --BLLwlk7WIqw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 1:Code-Review +2=

Vi= ew Change

1 comment:

  • File src/openvpn/forward.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set #1, Line 529:= reset_coarse_timer= s(c);

    = I am not sure what the above three function calls do and if we should still= call them.

To view, visit change 555. To unsubscribe,= or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9457f005f4ba970502e6b667d9d= c4299a588d661
Gerrit-Change-Number: 555
Gerrit-PatchSet: 1
Gerrit-Owner: reynir <reynir@...2756...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: reynir <reynir@...2756...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:14:15= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--BLLwlk7WIqw=--