From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amd/scheduler: fix one used-after-free case for job->s_entity Date: Tue, 24 Oct 2017 12:01:16 +0200 Message-ID: <86482ba2-2d7e-a0f0-72ac-d4e99349cbff@gmail.com> References: <1508838949-29379-1-git-send-email-david1.zhou@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508838949-29379-1-git-send-email-david1.zhou-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Chunming Zhou , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW5kcmV5IGFscmVhZHkgc3VibWl0dGVkIGEgZml4IGZvciB0aGlzIGEgZmV3IGRheXMgYWdvLgoK Q2hyaXN0aWFuLgoKQW0gMjQuMTAuMjAxNyB1bSAxMTo1NSBzY2hyaWViIENodW5taW5nIFpob3U6 Cj4gVGhlIHNfZW50aXR5IHByZXNlbnRlZCBwcm9jZXNzIGNvdWxkIGFscmVhZHkgYmUgY2xvc2Vk IHdoZW4gY2FsbGluZyBhbWRncHVfam9iX2ZyZWVfY2IuCj4gdGhlIHNfZW50aXR5IHdpbGwgYmUg YnVnZ3kgcG9pbnRlciBhZnRlciBpdCdzIGZyZWVkLiBTZWUgYmVsb3cgY2FsbHRyYWNlOgo+Cj4g WyAgMzU1LjYxNjk2NF0gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Cj4gWyAgMzU1LjYxNzE5MV0gQlVHOiBLQVNBTjogdXNl LWFmdGVyLWZyZWUgaW4gYW1kZ3B1X2pvYl9mcmVlX2NiKzB4MmYvMHhjMCBbYW1kZ3B1XQo+IFsg IDM1NS42MTcxOTddIFJlYWQgb2Ygc2l6ZSA4IGF0IGFkZHIgZmZmZjg4MDM5ZDU5M2M0MCBieSB0 YXNrIGt3b3JrZXIvOToxLzEwMAo+Cj4gWyAgMzU1LjYxNzIwNl0gQ1BVOiA5IFBJRDogMTAwIENv bW06IGt3b3JrZXIvOToxIE5vdCB0YWludGVkIDQuMTMuMC1jdXN0b20gIzEKPiBbICAzNTUuNjE3 MjA4XSBIYXJkd2FyZSBuYW1lOiBHaWdhYnl0ZSBUZWNobm9sb2d5IENvLiwgTHRkLiBEZWZhdWx0 IHN0cmluZy9YOTlQLVNMSS1DRiwgQklPUyBGMjMgMDcvMjIvMjAxNgo+IFsgIDM1NS42MTczNDJd IFdvcmtxdWV1ZTogZXZlbnRzIGFtZF9zY2hlZF9qb2JfZmluaXNoIFthbWRncHVdCj4gWyAgMzU1 LjYxNzM0NF0gQ2FsbCBUcmFjZToKPiBbICAzNTUuNjE3MzUxXSAgZHVtcF9zdGFjaysweDYzLzB4 OGQKPiBbICAzNTUuNjE3MzU2XSAgcHJpbnRfYWRkcmVzc19kZXNjcmlwdGlvbisweDcwLzB4Mjkw Cj4gWyAgMzU1LjYxNzQ3NF0gID8gYW1kZ3B1X2pvYl9mcmVlX2NiKzB4MmYvMHhjMCBbYW1kZ3B1 XQo+IFsgIDM1NS42MTc0NzddICBrYXNhbl9yZXBvcnQrMHgyNjUvMHgzNTAKPiBbICAzNTUuNjE3 NDc5XSAgX19hc2FuX2xvYWQ4KzB4NTQvMHg5MAo+IFsgIDM1NS42MTc2MDNdICBhbWRncHVfam9i X2ZyZWVfY2IrMHgyZi8weGMwIFthbWRncHVdCj4gWyAgMzU1LjYxNzcyMV0gIGFtZF9zY2hlZF9q b2JfZmluaXNoKzB4MTYxLzB4MTgwIFthbWRncHVdCj4gWyAgMzU1LjYxNzcyNV0gIHByb2Nlc3Nf b25lX3dvcmsrMHgyYWIvMHg3MDAKPiBbICAzNTUuNjE3NzI3XSAgd29ya2VyX3RocmVhZCsweDkw LzB4NzIwCj4gWyAgMzU1LjYxNzczMV0gIGt0aHJlYWQrMHgxOGMvMHgxZTAKPiBbICAzNTUuNjE3 NzMyXSAgPyBwcm9jZXNzX29uZV93b3JrKzB4NzAwLzB4NzAwCj4gWyAgMzU1LjYxNzczNV0gID8g a3RocmVhZF9jcmVhdGVfb25fbm9kZSsweGIwLzB4YjAKPiBbICAzNTUuNjE3NzM4XSAgcmV0X2Zy b21fZm9yaysweDI1LzB4MzAKPgo+IFsgIDM1NS42MTc3NDJdIEFsbG9jYXRlZCBieSB0YXNrIDEz NDc6Cj4gWyAgMzU1LjYxNzc0N10gIHNhdmVfc3RhY2tfdHJhY2UrMHgxYi8weDIwCj4gWyAgMzU1 LjYxNzc0OV0gIHNhdmVfc3RhY2srMHg0Ni8weGQwCj4gWyAgMzU1LjYxNzc1MV0gIGthc2FuX2tt YWxsb2MrMHhhZC8weGUwCj4gWyAgMzU1LjYxNzc1M10gIGttZW1fY2FjaGVfYWxsb2NfdHJhY2Ur MHhlZi8weDIwMAo+IFsgIDM1NS42MTc4NTNdICBhbWRncHVfZHJpdmVyX29wZW5fa21zKzB4OTgv MHgyOTAgW2FtZGdwdV0KPiBbICAzNTUuNjE3ODgzXSAgZHJtX29wZW4rMHgzOGMvMHg2ZTAgW2Ry bV0KPiBbICAzNTUuNjE3OTA4XSAgZHJtX3N0dWJfb3BlbisweDE0NC8weDFiMCBbZHJtXQo+IFsg IDM1NS42MTc5MTFdICBjaHJkZXZfb3BlbisweDE4MC8weDMyMAo+IFsgIDM1NS42MTc5MTNdICBk b19kZW50cnlfb3BlbisweDNhMi8weDU3MAo+IFsgIDM1NS42MTc5MTVdICB2ZnNfb3BlbisweDg2 LzB4ZTAKPiBbICAzNTUuNjE3OTE4XSAgcGF0aF9vcGVuYXQrMHg0OWUvMHgxZGIwCj4gWyAgMzU1 LjYxNzkxOV0gIGRvX2ZpbHBfb3BlbisweDExYy8weDFhMAo+IFsgIDM1NS42MTc5MjFdICBkb19z eXNfb3BlbisweDE2Zi8weDJhMAo+IFsgIDM1NS42MTc5MjNdICBTeVNfb3BlbisweDFlLzB4MjAK PiBbICAzNTUuNjE3OTI2XSAgZG9fc3lzY2FsbF82NCsweGVhLzB4MjEwCj4gWyAgMzU1LjYxNzky OF0gIHJldHVybl9mcm9tX1NZU0NBTExfNjQrMHgwLzB4NmEKPgo+IFsgIDM1NS42MTc5MzFdIEZy ZWVkIGJ5IHRhc2sgMTM0NzoKPiBbICAzNTUuNjE3OTM0XSAgc2F2ZV9zdGFja190cmFjZSsweDFi LzB4MjAKPiBbICAzNTUuNjE3OTM2XSAgc2F2ZV9zdGFjaysweDQ2LzB4ZDAKPiBbICAzNTUuNjE3 OTM3XSAga2FzYW5fc2xhYl9mcmVlKzB4NzAvMHhjMAo+IFsgIDM1NS42MTc5MzldICBrZnJlZSsw eDlkLzB4MWMwCj4gWyAgMzU1LjYxODAzOF0gIGFtZGdwdV9kcml2ZXJfcG9zdGNsb3NlX2ttcysw eDFiYy8weDNlMCBbYW1kZ3B1XQo+IFsgIDM1NS42MTgwNjNdICBkcm1fcmVsZWFzZSsweDQ1NC8w eDYxMCBbZHJtXQo+IFsgIDM1NS42MTgwNjVdICBfX2ZwdXQrMHgxNzcvMHgzNTAKPiBbICAzNTUu NjE4MDY2XSAgX19fX2ZwdXQrMHhlLzB4MTAKPiBbICAzNTUuNjE4MDY4XSAgdGFza193b3JrX3J1 bisweGEwLzB4YzAKPiBbICAzNTUuNjE4MDcwXSAgZG9fZXhpdCsweDQ1Ni8weDEzMjAKPiBbICAz NTUuNjE4MDcyXSAgZG9fZ3JvdXBfZXhpdCsweDg2LzB4MTMwCj4gWyAgMzU1LjYxODA3NF0gIFN5 U19leGl0X2dyb3VwKzB4MWQvMHgyMAo+IFsgIDM1NS42MTgwNzZdICBkb19zeXNjYWxsXzY0KzB4 ZWEvMHgyMTAKPiBbICAzNTUuNjE4MDc4XSAgcmV0dXJuX2Zyb21fU1lTQ0FMTF82NCsweDAvMHg2 YQo+Cj4gWyAgMzU1LjYxODA4MV0gVGhlIGJ1Z2d5IGFkZHJlc3MgYmVsb25ncyB0byB0aGUgb2Jq ZWN0IGF0IGZmZmY4ODAzOWQ1OTNiODAKPiAgICAgICAgICAgICAgICAgIHdoaWNoIGJlbG9uZ3Mg dG8gdGhlIGNhY2hlIGttYWxsb2MtMjA0OCBvZiBzaXplIDIwNDgKPiBbICAzNTUuNjE4MDg1XSBU aGUgYnVnZ3kgYWRkcmVzcyBpcyBsb2NhdGVkIDE5MiBieXRlcyBpbnNpZGUgb2YKPiAgICAgICAg ICAgICAgICAgIDIwNDgtYnl0ZSByZWdpb24gW2ZmZmY4ODAzOWQ1OTNiODAsIGZmZmY4ODAzOWQ1 OTQzODApCj4gWyAgMzU1LjYxODA4N10gVGhlIGJ1Z2d5IGFkZHJlc3MgYmVsb25ncyB0byB0aGUg cGFnZToKPiBbICAzNTUuNjE4MDkxXSBwYWdlOmZmZmZlYTAwMGU3NTY0MDAgY291bnQ6MSBtYXBj b3VudDowIG1hcHBpbmc6ICAgICAgICAgIChudWxsKSBpbmRleDoweDAgY29tcG91bmRfbWFwY291 bnQ6IDAKPiBbICAzNTUuNjE4MDk1XSBmbGFnczogMHgyZmZmZjAwMDAwMDgxMDAoc2xhYnxoZWFk KQo+IFsgIDM1NS42MTgwOTldIHJhdzogMDJmZmZmMDAwMDAwODEwMCAwMDAwMDAwMDAwMDAwMDAw IDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDEwMDBmMDAwZgo+IFsgIDM1NS42MTgxMDNdIHJhdzog ZmZmZmVhMDAwZWRiMDYwMCAwMDAwMDAwMjAwMDAwMDAyIGZmZmY4ODAzYmZjMGVhMDAgMDAwMDAw MDAwMDAwMDAwMAo+IFsgIDM1NS42MTgxMDVdIHBhZ2UgZHVtcGVkIGJlY2F1c2U6IGthc2FuOiBi YWQgYWNjZXNzIGRldGVjdGVkCj4KPiBbICAzNTUuNjE4MTA4XSBNZW1vcnkgc3RhdGUgYXJvdW5k IHRoZSBidWdneSBhZGRyZXNzOgo+IFsgIDM1NS42MTgxMTBdICBmZmZmODgwMzlkNTkzYjAwOiBm YyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYwo+IFsgIDM1NS42 MTgxMTNdICBmZmZmODgwMzlkNTkzYjgwOiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBm YiBmYiBmYiBmYiBmYiBmYgo+IFsgIDM1NS42MTgxMTZdID5mZmZmODgwMzlkNTkzYzAwOiBmYiBm YiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYgo+IFsgIDM1NS42MTgx MTddICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCj4gWyAgMzU1 LjYxODEyMF0gIGZmZmY4ODAzOWQ1OTNjODA6IGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZi IGZiIGZiIGZiIGZiIGZiIGZiCj4gWyAgMzU1LjYxODEyMl0gIGZmZmY4ODAzOWQ1OTNkMDA6IGZi IGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiIGZiCj4gWyAgMzU1LjYx ODEyNF0gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Cj4gWyAgMzU1LjYxODEyNl0gRGlzYWJsaW5nIGxvY2sgZGVidWdnaW5n IGR1ZSB0byBrZXJuZWwgdGFpbnQKPgo+IENoYW5nZS1JZDogSThmZjcxMjI3OTZiOGNkMTZmYzI2 ZTljNDBlOGQ0YzgxNTNkNjdlMGMKPiBTaWduZWQtb2ZmLWJ5OiBDaHVubWluZyBaaG91IDxkYXZp ZDEuemhvdUBhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIv Z3B1X3NjaGVkdWxlci5jIHwgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIv Z3B1X3NjaGVkdWxlci5oIHwgMjcgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gICAyIGZp bGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuYyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuYwo+IGluZGV4IDAwN2Zk YmQuLjgxMDFlZDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIv Z3B1X3NjaGVkdWxlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1 X3NjaGVkdWxlci5jCj4gQEAgLTUzNSw2ICs1MzUsNyBAQCBpbnQgYW1kX3NjaGVkX2pvYl9pbml0 KHN0cnVjdCBhbWRfc2NoZWRfam9iICpqb2IsCj4gICAJaWYgKCFqb2ItPnNfZmVuY2UpCj4gICAJ CXJldHVybiAtRU5PTUVNOwo+ICAgCWpvYi0+aWQgPSBhdG9taWM2NF9pbmNfcmV0dXJuKCZzY2hl ZC0+am9iX2lkX2NvdW50KTsKPiArCWpvYi0+cHJpb3JpdHkgPSBqb2ItPnNfZW50aXR5LT5ycSAt IGpvYi0+c2NoZWQtPnNjaGVkX3JxOwo+ICAgCj4gICAJSU5JVF9XT1JLKCZqb2ItPmZpbmlzaF93 b3JrLCBhbWRfc2NoZWRfam9iX2ZpbmlzaCk7Cj4gICAJSU5JVF9MSVNUX0hFQUQoJmpvYi0+bm9k ZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hl ZHVsZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuaAo+ IGluZGV4IGUyMTI5OWMuLjg4MDhlYjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9z Y2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5oCj4gQEAgLTc3LDYgKzc3LDE4IEBAIHN0cnVjdCBhbWRf c2NoZWRfZmVuY2Ugewo+ICAgCXZvaWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgKm93bmVy Owo+ICAgfTsKPiAgIAo+ICtlbnVtIGFtZF9zY2hlZF9wcmlvcml0eSB7Cj4gKwlBTURfU0NIRURf UFJJT1JJVFlfTUlOLAo+ICsJQU1EX1NDSEVEX1BSSU9SSVRZX0xPVyA9IEFNRF9TQ0hFRF9QUklP UklUWV9NSU4sCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfTk9STUFMLAo+ICsJQU1EX1NDSEVEX1BS SU9SSVRZX0hJR0hfU1csCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfSElHSF9IVywKPiArCUFNRF9T Q0hFRF9QUklPUklUWV9LRVJORUwsCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfTUFYLAo+ICsJQU1E X1NDSEVEX1BSSU9SSVRZX0lOVkFMSUQgPSAtMSwKPiArCUFNRF9TQ0hFRF9QUklPUklUWV9VTlNF VCA9IC0yCj4gK307Cj4gKwo+ICAgc3RydWN0IGFtZF9zY2hlZF9qb2Igewo+ICAgCXN0cnVjdCBh bWRfZ3B1X3NjaGVkdWxlciAgICAgICAgKnNjaGVkOwo+ICAgCXN0cnVjdCBhbWRfc2NoZWRfZW50 aXR5ICAgICAgICAgKnNfZW50aXR5Owo+IEBAIC04Nyw2ICs5OSw3IEBAIHN0cnVjdCBhbWRfc2No ZWRfam9iIHsKPiAgIAlzdHJ1Y3QgZGVsYXllZF93b3JrCQl3b3JrX3RkcjsKPiAgIAl1aW50NjRf dAkJCWlkOwo+ICAgCWF0b21pY190IGthcm1hOwo+ICsJZW51bSBhbWRfc2NoZWRfcHJpb3JpdHkJ CXByaW9yaXR5Owo+ICAgfTsKPiAgIAo+ICAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vf b3BzIGFtZF9zY2hlZF9mZW5jZV9vcHNfc2NoZWR1bGVkOwo+IEBAIC0xMTgsMTggKzEzMSw2IEBA IHN0cnVjdCBhbWRfc2NoZWRfYmFja2VuZF9vcHMgewo+ICAgCXZvaWQgKCpmcmVlX2pvYikoc3Ry dWN0IGFtZF9zY2hlZF9qb2IgKnNjaGVkX2pvYik7Cj4gICB9Owo+ICAgCj4gLWVudW0gYW1kX3Nj aGVkX3ByaW9yaXR5IHsKPiAtCUFNRF9TQ0hFRF9QUklPUklUWV9NSU4sCj4gLQlBTURfU0NIRURf UFJJT1JJVFlfTE9XID0gQU1EX1NDSEVEX1BSSU9SSVRZX01JTiwKPiAtCUFNRF9TQ0hFRF9QUklP UklUWV9OT1JNQUwsCj4gLQlBTURfU0NIRURfUFJJT1JJVFlfSElHSF9TVywKPiAtCUFNRF9TQ0hF RF9QUklPUklUWV9ISUdIX0hXLAo+IC0JQU1EX1NDSEVEX1BSSU9SSVRZX0tFUk5FTCwKPiAtCUFN RF9TQ0hFRF9QUklPUklUWV9NQVgsCj4gLQlBTURfU0NIRURfUFJJT1JJVFlfSU5WQUxJRCA9IC0x LAo+IC0JQU1EX1NDSEVEX1BSSU9SSVRZX1VOU0VUID0gLTIKPiAtfTsKPiAtCj4gICAvKioKPiAg ICAqIE9uZSBzY2hlZHVsZXIgaXMgaW1wbGVtZW50ZWQgZm9yIGVhY2ggaGFyZHdhcmUgcmluZwo+ ICAgKi8KPiBAQCAtMTgzLDcgKzE4NCw3IEBAIHZvaWQgYW1kX3NjaGVkX2pvYl9raWNrb3V0KHN0 cnVjdCBhbWRfc2NoZWRfam9iICpzX2pvYik7Cj4gICBzdGF0aWMgaW5saW5lIGVudW0gYW1kX3Nj aGVkX3ByaW9yaXR5Cj4gICBhbWRfc2NoZWRfZ2V0X2pvYl9wcmlvcml0eShzdHJ1Y3QgYW1kX3Nj aGVkX2pvYiAqam9iKQo+ICAgewo+IC0JcmV0dXJuIChqb2ItPnNfZW50aXR5LT5ycSAtIGpvYi0+ c2NoZWQtPnNjaGVkX3JxKTsKPiArCXJldHVybiBqb2ItPnByaW9yaXR5Owo+ICAgfQo+ICAgCj4g ICAjZW5kaWYKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK