Date: Fri, 16 Mar 2018 16:50:48 +0000 (UTC) From: Ning Wei Message-ID: <866575943.1904187.1521219048538@...2084...> In-Reply-To: <20180316164554.GI69387@...1296...> References: <20180316164059.9120-1-xiaoningning@...109...> <20180316164554.GI69387@...1296...> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1904186_2137670832.1521219048536" Subject: Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gert Doering Cc: openvpn-devel@lists.sourceforge.net ------=_Part_1904186_2137670832.1521219048536 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you for reminding this.=C2=A0 The reason that I have resent was ther= e was a typo in the commit comment. Best regards,Ning On Friday, March 16, 2018, 9:46:07 AM PDT, Gert Doering wrote:=20=20 =20 Hi, On Fri, Mar 16, 2018 at 09:40:59AM -0700, Ning Wei via Openvpn-devel wrote: > Increase TLS_CHANNEL_BUF_SIZE to 4096. When the build is enabled with > ENABLE_PKCS11, the password field can be 4096.=C2=A0 The old size of > TLS_CHANNEL_BUF_SIZE was 2048, which is not enough. Please do not keep re-sending this patch just because you did not get a response right away.=C2=A0 This messes up our patch tracking in patchwork, and annoys those that will eventually find time to review it. Such a change might cause incompatibilities or overflows in unexpected ways, so a review is complex and not just anyone can do it - and those few that understand the openvpn protocol <-> tls interaction well=20 enough are quite busy with other work. So, patience please. gert --=20 now what should I write here... Gert Doering - Munich, Germany=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gert@...1296...=20=20= ------=_Part_1904186_2137670832.1521219048536 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for reminding this.  The reason that I have= resent was there was a typo in the commit comment.

Best regards,
Ning

=20=20=20=20=20=20=20=20=20=20=20=20
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
On Friday, March 16, 2018, 9:46:07 AM PDT, Gert Doe= ring <gert@...1296...> wrote:


Hi,

On Fri, Mar 16, 2018 at 09:40:59AM -0= 700, Ning Wei via Openvpn-devel wrote:
> Increase TLS_= CHANNEL_BUF_SIZE to 4096. When the build is enabled with
= > ENABLE_PKCS11, the password field can be 4096.  The old size of> TLS_CHANNEL_BUF_SIZE was 2048, which is not enough.

Please do not keep re-sending thi= s patch just because you did not get
a response right awa= y.  This messes up our patch tracking in patchwork,
= and annoys those that will eventually find time to review it.

Such a change might cause incompatibilities or over= flows in unexpected
ways, so a review is complex and not = just anyone can do it - and those
few that understand the= openvpn protocol <-> tls interaction well
enough = are quite busy with other work.

So, pa= tience please.

gert
= --
now what should I write here...
Gert Doering - Munich, Germany        &= nbsp;                   gert@...1296...
= ------=_Part_1904186_2137670832.1521219048536--