From: Andres Rodriguez Subject: Re: [PATCH 1/3] drm/amdgpu: Avoid accessing job->entity after the job is scheduled. Date: Fri, 20 Oct 2017 12:26:45 -0400 Message-ID: <86853e29-07c1-700b-8aa2-2183fbc64d2f@gmail.com> References: <1508506327-1084-1-git-send-email-Andrey.Grodzovsky@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Andrey Grodzovsky , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: christian.koenig-5C7GfCeVMHo@public.gmane.org CgpPbiAyMDE3LTEwLTIwIDEyOjE5IFBNLCBBbmRyZXkgR3JvZHpvdnNreSB3cm90ZToKPiAKPiAK PiBPbiAyMDE3LTEwLTIwIDExOjU5IEFNLCBBbmRyZXMgUm9kcmlndWV6IHdyb3RlOgo+Pgo+Pgo+ PiBPbiAyMDE3LTEwLTIwIDA5OjMyIEFNLCBBbmRyZXkgR3JvZHpvdnNreSB3cm90ZToKPj4+IEJ1 ZzogYW1kZ3B1X2pvYl9mcmVlX2NiIHdhcyBhY2Nlc3Npbmcgc19qb2ItPnNfZW50aXR5IHdoZW4g dGhlIGFsbG9jYXRlZAo+Pj4gYW1kZ3B1X2N0eCAoYW5kIHRoZSBlbnRpdHkgaW5zaWRlIGl0KSB3 ZXJlIGFscmVhZHkgZGVhbGxvY2F0ZWQgZnJvbQo+Pj4gYW1kZ3B1X2NzX3BhcnNlcl9maW5pLgo+ Pj4KPj4+IEZpeDogU2F2ZSBqb2IncyBwcmlvcml0eSBvbiBpdCdzIGNyZWF0aW9uIGluc3RlYWQg b2YgYWNjZXNzaW5nIGl0IGZyb20KPj4+IHNfZW50aXR5IGxhdGVyIG9uLgo+Pgo+PiBJJ20gbm90 IHN1cmUgaWYgdGhpcyBpcyB0aGUgY29ycmVjdCBhcHByb2FjaCBmb3IgYSBmaXguCj4+Cj4+IEtl ZXBpbmcgc19lbnRpdHkgYXMgYSBkYW5nbGluZyBwb2ludGVyIGNvdWxkIHJlc3VsdCBpbiBhIHNp bWlsYXIgYnVncyAKPj4gYmVpbmcgcmVpbnRyb2R1Y2VkLiBGb3IgZXhhbXBsZSwgdGhlcmUgd291 bGQgc3RpbGwgYmUgYSByYWNlIGNvbmRpdGlvbiAKPj4gYmV0d2VlbiBhbWRncHVfY3NfcGFyc2Vy X2ZpbmkoKSBhbmQgYW1kZ3B1X2pvYl9kZXBlbmRlbmN5KCkuCj4gCj4gLmRlcGVuZGVuY3kgaG9v ayBpcyBjYWxsZWQgb25seSBpbiBvbmNlIHBsYWNlIGFtZF9zY2hlZF9lbnRpdHlfcG9wX2pvYiwg Cj4gYW1kZ3B1X2NzX3BhcnNlcl9maW5pIHdpbGwgd2FpdMKgIChmcm9tIGFtZF9zY2hlZF9lbnRp dHlfZmluaSkgZm9yIAo+IHdha2VfdXAoJnNjaGVkLT5qb2Jfc2NoZWR1bGVkKSBmcm9tIGFtZF9z Y2hlZF9tYWluIHNvIEkgZG9uJ3Qgc2VlIGEgcmFjZSAKPiBoZXJlLgo+IAo+Pgo+Pgo+PiBJbnN0 ZWFkLCBpdCBtaWdodCBiZSBiZXR0ZXIgZm9yIHRoZSBqb2IgdG8gZ3JhYiBhIHJlZmVyZW5jZSB0 byB0aGUgCj4+IGNvbnRleHQgZHVyaW5nIGpvYl9pbml0KCksIGFuZCBwdXQgdGhhdCByZWZlcmVu Y2Ugb24gam9iIGZyZWUuCj4gCj4gT3JpZ2luYWxseSBpdCB3YXMgbXkgdGhpbmtpbWcgdG8sIGJ1 dCBJIGNvbnN1bHRlZCBDaHJpc3RpYW4gYW5kIGhlIAo+IGFkdmlzZWQgdGhhdCBxdW90ZSAtICJp dCdzIG5vdCB0aGUgYmVzdCBpZGVhIHNpbmNlCj4gdGhlIHByb2JsZW0gaXMgdGhhdCB3aGVuIHdl IHRlcm1pbmF0ZSBhIHByb2Nlc3Mgd2UgbmVlZCB0byBtYWtlIHN1cmUgCj4gdGhhdCBhbGwgcmVz b3VyY2VzIGFyZSByZWxlYXNlZCBvciBhdCBsZWFzdCBub3QgaG9sZCBmb3IgbXVjaCBsb25nZXIu IAo+IFdoZW4gd2Uga2VlcCB0aGUgY3R4IGFsaXZlIHdpdGggdGhlIGpvYiB3ZSBuZWVkIHRvIGFs c28ga2VlcCB0aGUgVk0gCj4gYWxpdmUgYW5kIHRoYXQgbWVhbnMgd2UgbmVlZCB0byBrZWVwIGFs bCB0aGUgVk0gcGFnZSB0YWJsZXMgYWxpdmUiLgo+IAoKVGhhdCBtYWtlcyBzZW5zZS4KClNpbmNl IHNfZW50aXR5IGlzIHRpZWQgdG8gdGhlIGNvbnRleHQgcmVmZXJlbmNlIGhlbGQgYnkgdGhlIHBh cnNlciwgY2FuIAp5b3Ugc2V0IGl0IHRvIE5VTEwgd2hlbiB5b3UgZHJvcCB0aGUgY29udGV4dCBy ZWZlcmVuY2UgdGhlcmU/CgpBdCBsZWFzdCB0aGF0IHdheSB3ZSBjYW4gZWFzaWx5IGRldGVjdCBt aXN1c2Ugb2Ygc19lbnRpdHkgYWZ0ZXIgaXQgCmVudGVycyBhICJwb3NzaWJseSBkZWxldGVkIiBz dGF0ZS4KClJlZ2FyZHMsCkFuZHJlcwoKPiBUaGFua3MsCj4gQW5kcmV5Cj4gCj4+Cj4+IFJlZ2Fy ZHMsCj4+IEFuZHJlcwo+Pgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJleSBHcm9kem92c2t5 IDxBbmRyZXkuR3JvZHpvdnNreUBhbWQuY29tPgo+Pj4gLS0tCj4+PiDCoCBkcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuY8KgwqDCoMKgwqDCoMKgIHzCoCAzICstLQo+Pj4gwqAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jwqDCoMKgwqDCoMKgIHzCoCA1 ICsrLS0tCj4+PiDCoCBkcml2ZXJzL2dwdS9kcm0vYW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVy LmMgfMKgIDEgKwo+Pj4gwqAgZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVk dWxlci5oIHwgMzIgCj4+PiArKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4+IMKgIDQgZmls ZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jIAo+Pj4gYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYwo+Pj4gaW5kZXggZjdmY2ViNi4u YTc2MGI2ZSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9jcy5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYwo+ Pj4gQEAgLTExOTIsOCArMTE5Miw3IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2NzX3N1Ym1pdChzdHJ1 Y3QgCj4+PiBhbWRncHVfY3NfcGFyc2VyICpwLAo+Pj4gwqDCoMKgwqDCoCBqb2ItPnVmX3NlcXVl bmNlID0gc2VxOwo+Pj4gwqDCoMKgwqDCoMKgwqAgYW1kZ3B1X2pvYl9mcmVlX3Jlc291cmNlcyhq b2IpOwo+Pj4gLcKgwqDCoCBhbWRncHVfcmluZ19wcmlvcml0eV9nZXQoam9iLT5yaW5nLAo+Pj4g LSBhbWRfc2NoZWRfZ2V0X2pvYl9wcmlvcml0eSgmam9iLT5iYXNlKSk7Cj4+PiArwqDCoMKgIGFt ZGdwdV9yaW5nX3ByaW9yaXR5X2dldChqb2ItPnJpbmcsIGpvYi0+YmFzZS5zX3ByaW9yaXR5KTsK Pj4+IMKgwqDCoMKgwqDCoMKgIHRyYWNlX2FtZGdwdV9jc19pb2N0bChqb2IpOwo+Pj4gwqDCoMKg wqDCoCBhbWRfc2NoZWRfZW50aXR5X3B1c2hfam9iKCZqb2ItPmJhc2UpOwo+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9qb2IuYyAKPj4+IGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jCj4+PiBpbmRleCAwY2ZjNjhkLi5hNThl M2M1IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pv Yi5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMKPj4+ IEBAIC0xMDQsNyArMTA0LDcgQEAgc3RhdGljIHZvaWQgYW1kZ3B1X2pvYl9mcmVlX2NiKHN0cnVj dCAKPj4+IGFtZF9zY2hlZF9qb2IgKnNfam9iKQo+Pj4gwqAgewo+Pj4gwqDCoMKgwqDCoCBzdHJ1 Y3QgYW1kZ3B1X2pvYiAqam9iID0gY29udGFpbmVyX29mKHNfam9iLCBzdHJ1Y3QgYW1kZ3B1X2pv YiwgCj4+PiBiYXNlKTsKPj4+IMKgIC3CoMKgwqAgYW1kZ3B1X3JpbmdfcHJpb3JpdHlfcHV0KGpv Yi0+cmluZywgCj4+PiBhbWRfc2NoZWRfZ2V0X2pvYl9wcmlvcml0eShzX2pvYikpOwo+Pj4gK8Kg wqDCoCBhbWRncHVfcmluZ19wcmlvcml0eV9wdXQoam9iLT5yaW5nLCBzX2pvYi0+c19wcmlvcml0 eSk7Cj4+PiDCoMKgwqDCoMKgIGRtYV9mZW5jZV9wdXQoam9iLT5mZW5jZSk7Cj4+PiDCoMKgwqDC oMKgIGFtZGdwdV9zeW5jX2ZyZWUoJmpvYi0+c3luYyk7Cj4+PiDCoMKgwqDCoMKgIGFtZGdwdV9z eW5jX2ZyZWUoJmpvYi0+ZGVwX3N5bmMpOwo+Pj4gQEAgLTE0MSw4ICsxNDEsNyBAQCBpbnQgYW1k Z3B1X2pvYl9zdWJtaXQoc3RydWN0IGFtZGdwdV9qb2IgKmpvYiwgCj4+PiBzdHJ1Y3QgYW1kZ3B1 X3JpbmcgKnJpbmcsCj4+PiDCoMKgwqDCoMKgIGpvYi0+ZmVuY2VfY3R4ID0gZW50aXR5LT5mZW5j ZV9jb250ZXh0Owo+Pj4gwqDCoMKgwqDCoCAqZiA9IGRtYV9mZW5jZV9nZXQoJmpvYi0+YmFzZS5z X2ZlbmNlLT5maW5pc2hlZCk7Cj4+PiDCoMKgwqDCoMKgIGFtZGdwdV9qb2JfZnJlZV9yZXNvdXJj ZXMoam9iKTsKPj4+IC3CoMKgwqAgYW1kZ3B1X3JpbmdfcHJpb3JpdHlfZ2V0KGpvYi0+cmluZywK Pj4+IC0gYW1kX3NjaGVkX2dldF9qb2JfcHJpb3JpdHkoJmpvYi0+YmFzZSkpOwo+Pj4gK8KgwqDC oCBhbWRncHVfcmluZ19wcmlvcml0eV9nZXQoam9iLT5yaW5nLCBqb2ItPmJhc2Uuc19wcmlvcml0 eSk7Cj4+PiDCoMKgwqDCoMKgIGFtZF9zY2hlZF9lbnRpdHlfcHVzaF9qb2IoJmpvYi0+YmFzZSk7 Cj4+PiDCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVyLmMgCj4+PiBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuYwo+Pj4gaW5kZXggZTRkM2I0ZS4uMWJiYmNl MiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hl ZHVsZXIuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVk dWxlci5jCj4+PiBAQCAtNTI5LDYgKzUyOSw3IEBAIGludCBhbWRfc2NoZWRfam9iX2luaXQoc3Ry dWN0IGFtZF9zY2hlZF9qb2IgKmpvYiwKPj4+IMKgIHsKPj4+IMKgwqDCoMKgwqAgam9iLT5zY2hl ZCA9IHNjaGVkOwo+Pj4gwqDCoMKgwqDCoCBqb2ItPnNfZW50aXR5ID0gZW50aXR5Owo+Pj4gK8Kg wqDCoCBqb2ItPnNfcHJpb3JpdHkgPSBlbnRpdHktPnJxIC0gc2NoZWQtPnNjaGVkX3JxOwo+Pj4g wqDCoMKgwqDCoCBqb2ItPnNfZmVuY2UgPSBhbWRfc2NoZWRfZmVuY2VfY3JlYXRlKGVudGl0eSwg b3duZXIpOwo+Pj4gwqDCoMKgwqDCoCBpZiAoIWpvYi0+c19mZW5jZSkKPj4+IMKgwqDCoMKgwqDC oMKgwqDCoCByZXR1cm4gLUVOT01FTTsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVyLmggCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv c2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuaAo+Pj4gaW5kZXggNTJjOGU1NC4uM2Y3NWI0NSAxMDA2 NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIu aAo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5o Cj4+PiBAQCAtMzAsNiArMzAsMTkgQEAKPj4+IMKgIHN0cnVjdCBhbWRfZ3B1X3NjaGVkdWxlcjsK Pj4+IMKgIHN0cnVjdCBhbWRfc2NoZWRfcnE7Cj4+PiDCoCArZW51bSBhbWRfc2NoZWRfcHJpb3Jp dHkgewo+Pj4gK8KgwqDCoCBBTURfU0NIRURfUFJJT1JJVFlfTUlOLAo+Pj4gK8KgwqDCoCBBTURf U0NIRURfUFJJT1JJVFlfTE9XID0gQU1EX1NDSEVEX1BSSU9SSVRZX01JTiwKPj4+ICvCoMKgwqAg QU1EX1NDSEVEX1BSSU9SSVRZX05PUk1BTCwKPj4+ICvCoMKgwqAgQU1EX1NDSEVEX1BSSU9SSVRZ X0hJR0hfU1csCj4+PiArwqDCoMKgIEFNRF9TQ0hFRF9QUklPUklUWV9ISUdIX0hXLAo+Pj4gK8Kg wqDCoCBBTURfU0NIRURfUFJJT1JJVFlfS0VSTkVMLAo+Pj4gK8KgwqDCoCBBTURfU0NIRURfUFJJ T1JJVFlfTUFYLAo+Pj4gK8KgwqDCoCBBTURfU0NIRURfUFJJT1JJVFlfSU5WQUxJRCA9IC0xLAo+ Pj4gK8KgwqDCoCBBTURfU0NIRURfUFJJT1JJVFlfVU5TRVQgPSAtMgo+Pj4gK307Cj4+PiArCj4+ PiArCj4+PiDCoCAvKioKPj4+IMKgwqAgKiBBIHNjaGVkdWxlciBlbnRpdHkgaXMgYSB3cmFwcGVy IGFyb3VuZCBhIGpvYiBxdWV1ZSBvciBhIGdyb3VwCj4+PiDCoMKgICogb2Ygb3RoZXIgZW50aXRp ZXMuIEVudGl0aWVzIHRha2UgdHVybnMgZW1pdHRpbmcgam9icyBmcm9tIHRoZWlyCj4+PiBAQCAt ODMsNiArOTYsNyBAQCBzdHJ1Y3QgYW1kX3NjaGVkX2pvYiB7Cj4+PiDCoMKgwqDCoMKgIHN0cnVj dCBkZWxheWVkX3dvcmvCoMKgwqDCoMKgwqDCoCB3b3JrX3RkcjsKPj4+IMKgwqDCoMKgwqAgdWlu dDY0X3TCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlkOwo+Pj4gwqDCoMKgwqDCoCBhdG9taWNfdCBr YXJtYTsKPj4+ICvCoMKgwqAgZW51bSBhbWRfc2NoZWRfcHJpb3JpdHkgc19wcmlvcml0eTsKPj4+ IMKgIH07Cj4+PiDCoMKgwqAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzIGFtZF9z Y2hlZF9mZW5jZV9vcHNfc2NoZWR1bGVkOwo+Pj4gQEAgLTExNCwxOCArMTI4LDYgQEAgc3RydWN0 IGFtZF9zY2hlZF9iYWNrZW5kX29wcyB7Cj4+PiDCoMKgwqDCoMKgIHZvaWQgKCpmcmVlX2pvYiko c3RydWN0IGFtZF9zY2hlZF9qb2IgKnNjaGVkX2pvYik7Cj4+PiDCoCB9Owo+Pj4gwqAgLWVudW0g YW1kX3NjaGVkX3ByaW9yaXR5IHsKPj4+IC3CoMKgwqAgQU1EX1NDSEVEX1BSSU9SSVRZX01JTiwK Pj4+IC3CoMKgwqAgQU1EX1NDSEVEX1BSSU9SSVRZX0xPVyA9IEFNRF9TQ0hFRF9QUklPUklUWV9N SU4sCj4+PiAtwqDCoMKgIEFNRF9TQ0hFRF9QUklPUklUWV9OT1JNQUwsCj4+PiAtwqDCoMKgIEFN RF9TQ0hFRF9QUklPUklUWV9ISUdIX1NXLAo+Pj4gLcKgwqDCoCBBTURfU0NIRURfUFJJT1JJVFlf SElHSF9IVywKPj4+IC3CoMKgwqAgQU1EX1NDSEVEX1BSSU9SSVRZX0tFUk5FTCwKPj4+IC3CoMKg wqAgQU1EX1NDSEVEX1BSSU9SSVRZX01BWCwKPj4+IC3CoMKgwqAgQU1EX1NDSEVEX1BSSU9SSVRZ X0lOVkFMSUQgPSAtMSwKPj4+IC3CoMKgwqAgQU1EX1NDSEVEX1BSSU9SSVRZX1VOU0VUID0gLTIK Pj4+IC19Owo+Pj4gLQo+Pj4gwqAgLyoqCj4+PiDCoMKgICogT25lIHNjaGVkdWxlciBpcyBpbXBs ZW1lbnRlZCBmb3IgZWFjaCBoYXJkd2FyZSByaW5nCj4+PiDCoCAqLwo+Pj4gQEAgLTE3NiwxMCAr MTc4LDQgQEAgYm9vbCBhbWRfc2NoZWRfZGVwZW5kZW5jeV9vcHRpbWl6ZWQoc3RydWN0IAo+Pj4g ZG1hX2ZlbmNlKiBmZW5jZSwKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBzdHJ1Y3QgYW1kX3NjaGVkX2VudGl0eSAqZW50aXR5KTsKPj4+IMKgIHZvaWQgYW1k X3NjaGVkX2pvYl9raWNrb3V0KHN0cnVjdCBhbWRfc2NoZWRfam9iICpzX2pvYik7Cj4+PiDCoCAt c3RhdGljIGlubGluZSBlbnVtIGFtZF9zY2hlZF9wcmlvcml0eQo+Pj4gLWFtZF9zY2hlZF9nZXRf am9iX3ByaW9yaXR5KHN0cnVjdCBhbWRfc2NoZWRfam9iICpqb2IpCj4+PiAtewo+Pj4gLcKgwqDC oCByZXR1cm4gKGpvYi0+c19lbnRpdHktPnJxIC0gam9iLT5zY2hlZC0+c2NoZWRfcnEpOwo+Pj4g LX0KPj4+IC0KPj4+IMKgICNlbmRpZgo+Pj4KPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbWQtZ2Z4Cg==