From: Boris Derzhavets Subject: Re: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it Date: Mon, 9 Mar 2009 04:18:37 -0700 (PDT) Message-ID: <868545.28268.qm@web56102.mail.re3.yahoo.com> References: <49B35829.1010403@goop.org> Reply-To: bderzhavets@yahoo.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0450163293==" Return-path: In-Reply-To: <49B35829.1010403@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , Jeremy Fitzhardinge Cc: Xen-devel , "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" List-Id: xen-devel@lists.xenproject.org --===============0450163293== Content-Type: multipart/alternative; boundary="0-1252859973-1236597517=:28268" --0-1252859973-1236597517=:28268 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable I was able to go through creating PV DomUs images via corresponding pygrub'= s profiles for F10,CentOS 5.2,SNV_106 (64-bit all). However, only Solaris Nevada PV DomU gets loaded via standard pygrub profile.=20 Attempt to load F10 PV:- [2009-03-09 05:33:38 6351] DEBUG (XendDomainInfo:92) XendDomainInfo.create(= ['vm', ['name', 'F10PV'], ['memory', 2048], ['on_reboot', 'restart'], ['on_= crash', 'restart'], ['vcpus', 1], ['on_xend_start', 'ignore'], ['on_xend_st= op', 'ignore'], ['bootloader', '/usr/bin/pygrub'], ['bootloader_args', '-q'= ], ['image', ['linux', ['videoram', 4]]], ['device', ['vbd', ['uname', 'phy= :/dev/sdb5'], ['dev', 'xvda'], ['mode', 'w']]], ['device', ['vif', ['bridge= ', 'eth0']]], ['device', ['vkbd']], ['device', ['vfb', ['vncunused', '1'], = ['type', 'vnc'], ['xauthority', '/root/.Xauthority']]]]) [2009-03-09 05:33:38 6351] DEBUG (XendDomainInfo:2183) XendDomainInfo.const= ructDomain [2009-03-09 05:33:38 6351] DEBUG (balloon:166) Balloon: 7239368 KiB free; n= eed 2048; done. [2009-03-09 05:33:38 6351] DEBUG (XendDomain:452) Adding Domain: 8 [2009-03-09 05:33:38 6351] DEBUG (XendDomainInfo:2362) XendDomainInfo.initD= omain: 8 256 [2009-03-09 05:33:38 12975] DEBUG (XendBootloader:113) Launching bootloader= as ['/usr/bin/pygrub', '--output=3D/var/run/xend/boot/xenbl.29001', '-q', = '/dev/sdb5']. [2009-03-09 05:33:39 6351] ERROR (XendBootloader:213) Boot loader didn't re= turn any data! [2009-03-09 05:33:39 6351] ERROR (XendDomainInfo:472) VM start failed Traceback (most recent call last): =A0 File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 452, in star= t =A0=A0=A0 XendTask.log_progress(31, 60, self._initDomain) =A0 File "//usr/lib64/python/xen/xend/XendTask.py", line 209, in log_progre= ss =A0=A0=A0 retval =3D func(*args, **kwds) =A0 File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 2364, in _in= itDomain =A0=A0=A0 self._configureBootloader() =A0 File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 2765, in _co= nfigureBootloader =A0=A0=A0 bootloader_args, kernel, ramdisk, args) =A0 File "//usr/lib64/python/xen/xend/XendBootloader.py", line 214, in boot= loader =A0=A0=A0 raise VmError, msg Attempt to load CentOS 5.2 PV:- [2009-03-09 06:45:39 6351] DEBUG (XendDomainInfo:92) XendDomainInfo.create(= ['vm', ['name', 'RHEL52PV'], ['memory', 2048], ['vcpus', 1], ['on_xend_star= t', 'ignore'], ['on_xend_stop', 'ignore'], ['image', ['linux', ['videoram',= 4]]], ['device', ['vbd', ['uname', 'phy:/dev/sdb5'], ['dev', 'xvda'], ['mo= de', 'w']]], ['device', ['vif', ['bridge', 'eth0']]]]) [2009-03-09 06:45:39 6351] DEBUG (XendDomainInfo:2183) XendDomainInfo.const= ructDomain [2009-03-09 06:45:39 6351] DEBUG (balloon:166) Balloon: 7239368 KiB free; n= eed 2048; done. [2009-03-09 06:45:39 6351] DEBUG (XendDomain:452) Adding Domain: 12 [2009-03-09 06:45:39 6351] DEBUG (XendDomainInfo:2362) XendDomainInfo.initD= omain: 12 256 [2009-03-09 06:45:39 16739] DEBUG (XendBootloader:113) Launching bootloader= as ['/usr/bin/pygrub', '--output=3D/var/run/xend/boot/xenbl.15023', '/dev/= sdb5']. [2009-03-09 06:45:44 6351] ERROR (XendBootloader:213) Boot loader didn't re= turn any data! [2009-03-09 06:45:44 6351] ERROR (XendDomainInfo:472) VM start failed Traceback (most recent call last): =A0 File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 452, in star= t =A0=A0=A0 XendTask.log_progress(31, 60, self._initDomain) =A0 File "//usr/lib64/python/xen/xend/XendTask.py", line 209, in log_progre= ss =A0=A0=A0 retval =3D func(*args, **kwds) =A0 File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 2364, in _in= itDomain =A0=A0=A0 self._configureBootloader() =A0 File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 2765, in _co= nfigureBootloader =A0=A0=A0 bootloader_args, kernel, ramdisk, args) =A0 File "//usr/lib64/python/xen/xend/XendBootloader.py", line 214, in boot= loader =A0=A0=A0 raise VmError, msg VmError: Boot loader didn't return any data! --- On Sun, 3/8/09, Jeremy Fitzhardinge wrote: From: Jeremy Fitzhardinge Subject: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to us= e it To: "Keir Fraser" Cc: "Xen-devel" , "Marc - A. Dahlhaus [ Admi= nistration | Westermann GmbH ]" , "Boris Derzhavets" Date: Sunday, March 8, 2009, 12:31 AM Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow guests to use it (by setting cr4.OSXSAVE). This prevents crashes in pvops dom0 kernels, as new versions of Linux try to use this feature. (This patch deals with dom0 cpuid; I'm not sure where the right place to set up the default mask for domU is.) Signed-off-by: Jeremy Fitzhardinge diff -r 7f573cb76db4 xen/arch/x86/traps.c --- a/xen/arch/x86/traps.c=09Tue Mar 03 13:22:28 2009 +0000 +++ b/xen/arch/x86/traps.c=09Sat Mar 07 17:02:03 2009 -0800 @@ -757,6 +757,7 @@ __clear_bit(X86_FEATURE_XTPR % 32, &c); __clear_bit(X86_FEATURE_PDCM % 32, &c); __clear_bit(X86_FEATURE_DCA % 32, &c); + __clear_bit(X86_FEATURE_XSAVE % 32, &c); if ( !cpu_has_apic ) __clear_bit(X86_FEATURE_X2APIC % 32, &c); __set_bit(X86_FEATURE_HYPERVISOR % 32, &c); diff -r 7f573cb76db4 xen/include/asm-x86/cpufeature.h --- a/xen/include/asm-x86/cpufeature.h=09Tue Mar 03 13:22:28 2009 +0000 +++ b/xen/include/asm-x86/cpufeature.h=09Sat Mar 07 17:02:03 2009 -0800 @@ -95,6 +95,7 @@ #define X86_FEATURE_SSE4_2=09(4*32+20) /* Streaming SIMD Extensions 4.2 */ #define X86_FEATURE_X2APIC=09(4*32+21) /* Extended xAPIC */ #define X86_FEATURE_POPCNT=09(4*32+23) /* POPCNT instruction */ +#define X86_FEATURE_XSAVE=09(4*32+26) /* XSAVE/XRSTOR/XSETBV/XGETBV */ #define X86_FEATURE_HYPERVISOR=09(4*32+31) /* Running under some hypervisor= */ /* VIA/Cyrix/Centaur-defined CPU features, CPUID level 0xC0000001, word 5 *= / =0A=0A=0A --0-1252859973-1236597517=:28268 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable
=0A=0A=0A=0A --0-1252859973-1236597517=:28268-- --===============0450163293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0450163293==--
I was able to go through creating PV DomUs im= ages via corresponding pygrub's profiles for F10,CentOS 5.2,SNV_106 (64-bit= all).
However, only Solaris Nevada PV DomU gets loaded via standard
= pygrub profile.

Attempt to load F10 PV:-

[2009-03-09 05:33:3= 8 6351] DEBUG (XendDomainInfo:92) XendDomainInfo.create(['vm', ['name', 'F1= 0PV'], ['memory', 2048], ['on_reboot', 'restart'], ['on_crash', 'restart'],= ['vcpus', 1], ['on_xend_start', 'ignore'], ['on_xend_stop', 'ignore'], ['b= ootloader', '/usr/bin/pygrub'], ['bootloader_args', '-q'], ['image', ['linu= x', ['videoram', 4]]], ['device', ['vbd', ['uname', 'phy:/dev/sdb5'], ['dev= ', 'xvda'], ['mode', 'w']]], ['device', ['vif', ['bridge', 'eth0']]], ['dev= ice', ['vkbd']], ['device', ['vfb', ['vncunused', '1'], ['type', 'vnc'], ['= xauthority', '/root/.Xauthority']]]])
[2009-03-09 05:33:38 6351] DEBUG (XendDomainInfo:2183) XendDomainInfo.constructDomain
[2009-03-09 05:33:= 38 6351] DEBUG (balloon:166) Balloon: 7239368 KiB free; need 2048; done.[2009-03-09 05:33:38 6351] DEBUG (XendDomain:452) Adding Domain: 8
[200= 9-03-09 05:33:38 6351] DEBUG (XendDomainInfo:2362) XendDomainInfo.initDomai= n: 8 256
[2009-03-09 05:33:38 12975] DEBUG (XendBootloader:113) Launchin= g bootloader as ['/usr/bin/pygrub', '--output=3D/var/run/xend/boot/xenbl.29= 001', '-q', '/dev/sdb5'].
[2009-03-09 05:33:39 6351] ERROR (XendBootload= er:213) Boot loader didn't return any data!
[2009-03-09 05:33:39 6351] E= RROR (XendDomainInfo:472) VM start failed
Traceback (most recent call la= st):
  File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 4= 52, in start
    XendTask.log_progress(31, 60, self._init= Domain)
  File "//usr/lib64/python/xen/xend/XendTask.py", line 209,= in log_progress
    retval =3D func(*args, **kwds)
  File "//usr/lib64/python/xen/xend/XendDomainInfo.py", li= ne 2364, in _initDomain
    self._configureBootloader()  File "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 2765, i= n _configureBootloader
    bootloader_args, kernel, ramdi= sk, args)
  File "//usr/lib64/python/xen/xend/XendBootloader.py", l= ine 214, in bootloader
    raise VmError, msg

Atte= mpt to load CentOS 5.2 PV:-

[2009-03-09 06:45:39 6351] DEBUG (XendDo= mainInfo:92) XendDomainInfo.create(['vm', ['name', 'RHEL52PV'], ['memory', = 2048], ['vcpus', 1], ['on_xend_start', 'ignore'], ['on_xend_stop', 'ignore'= ], ['image', ['linux', ['videoram', 4]]], ['device', ['vbd', ['uname', 'phy= :/dev/sdb5'], ['dev', 'xvda'], ['mode', 'w']]], ['device', ['vif', ['bridge= ', 'eth0']]]])
[2009-03-09 06:45:39 6351] DEBUG (XendDomainInfo:2183) Xe= ndDomainInfo.constructDomain
[2009-03-09 06:45:39 6351] DEBUG (balloon:166) Balloon: 7239368 KiB free; need 2048; done.
[2009-03-09 0= 6:45:39 6351] DEBUG (XendDomain:452) Adding Domain: 12
[2009-03-09 06:45= :39 6351] DEBUG (XendDomainInfo:2362) XendDomainInfo.initDomain: 12 256
= [2009-03-09 06:45:39 16739] DEBUG (XendBootloader:113) Launching bootloader= as ['/usr/bin/pygrub', '--output=3D/var/run/xend/boot/xenbl.15023', '/dev/= sdb5'].
[2009-03-09 06:45:44 6351] ERROR (XendBootloader:213) Boot loade= r didn't return any data!
[2009-03-09 06:45:44 6351] ERROR (XendDomainIn= fo:472) VM start failed
Traceback (most recent call last):
  Fil= e "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 452, in start
&n= bsp;   XendTask.log_progress(31, 60, self._initDomain)
  = File "//usr/lib64/python/xen/xend/XendTask.py", line 209, in log_progress    retval =3D func(*args, **kwds)
  File "//usr/l= ib64/python/xen/xend/XendDomainInfo.py", line 2364, in _initDomain
    self._configureBootloader()
  Fi= le "//usr/lib64/python/xen/xend/XendDomainInfo.py", line 2765, in _configur= eBootloader
    bootloader_args, kernel, ramdisk, args)  File "//usr/lib64/python/xen/xend/XendBootloader.py", line 214, in= bootloader
    raise VmError, msg
VmError: Boot loade= r didn't return any data!









--- On = Sun, 3/8/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote:<= br>
From: Jeremy Fitzhardinge <jeremy@goop.org&g= t;
Subject: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests= to use it
To: "Keir Fraser" <keir.fraser@eu.citrix.com>
Cc: "X= en-devel" <xen-devel@lists.xensource.com>, "Marc - A. Dahlhaus [ Admi= nistration | Westermann GmbH ]" <mad@wol.de>, "Boris Derzhavets" <bderzhavets@yahoo.com>
Date: Sunday, March 8, 2009, 12:31 AM
=
Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow gue=
sts to
use it (by setting cr4.OSXSAVE).

This prevents crashes in = pvops dom0 kernels, as new versions of Linux try
to use this feature.
(This patch deals with dom0 cpuid; I'm not sure where the right place = to
set up the default mask for domU is.)

Signed-off-by: Jeremy Fi= tzhardinge <jeremy.fitzhardinge@citrix.com>

diff -r 7f573cb76d= b4 xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c=09Tue Mar 03 13:22:28= 2009 +0000
+++ b/xen/arch/x86/traps.c=09Sat Mar 07 17:02:03 2009 -0800<= br>@@ -757,6 +757,7 @@
__clear_bit(X86_FEATURE_XTPR % 32, &c= );
__clear_bit(X86_FEATURE_PDCM % 32, &c);
__clea= r_bit(X86_FEATURE_DCA % 32, &c);
+ __clear_bit(X86_FEATURE_XS= AVE % 32, &c);
if ( !cpu_has_apic )
=20 __clear_bit(X86_FEATURE_X2APIC % 32, &c);
__set_bit(X86_FEA= TURE_HYPERVISOR % 32, &c);
diff -r 7f573cb76db4 xen/include/asm-x86/= cpufeature.h
--- a/xen/include/asm-x86/cpufeature.h=09Tue Mar 03 13:22:2= 8 2009 +0000
+++ b/xen/include/asm-x86/cpufeature.h=09Sat Mar 07 17:02:0= 3 2009 -0800
@@ -95,6 +95,7 @@
#define X86_FEATURE_SSE4_2=09(4*32+20)= /* Streaming SIMD Extensions 4.2 */
#define X86_FEATURE_X2APIC=09(4*32+= 21) /* Extended xAPIC */
#define X86_FEATURE_POPCNT=09(4*32+23) /* POPCN= T instruction */
+#define X86_FEATURE_XSAVE=09(4*32+26) /* XSAVE/XRSTOR/= XSETBV/XGETBV */
#define X86_FEATURE_HYPERVISOR=09(4*32+31) /* Running u= nder some hypervisor */

/* VIA/Cyrix/Centaur-defined CPU features, C= PUID level 0xC0000001, word 5 */