From: Oscar Mateo Subject: Re: [PATCH] drm/i915/guc: Make intel_guc_send a function pointer Date: Tue, 7 Feb 2017 00:43:52 -0800 Message-ID: <868c09cc-bd08-b737-acba-77735cdd6301@intel.com> References: <1486050166-32672-1-git-send-email-oscar.mateo@intel.com> <20170203114810.GA48604@mwajdecz-MOBL1.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D3146E73B for ; Tue, 7 Feb 2017 16:43:49 +0000 (UTC) In-Reply-To: <20170203114810.GA48604@mwajdecz-MOBL1.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgoKT24gMDIvMDMvMjAxNyAwMzo0OCBBTSwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiBPbiBU aHUsIEZlYiAwMiwgMjAxNyBhdCAwNzo0Mjo0NkFNIC0wODAwLCBPc2NhciBNYXRlbyB3cm90ZToK Pj4gRnJvbTogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4+ Cj4+IFByZXBhcmUgZm9yIGFuIGFsdGVybmF0ZSBHdUMgY29tbXVuaWNhdGlvbiBpbnRlcmZhY2Uu Cj4+Cj4+IHYyOiBNYWtlIGEgZmV3IGZ1bmN0aW9ucyBzdGF0aWMgYW5kIG5hbWUgdGhlbSBjb3Jy ZWN0bHkgd2hpbGUgd2UgYXJlIGF0IGl0IChPc2NhcikKPj4KPj4gU2lnbmVkLW9mZi1ieTogTWlj aGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTog TWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4+IFNpZ25lZC1v ZmYtYnk6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgfCAyNSArKysrKysrKysrKysrKystLS0tLS0t LS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuaCB8ICA5ICsrKysrKysrLQo+ PiAgIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4+ Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+PiBpbmRleCBjNDZiYzg1Li4wZTQ1ZWYwIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPj4gQEAgLTI1LDE2ICsyNSwxMSBAQAo+PiAgICNp bmNsdWRlICJpOTE1X2Rydi5oIgo+PiAgICNpbmNsdWRlICJpbnRlbF91Yy5oIgo+PiAgIAo+PiAt dm9pZCBpbnRlbF91Y19pbml0X2Vhcmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPj4gLXsKPj4gLQltdXRleF9pbml0KCZkZXZfcHJpdi0+Z3VjLnNlbmRfbXV0ZXgpOwo+PiAt fQo+PiAtCj4+ICAgLyoKPj4gICAgKiBSZWFkIEd1QyBjb21tYW5kL3N0YXR1cyByZWdpc3RlciAo U09GVF9TQ1JBVENIXzApCj4+ICAgICogUmV0dXJuIHRydWUgaWYgaXQgY29udGFpbnMgYSByZXNw b25zZSByYXRoZXIgdGhhbiBhIGNvbW1hbmQKPj4gICAgKi8KPj4gLXN0YXRpYyBib29sIGludGVs X2d1Y19yZWN2KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTMyICpzdGF0dXMpCj4+ICtzdGF0aWMg Ym9vbCBndWNfcmVjdihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHUzMiAqc3RhdHVzKQo+PiAgIHsK Pj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3Vj KTsKPj4gICAKPj4gQEAgLTQzLDcgKzM4LDEwIEBAIHN0YXRpYyBib29sIGludGVsX2d1Y19yZWN2 KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTMyICpzdGF0dXMpCj4+ICAgCXJldHVybiBJTlRFTF9H VUNfUkVDVl9JU19SRVNQT05TRSh2YWwpOwo+PiAgIH0KPj4gICAKPj4gLWludCBpbnRlbF9ndWNf c2VuZChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqYWN0aW9uLCB1MzIgbGVuKQo+ PiArLyoKPj4gKyAqIFRoaXMgZnVuY3Rpb24gaW1wbGVtZW50cyB0aGUgTU1JTyBiYXNlZCBob3N0 IHRvIEd1QyBpbnRlcmZhY2UuCj4+ICsgKi8KPj4gK3N0YXRpYyBpbnQgZ3VjX3NlbmRfbW1pbyhz dHJ1Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqYWN0aW9uLCB1MzIgbGVuKQo+IEJ0dywg d2hpbGUgdGhpcyBjaGFuZ2UgaXMgZmluZSBmb3Igbm93LCB3aGF0IGlmIGluIHRoZSBmdXR1cmUg d2Ugd2lsbCBuZWVkCj4gTU1JTyBiYXNlZCBpbnRlcmZhY2UgZm9yIHNvbWUga2luZCBvZiBPT0Ig Y29tbXVuaWNhdGlvbiB0byBHdUMgdGhhdCBieXBhc3Nlcwo+IGFsdGVybmF0ZSBpbnRlcmZhY2U/ Ckkgc2VlLiBTbyB5b3UnZCBwcmVmZXIgdG8gaGF2ZSBhbiBpbnRlbF9ndWNfc2VuZCBmb3Igbm9y bWFsIApjb21tdW5pY2F0aW9uIHdpdGggdGhlIEd1QyBhbmQgYW4gaW50ZWxfZ3VjX3NlbmRfbW1p byBmb3IgdGhlIGZldyBjYXNlcyAKd2hlcmUgeW91IHdhbnQgdG8gZmFsbGJhY2sgdG8gYSBNTUlP IHN0eWxlPyBJJ2xsIGNoYW5nZSB0aGlzIGFuZCByZXNlbmQuCj4+ICAgewo+PiAgIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwo+PiAgIAl1MzIg c3RhdHVzOwo+PiBAQCAtNzEsOSArNjksOSBAQCBpbnQgaW50ZWxfZ3VjX3NlbmQoc3RydWN0IGlu dGVsX2d1YyAqZ3VjLCBjb25zdCB1MzIgKmFjdGlvbiwgdTMyIGxlbikKPj4gICAJICogdXAgdG8g dGhhdCBsZW5ndGggb2YgdGltZSwgdGhlbiBzd2l0Y2ggdG8gYSBzbG93ZXIgc2xlZXAtd2FpdCBs b29wLgo+PiAgIAkgKiBObyBpbnRlX2d1Y19zZW5kIGNvbW1hbmQgc2hvdWxkIGV2ZXIgdGFrZSBs b25nZXIgdGhhbiAxMG1zLgo+PiAgIAkgKi8KPj4gLQlyZXQgPSB3YWl0X2Zvcl91cyhpbnRlbF9n dWNfcmVjdihndWMsICZzdGF0dXMpLCAxMCk7Cj4+ICsJcmV0ID0gd2FpdF9mb3JfdXMoZ3VjX3Jl Y3YoZ3VjLCAmc3RhdHVzKSwgMTApOwo+PiAgIAlpZiAocmV0KQo+PiAtCQlyZXQgPSB3YWl0X2Zv cihpbnRlbF9ndWNfcmVjdihndWMsICZzdGF0dXMpLCAxMCk7Cj4+ICsJCXJldCA9IHdhaXRfZm9y KGd1Y19yZWN2KGd1YywgJnN0YXR1cyksIDEwKTsKPj4gICAJaWYgKHN0YXR1cyAhPSBJTlRFTF9H VUNfU1RBVFVTX1NVQ0NFU1MpIHsKPj4gICAJCS8qCj4+ICAgCQkgKiBFaXRoZXIgdGhlIEd1QyBl eHBsaWNpdGx5IHJldHVybmVkIGFuIGVycm9yICh3aGljaAo+PiBAQCAtOTgsNiArOTYsMTQgQEAg aW50IGludGVsX2d1Y19zZW5kKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgY29uc3QgdTMyICphY3Rp b24sIHUzMiBsZW4pCj4+ICAgCXJldHVybiByZXQ7Cj4+ICAgfQo+PiAgIAo+PiArdm9pZCBpbnRl bF91Y19pbml0X2Vhcmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gK3sK Pj4gKwlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPj4gKwo+PiArCW11 dGV4X2luaXQoJmRldl9wcml2LT5ndWMuc2VuZF9tdXRleCk7Cj4gTm8gbmVlZCB0byB1c2UgZGV2 X3ByaXYgaGVyZSwgeW91IGNhbiByZWZlciB0byB0aGUgZ3VjIGRpcmVjdGx5Lgo+Cj4gUmVnYXJk cywKPiBNaWNoYWwKQUNLLiBJJ2xsIGZpeCBpdCBpbiB0aGUgbmV4dCB2ZXJzaW9uLgoKPj4gKwln dWMtPnNlbmQgPSBndWNfc2VuZF9tbWlvOwo+PiArfQo+PiArCj4+ICAgaW50IGludGVsX2d1Y19z YW1wbGVfZm9yY2V3YWtlKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPj4gICB7Cj4+ICAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4+IEBAIC0x MTMsNCArMTE5LDMgQEAgaW50IGludGVsX2d1Y19zYW1wbGVfZm9yY2V3YWtlKHN0cnVjdCBpbnRl bF9ndWMgKmd1YykKPj4gICAKPj4gICAJcmV0dXJuIGludGVsX2d1Y19zZW5kKGd1YywgYWN0aW9u LCBBUlJBWV9TSVpFKGFjdGlvbikpOwo+PiAgIH0KPj4gLQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vj LmgKPj4gaW5kZXggZDc0ZjRkMy4uYWVkODY1MyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdWMuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91 Yy5oCj4+IEBAIC0xNzQsNiArMTc0LDkgQEAgc3RydWN0IGludGVsX2d1YyB7Cj4+ICAgCj4+ICAg CS8qIFRvIHNlcmlhbGl6ZSB0aGUgaW50ZWxfZ3VjX3NlbmQgYWN0aW9ucyAqLwo+PiAgIAlzdHJ1 Y3QgbXV0ZXggc2VuZF9tdXRleDsKPj4gKwo+PiArCS8qIEd1QydzIEZXIHNwZWNpZmljIHNlbmQg ZnVuY3Rpb24gKi8KPj4gKwlpbnQgKCpzZW5kKShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0 IHUzMiAqZGF0YSwgdTMyIGxlbik7Cj4+ICAgfTsKPj4gICAKPj4gICBzdHJ1Y3QgaW50ZWxfaHVj IHsKPj4gQEAgLTE4NSw5ICsxODgsMTMgQEAgc3RydWN0IGludGVsX2h1YyB7Cj4+ICAgCj4+ICAg LyogaW50ZWxfdWMuYyAqLwo+PiAgIHZvaWQgaW50ZWxfdWNfaW5pdF9lYXJseShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+PiAtaW50IGludGVsX2d1Y19zZW5kKHN0cnVjdCBp bnRlbF9ndWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4pOwo+PiAgIGludCBpbnRl bF9ndWNfc2FtcGxlX2ZvcmNld2FrZShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpOwo+PiAgIAo+PiAr c3RhdGljIGlubGluZSBpbnQgaW50ZWxfZ3VjX3NlbmQoc3RydWN0IGludGVsX2d1YyAqZ3VjLCBj b25zdCB1MzIgKmFjdGlvbiwgdTMyIGxlbikKPj4gK3sKPj4gKwlyZXR1cm4gZ3VjLT5zZW5kKGd1 YywgYWN0aW9uLCBsZW4pOwo+PiArfQo+PiArCj4+ICAgLyogaW50ZWxfZ3VjX2xvYWRlci5jICov Cj4+ICAgZXh0ZXJuIHZvaWQgaW50ZWxfZ3VjX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KTsKPj4gICBleHRlcm4gaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+PiAtLSAKPj4gMS45LjEKPj4KCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK