From: "d12fk (Code Review)" Date: Thu, 31 Jul 2025 12:07:39 +0000 In-Reply-To: References: Reply-To: heiko@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <86fce696fb8c01f7e0b77454db30af16bc9e9e52-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xJGL5uyh+FA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --xJGL5uyh+FA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1121?usp=3Demail ) Change subject: Fix DNS options duplication on PUSH_UPDATE ...................................................................... Patch Set 2: (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1121/comment/cc9f9b67_aace83f8 : PS2, Line 18: were added to existing once instead of overwriting them. *existing ones http://gerrit.openvpn.net/c/openvpn/+/1121/comment/6f40d257_3c5dd855 : PS2, Line 22: - reseting tuntap DNS options (regression from abovementione= d commit) *resetting File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1121/comment/769a02c7_b70d0065 : PS2, Line 3548: if (s) s will never be NULL here, in that case we'd branched to /* Copy --dhcp-opt= ions to tuntap_options */ above already http://gerrit.openvpn.net/c/openvpn/+/1121/comment/c0668a3d_ef605be7 : PS2, Line 6227: This code should instead store the DNS related things in `options->dns_opti= ons.from_dhcp`. Using `tuntap_options` directly is not how it is done any l= onger. Instead "values" of whatever origin are copied to `tuntap_options` d= uring the postprocess stage if needed. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1121?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787 Gerrit-Change-Number: 1121 Gerrit-PatchSet: 2 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: d12fk Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Thu, 31 Jul 2025 12:07:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --xJGL5uyh+FA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

View = Change

4 comments:

  • Commit Message:

  • File src/openvpn/options.c:

    • Patch Set #2, Line 3548: if (s)

      s will never be NULL her= e, in that case we'd branched to /* Copy --dhcp-options to tuntap_optio= ns */ above already

    • <= p style=3D"margin-bottom: 4px;">Patch Set #2, Line 6227:

      This code should instead store the DNS r= elated things in `options->dns_options.from_dhcp`. Using `tuntap_options= ` directly is not how it is done any longer. Instead "values" of = whatever origin are copied to `tuntap_options` during the postprocess stage= if needed.

To view, visit change 1121. To unsubscrib= e, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ife4d8fc5f8e2183e61226d66a76= bbaa02c06f787
Gerrit-Change-Number: 1121
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: d12fk <heiko@...515...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Thu, 31 Jul 2025 12:07:39= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--xJGL5uyh+FA=--