Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AB5A33A6E9; Thu, 30 Jul 2026 07:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785397705; cv=none; b=E8h+8GotqJzLsY64t+1VlLmh53HxRcH3DtKxJ48fagfgoLPY/AgEyTNFwHYCgs6/b3MAVI7gJ6Gyp4lRSQQF1CsQExXzgALactXp0GRpEghTwXDjqzMEnX0/cqCkU6YZdpNVhegtMeROQ/NXQKMa/F4ltxxe52OJNUQzr5WsaKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785397705; c=relaxed/simple; bh=FsenuTaz/BFderDKHsgfa4o9Sr20Q65dASpKlc2LKXY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Xu6+lVdCI5MnFniQb8OSsqDCq5EG7c7HMcWx6wIZEhPNLL57yjNkKDnOwUmjyDKMQap6xBa1prCzt7m/SiCCBHvrkBqbxF8KZ0ih5C18M60jZ9wKE7PaZZzgnGetUnn68rFebqUtQBJX3mW4sAGNsq7fBK4xOv8nV09SFKcYRMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PzxP+QNA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PzxP+QNA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A50BD1F000E9; Thu, 30 Jul 2026 07:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785397703; bh=qOQlhF4huR1pkFA8sB/XUChT+M4qAMQuuGlhdgNtNv8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=PzxP+QNAUlM+nGSwqxo8OwWhSLh41PsM4LN9QnHDDTYDVKGprUB7RBi10crow+Cxd t7LaT0DU9f6bhyb+mZI0/bdtGaILOEHvFENjPsecVE0IpxoupdrRRjgwQOiDWZPZ1x VbY+xdQJMyc1aQRTQ4B5GeisYm4QJSmNGuKXNYI2oaWACD8D5Z4NH9WFBb8YxhZu9t +JAfjJZhNCpXLdwckl7isRtpal83nJM+g5r37eG7pQPQq6Dqti//ebsnvSrNEXB3MJ bkM/gujhrWP/bGg/N8zJHqQCuwcsTKYNEB+ErXdagO5z2WeKlm5I6kWwFwnWaKdZET Xl4RjNyctnP1w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wpLV7-0000000APud-3d9k; Thu, 30 Jul 2026 07:48:21 +0000 Date: Thu, 30 Jul 2026 08:48:21 +0100 Message-ID: <86pl04dika.wl-maz@kernel.org> From: Marc Zyngier To: sashiko-reviews@lists.linux.dev Cc: kvmarm@lists.linux.dev, "Oliver Upton" , kvm@vger.kernel.org Subject: Re: [PATCH v4 14/29] arm64: sysreg: Add HCRX_EL2 bits related to FEAT_NV3 In-Reply-To: <20260730074006.07CE71F000E9@smtp.kernel.org> References: <20260730071022.296811-1-maz@kernel.org> <20260730071022.296811-15-maz@kernel.org> <20260730074006.07CE71F000E9@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashiko-reviews@lists.linux.dev, kvmarm@lists.linux.dev, oupton@kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 30 Jul 2026 08:40:05 +0100, sashiko-bot@kernel.org wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [High] Adding new HCRX_EL2 fields (NVnTTLBOS, NVnTTLBIS, NVnTTLB, NVTGE) to the sysreg file silently removes them from the auto-generated HCRX_EL2_RES0 mask, but KVM's feature map was not updated to handle them. This semantic drift breaks KVM validation and allows guests to inject unvirtualized CPU features into the host. "semantic drift" my arse. You're a stuck record. M. -- Without deviation from the norm, progress is not possible.