Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1F811EB2F for ; Tue, 21 May 2024 21:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716326497; cv=none; b=M3fuvbrvkUBC9uLxj2el/y0gatDsdKdpBMEvzgap0PMwf36G/DDP2f/kIfwV0ZOmETKIxwe5ocd8/3TLIOfNbxN2Gbfjuweslv3OlzXb1nSFet1Jimyr5vHkbvGf1mN/hRQKL61lAePj9kJD+GmYBgGl3QElgMQxqVrWAbICBxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716326497; c=relaxed/simple; bh=nQ1+kno34eRI2CH2p2WJJVVsGQQJyU67WUCjO0bZSl0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=P6OivbvZJbBY+V/2eW18wk8zqTDOYcE8NNWNYtalMdttvj7JvOdsEHZ34qHefqWZvqFcB/4a5DxtiQBw2Ph5tXqQfyYruwAvOcMtCDfob2VZ04hbI9boF/Q57MD1o7J6ZlPAQwuMjhGX7DPbl5vmtWvTS8Pf7l6Ee/rJBIvSKlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tFMxKqTk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tFMxKqTk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 253D1C2BD11; Tue, 21 May 2024 21:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716326497; bh=nQ1+kno34eRI2CH2p2WJJVVsGQQJyU67WUCjO0bZSl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tFMxKqTkH0J63NBvzY/8ND0t6Po+mj0NUorz1VwnLfLo3KrLv+D/CeXXmrtSHGhqG 63ugiU3agCp8NaWTqR3GbtgIFmjbFXsP9T/THK3eaAdAnzOJqVlyac+6gyFKrIdot2 GLIFCojpHYKp81v2T0sI6VRX+G2ZCmFHY/ZN0/cXjjiJQ8gUtvmEx13WrO5R1rjBgt FAuaL+FIMbbbXv08yTAZ7+qa092XeZnzHaCN5Fd1E5p26OVLnntA/5eIV9GD2CjtGO c4A4ZEG1uPgMBPnixurUE1MeH2mTdSEvl/9KHQc8qN4leiTnvDYBNC6ROR62KEDxEG O1rTFMRBZ995w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s9WvO-00Eo3U-F5; Tue, 21 May 2024 22:21:34 +0100 Date: Tue, 21 May 2024 22:21:33 +0100 Message-ID: <86r0dun9nm.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, broonie@kernel.org, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com Subject: Re: [PATCH v2 4/7] KVM: arm64: Store the maximum sve vector length at hyp In-Reply-To: <20240521163720.3812851-5-tabba@google.com> References: <20240521163720.3812851-1-tabba@google.com> <20240521163720.3812851-5-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, broonie@kernel.org, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 21 May 2024 17:37:17 +0100, Fuad Tabba wrote: > > In subsequent patches, hyp needs to know the maximum sve vector > length for the host, without needing the trust the host for that. > This is used when allocating memory for the host sve state in the > following patch, as well as for allocating and restricting guest > sve state in a future patch series. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/kvm_host.h | 1 + > arch/arm64/include/asm/kvm_hyp.h | 1 + > arch/arm64/kvm/arm.c | 1 + > arch/arm64/kvm/hyp/nvhe/pkvm.c | 2 ++ > arch/arm64/kvm/reset.c | 2 ++ > 5 files changed, 7 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 8170c04fde91..0a5fceb20f3a 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -76,6 +76,7 @@ static inline enum kvm_mode kvm_get_mode(void) { return KVM_MODE_NONE; }; > DECLARE_STATIC_KEY_FALSE(userspace_irqchip_in_use); > > extern unsigned int __ro_after_init kvm_sve_max_vl; > +extern unsigned int __ro_after_init kvm_host_sve_max_vl; > int __init kvm_arm_init_sve(void); > > u32 __attribute_const__ kvm_target_cpu(void); > diff --git a/arch/arm64/include/asm/kvm_hyp.h b/arch/arm64/include/asm/kvm_hyp.h > index 2ab23589339a..d313adf53bef 100644 > --- a/arch/arm64/include/asm/kvm_hyp.h > +++ b/arch/arm64/include/asm/kvm_hyp.h > @@ -143,5 +143,6 @@ extern u64 kvm_nvhe_sym(id_aa64smfr0_el1_sys_val); > > extern unsigned long kvm_nvhe_sym(__icache_flags); > extern unsigned int kvm_nvhe_sym(kvm_arm_vmid_bits); > +extern unsigned int kvm_nvhe_sym(kvm_host_sve_max_vl); > > #endif /* __ARM64_KVM_HYP_H__ */ > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 9996a989b52e..9e565ea3d645 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -2378,6 +2378,7 @@ static void kvm_hyp_init_symbols(void) > kvm_nvhe_sym(id_aa64smfr0_el1_sys_val) = read_sanitised_ftr_reg(SYS_ID_AA64SMFR0_EL1); > kvm_nvhe_sym(__icache_flags) = __icache_flags; > kvm_nvhe_sym(kvm_arm_vmid_bits) = kvm_arm_vmid_bits; > + kvm_nvhe_sym(kvm_host_sve_max_vl) = kvm_host_sve_max_vl; > } > > static int __init kvm_hyp_init_protection(u32 hyp_va_bits) > diff --git a/arch/arm64/kvm/hyp/nvhe/pkvm.c b/arch/arm64/kvm/hyp/nvhe/pkvm.c > index 16aa4875ddb8..25e9a94f6d76 100644 > --- a/arch/arm64/kvm/hyp/nvhe/pkvm.c > +++ b/arch/arm64/kvm/hyp/nvhe/pkvm.c > @@ -18,6 +18,8 @@ unsigned long __icache_flags; > /* Used by kvm_get_vttbr(). */ > unsigned int kvm_arm_vmid_bits; > > +unsigned int kvm_host_sve_max_vl; > + > /* > * Set trap register values based on features in ID_AA64PFR0. > */ > diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c > index 1b7b58cb121f..e818727900ec 100644 > --- a/arch/arm64/kvm/reset.c > +++ b/arch/arm64/kvm/reset.c > @@ -46,11 +46,13 @@ static u32 __ro_after_init kvm_ipa_limit; > PSR_AA32_I_BIT | PSR_AA32_F_BIT) > > unsigned int __ro_after_init kvm_sve_max_vl; > +unsigned int __ro_after_init kvm_host_sve_max_vl; > > int __init kvm_arm_init_sve(void) > { > if (system_supports_sve()) { > kvm_sve_max_vl = sve_max_virtualisable_vl(); > + kvm_host_sve_max_vl = sve_max_vl(); Why the intermediate storage? Setting kvm_nvhe_sym(kvm_host_sve_max_vl) to sve_max_vl() should be enough. But it doesn't mean that all the CPUs support the same max VL, and I wonder whether we end-up with the wrong in-memory layout in this case... Thanks, M. -- Without deviation from the norm, progress is not possible.