Received: by 2002:a05:693c:2909:b0:17e:9665:bf4c with SMTP id rk9csp1227194dyc; Fri, 4 Jul 2025 06:51:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUwu6zuKY6tWlnTcCdqyq9PGjfuedhufKhc7Fqdgi8ZxgsTU+uXMRWOMv0rO3oKijza3cFSrFghO0JPPw==@linaro.org X-Google-Smtp-Source: AGHT+IHOt9Bj2/X5Z/j02W/uWuXz8PS29RtO9ZjgEozsk5yLUZbqypJkzz+R9ZhOCbqDsIsM759d X-Received: by 2002:ac8:7f83:0:b0:4a3:b6a0:1777 with SMTP id d75a77b69052e-4a9957cd1efmr44653901cf.20.1751637106371; Fri, 04 Jul 2025 06:51:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1751637106; cv=none; d=google.com; s=arc-20240605; b=GGGc6KUYW7BXKBHTgwRe6fBjY4mJ/Lz87/eDuRZHaGJnr9CjswC/WzExRcWf8uDao7 lSOQgkeNbsY270IHp4gCHOhW7KJpMJqvr7Mi2iInJTiQaYby/Ue09rQTyS3CEdIIaqm3 iPh5Ii93hOksV+717c3Sx/o7Y5w4B1688XaCYglmmZe8IDF2PloTk4GD/V1XQnYGfU6D Q2+Ypio/JpQJ0Ird8DlzVI/Veo37h0MjvsGjgRn7V6RRA5vAL5EnU2GWr8Z+R5ct2xhc +ky/tt21dw7Oh46n84AEQDhKAVt7bxHBbjo8mDk+hvbFwP0JzM3/WNC/Qak6XNm9iP53 53Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :references:in-reply-to:subject:cc:to:from:message-id:date :dkim-signature; bh=XWy3yTjZ6fCNfRFK/lbld/z1IhzKGxbr9I3yBeeHErc=; fh=VOrxn0N4VmTEDkEzG+Yq86rn2V3vLjO0lKGiKgQmJhs=; b=QkTEeQB0NC1bl8pTmbmSsJDx0M3NB2aqDao0h5Nv7Pu3EJ30HUdBgzgMV5JLA75eiL BGV99JfGIr0jSzTDgqT94BZiQvXGY/Xtn7OPwef5i4eI9z5Lm079cF3AKbHM+msioRaA MTcP8h4UQm7m0uHC7n7WbapnHaRGlrVCxgFzux+nNYgpov4i/idcB0AWg31u94SMk8h7 kRtp09Vglp6HUCp3GkZ6T4BYeAfGh+CSdasRUi7GqBflPUXdoKYQvXLbBz99E4cYA60z 64fP8kQXhV410eKb//ZshS2p7rbGME2flU5bQ78GcfS4TCplrTTzNqmUcS9B5kvmWKmG sd0g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DgorvigT; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4a994ab405dsi20480691cf.296.2025.07.04.06.51.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jul 2025 06:51:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DgorvigT; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXgpJ-0000VU-54; Fri, 04 Jul 2025 09:51:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXgp9-0000U5-1V; Fri, 04 Jul 2025 09:51:32 -0400 Received: from tor.source.kernel.org ([172.105.4.254]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXgp6-0007pg-Vb; Fri, 04 Jul 2025 09:51:30 -0400 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7E6E261457; Fri, 4 Jul 2025 13:51:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34273C4CEEE; Fri, 4 Jul 2025 13:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751637079; bh=dePqag9toNbk0vZKK+JedM9GAanBG0rzuVg7dhWaoPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DgorvigT0+ibKH+kbAGo+aVEeCXNWL2e1nKV2Tyzy2CPWhy92bjy39P7mbX00uIkd AYB/CbvBOe2ydgKoEvBrgVRNbLeq7GudcKdqdfQ/f61+ja9RNG5Iy772tkJNQWYvLD XQ8qJUHev6bJLUbtF4ZoGr0tn/qglEOwrNPyiskSYEUNNWpZCTPam8XJs4WgWPFPIG oQV+SvLFQmrHT8dwUz0GQqdhptVv2oRdJ3gIoOJBQakNvI8qFYXADiLX/qRZN57D/O 1nbNmBDdhK+gCvGC1KxScMykSfjRsEr+UOuRHQiAVgquxWpfP85BlXHXvhqtcRqWVp b2kJP9Pz35qSg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uXgou-00ChyL-RV; Fri, 04 Jul 2025 14:51:16 +0100 Date: Fri, 04 Jul 2025 14:51:15 +0100 Message-ID: <86zfdk9i98.wl-maz@kernel.org> From: Marc Zyngier To: Peter Maydell Cc: Eric Auger , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, miguel.luis@oracle.com, richard.henderson@linaro.org, gkulkarni@amperecomputing.com, gankulkarni@os.amperecomputing.com, hi@alyssa.is Subject: Re: [PATCH v7 1/4] hw/arm: Allow setting KVM vGIC maintenance IRQ In-Reply-To: References: <20250702163115.251445-1-eric.auger@redhat.com> <20250702163115.251445-2-eric.auger@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: peter.maydell@linaro.org, eric.auger@redhat.com, eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, miguel.luis@oracle.com, richard.henderson@linaro.org, gkulkarni@amperecomputing.com, gankulkarni@os.amperecomputing.com, hi@alyssa.is X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Received-SPF: pass client-ip=172.105.4.254; envelope-from=maz@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.218, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: IwsZHzMX2wx+ On Fri, 04 Jul 2025 13:01:05 +0100, Peter Maydell wrote: > > On Wed, 2 Jul 2025 at 17:31, Eric Auger wrote: > > > > From: Haibo Xu > > > > Allow virt arm machine to set the interrupt ID for the KVM > > GIC maintenance interrupt. > > > > This setting must be done before the KVM_DEV_ARM_VGIC_CTRL_INIT > > hence the choice to perform the setting in the GICv3 realize > > instead of proceeding the same way as kvm_arm_pmu_set_irq(). > > > > Signed-off-by: Haibo Xu > > Signed-off-by: Miguel Luis > > Signed-off-by: Eric Auger > > > @@ -231,6 +231,7 @@ struct GICv3State { > > uint32_t num_cpu; > > uint32_t num_irq; > > uint32_t revision; > > + uint32_t maint_irq; > > bool lpi_enable; > > bool nmi_support; > > bool security_extn; > > > + if (s->maint_irq) { > > + int ret; > > + > > + ret = kvm_device_check_attr(s->dev_fd, > > + KVM_DEV_ARM_VGIC_GRP_MAINT_IRQ, 0); > > + if (!ret) { > > + error_setg_errno(errp, errno, > > + "VGICv3 setting maintenance IRQ is not " > > + "supported by this host kernel"); > > + return; > > + } > > + > > + ret = kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_MAINT_IRQ, 0, > > + &s->maint_irq, true, errp); > > This doesn't seem to line up with what the kernel documents > for KVM_DEV_ARM_VGIC_GRP_MAINT_IRQ: > > https://www.kernel.org/doc/Documentation/virt/kvm/devices/arm-vgic-v3.rst > says > > # KVM_DEV_ARM_VGIC_GRP_MAINT_IRQ > # Attributes: > # > # The attr field of kvm_device_attr encodes the following values: > # > # bits: | 31 .... 5 | 4 .... 0 | > # values: | RES0 | vINTID | > # > # The vINTID specifies which interrupt is generated when the vGIC > # must generate a maintenance interrupt. This must be a PPI. > > but this code sets kvmattr.addr to 0 and kvmaddr.addr to > the address of a uint32_t with the vINTID in it. > > Looking at the kernel code in vgic_v3_attr_regs_access() it > looks like maybe the kernel docs are wrong, but I'm not sure. I think this is a pretty bad case of one person implementing something, and another (me) hoping (but not checking) it would be implemented in a particular way. Oh well. Would the following match your expectations (and the code)? diff --git a/Documentation/virt/kvm/devices/arm-vgic-v3.rst b/Documentation/virt/kvm/devices/arm-vgic-v3.rst index e860498b1e359..4843c91052786 100644 --- a/Documentation/virt/kvm/devices/arm-vgic-v3.rst +++ b/Documentation/virt/kvm/devices/arm-vgic-v3.rst @@ -299,7 +299,7 @@ Groups: KVM_DEV_ARM_VGIC_GRP_MAINT_IRQ Attributes: - The attr field of kvm_device_attr encodes the following values: + The attribute data pointed to by kvm_device_attr.addr is a __u32 value:: bits: | 31 .... 5 | 4 .... 0 | values: | RES0 | vINTID | Thanks, M. -- Without deviation from the norm, progress is not possible.