From: Keith Packard Subject: Re: [PATCH] drm/i915/dp: Add branch/sink OUI debugging Date: Fri, 13 Jan 2012 14:49:00 -0800 Message-ID: <86zkdr1an7.fsf@sumi.keithp.com> References: <1326479168-17162-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1711713337==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 4223F9EC4B for ; Fri, 13 Jan 2012 14:49:16 -0800 (PST) In-Reply-To: <1326479168-17162-1-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1711713337== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 13 Jan 2012 13:26:08 -0500, Adam Jackson wrote: > + count &=3D (~DP_DOWN_STREAM_OUI_SUPPORTED); > + if ((count & DP_DOWN_STREAM_PORT_COUNT_MASK) =3D=3D 0) > + offset =3D DP_SINK_IEEE_OUI; > + else > + offset =3D DP_BRANCH_IEEE_OUI_OUT; I suspect the SINK_IEEE_OUI will be more relevant than the BRANCH_IEEE_OUI, but if you're going to the trouble to tell that there is a downstream device, perhaps you should just report both? > +#define DP_DOWN_STREAM_PORT_COUNT 0x007 > +# define DP_DOWN_STREAM_PORT_COUNT_MASK 0x0f > +# define DP_DOWN_STREAM_OUI_SUPPORTED (1 << 7) > + > +#define DP_SOURCE_IEEE_OUI 0x300 > +#define DP_SINK_IEEE_OUI 0x400 > +#define DP_BRANCH_IEEE_OUI 0x500 > + These definitions match the DP spec, and the code uses them correctly. So, the code looks like it will work, the only question I have is whether the BRANCH or SINK would be more useful for debugging problems... Reviewed-by: Keith Packard =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTxC03DYtFsjWk68qAQhURg/+IqfOSkEBSwsQKrze+cU6T8E17s29Z4hQ 8tXVKqhk83Wu/EqQUlmAIF4KSDAaUesYtcZG0PMQByvg5Q9IIJIM5rfQutnHXAYe EyR7WZe983MOAYpxpPIVPPmYYXQUiDVLO/Y9Y5JHwaxDRLCyhhlhZuUFHQCtpupw WWVBTRXOne2RKLcbmcqMusYlcLreJN5tBXVfHrJcZhdxbyUQkZ3JMq3rPDahpj0A unGT5KWbRDBghxYfgEGOrIwycB91RWTsb6GiU9KvWDiOTy3KD6qYSgNPoDhRmTqa 5/bvdtJjwPrEKpFsk3fTk5hMYsIuJjVdQ/X7GW+lsNMZeGd5EdahhSzW6ETB6Jmp XkPwDZBWshRCLnivCM0YKEnWvz5vMSATGD/n4IvJ1UUP/aQJwPdF19g8HBScHL6T d/adHpKOfTK9pntnbHnmg3yE0BllvehfY875Ys9FnDd7rBBBzYg0dkPMX5onuTrK gMk6qJooG7xBB59TcYx4ABESoABpvE00G0Pkmxe3+dIxY3+/gnikXiDduM3KPrA3 CCVN3Cbw/XS9aaiUZIuhBdn53AwqyqRdqwURq7wPhgdZiaaOiFWJ4dMeJb/j+wGF 3ANADrIodXvgXgE9gaP/xQ0SSsxoHVTPcH7IPzisRu1Og0cDffUfxECA8VaixJMp QGDS7afXOh0= =ilUV -----END PGP SIGNATURE----- --=-=-=-- --===============1711713337== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1711713337==--