Received: by 2002:a17:505:ba85:b0:1be9:327d:8ee3 with SMTP id zs5csp2450570njc; Thu, 12 Jun 2025 09:07:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXxbAScFft2nYteJ8Vf11BjiT5aiDGUmJQLDRfej7KZdKleR9SkbfwhyfG9z+qH/YD+1NIydqHzvctu3w==@linaro.org X-Google-Smtp-Source: AGHT+IH+i89AsBmgncj1lN/mAZiZimOEzDqiHN/iBBVQFVMUuHX0MZYZL7D6y7UcykMZWZOtH5Sd X-Received: by 2002:a05:600c:1d1f:b0:443:48:66d2 with SMTP id 5b1f17b1804b1-4533436530amr2781125e9.16.1749744470070; Thu, 12 Jun 2025 09:07:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749744470; cv=none; d=google.com; s=arc-20240605; b=k42R4TK2EnoLzo1Jk8vSvzdLeYMoJktQN4bOQSQHKNw8PG4myjzd2vhQY00U+rJlE6 8Vbrbo6sf2ERVZEFTVJthSrDviPsA03WT+a5mKwTfe54LE0OOIvD4ZJb6OMSWAxCIfoT BH4TYpkdbjanDlOY11rEv38qqXIUiC1xzYBF6glFzZP/zU0OMu132tl4ry0mSCdETpvE d6knUm3qr0suKDf2eSIP7dtTAfTBUKSh19Ori5ztOAGqvLFJvVii1s8AoFwk+Z8g9zUc vgopBIkmGwC+vNHYLLCYzpycIW94Rjeh63tAJR/6kXGmuDjaDTxrzDgEytLyQEZXPSwE nCcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:message-id:date:user-agent:references:organization :in-reply-to:subject:cc:to:from:dkim-signature; bh=+uVuub5Ky1bzhq7P2Mnf0OieKw5ECMBGCTcKWAjvVoM=; fh=3AH/4enSkYH+0gdMWbJY9r7skS1O9K2SeH+yRsCcYPI=; b=b80eVeQ+V8tRFEZPzCxCJa6qb5+meAyY3EzkAh9VC6GK9jVYB8Cnhk2CrN7ERUPj/o XsSaMY8o+LhSwBSnnaoDPgVoD7wotXHVAjFpfAY3eNXC+/5Bs9M/GgnLEFZcckhD/uQH anbDOW9LRA72ZNyib4EzIQmazk4UjeJKTv+hsJE5XmBhdMlRAU0m9vLalz47ZBgpOKIk WQA9FmujjXmIpjPpiL7MGPjV1RTpWLEGrJvLlh9b2+t5hs3B28pszxpDu6zWibKXImMr ti6KVw/4VX2NnlvJolhwRqaMFJEKj0ynAz1ammtbP0VLchBlII+iKHb1K8dyg+DTdmPo wR1Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jO0NsOjk; spf=pass (google.com: domain of cohuck@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=cohuck@redhat.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.129.124]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4532e093e04si17265695e9.40.2025.06.12.09.07.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 09:07:49 -0700 (PDT) Received-SPF: pass (google.com: domain of cohuck@redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jO0NsOjk; spf=pass (google.com: domain of cohuck@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=cohuck@redhat.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749744468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+uVuub5Ky1bzhq7P2Mnf0OieKw5ECMBGCTcKWAjvVoM=; b=jO0NsOjkkbHtjZ0x883JiSlhSTx4+MFDCAVoh5pE8mDEgfDTZ2cZTl7Ez3H6Kj8orC1Gp1 1L6MGIfGXYPwJBgbB4w0e98zX+HqwvsD7DEI/NLo/iGCi5zDBqjkq2k3LVuj1SkYEZTbGw hBwXdJV34zavvOgjVkVVWuHmkBHqIEA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-Uv3enwPvPyq8CXgvFQds9w-1; Thu, 12 Jun 2025 12:07:47 -0400 X-MC-Unique: Uv3enwPvPyq8CXgvFQds9w-1 X-Mimecast-MFC-AGG-ID: Uv3enwPvPyq8CXgvFQds9w_1749744465 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8D1B818001D1; Thu, 12 Jun 2025 16:07:44 +0000 (UTC) Received: from localhost (unknown [10.45.224.54]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED9A019560AF; Thu, 12 Jun 2025 16:07:42 +0000 (UTC) From: Cornelia Huck To: Peter Maydell Cc: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, richard.henderson@linaro.org, alex.bennee@linaro.org, maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com, shameerali.kolothum.thodi@huawei.com, armbru@redhat.com, berrange@redhat.com, abologna@redhat.com, jdenemar@redhat.com, agraf@csgraf.de, shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH v7 13/14] arm/cpu: switch to a generated cpu-sysregs.h.inc In-Reply-To: Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Avril Crosse O'Flaherty" References: <20250515153907.151174-1-cohuck@redhat.com> <20250515153907.151174-14-cohuck@redhat.com> User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Date: Thu, 12 Jun 2025 18:07:40 +0200 Message-ID: <871prp9c4z.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-TUID: DTKd68VPogET On Thu, Jun 12 2025, Peter Maydell wrote: > On Thu, 15 May 2025 at 16:40, Cornelia Huck wrote: >> >> Generated against Linux 6.14-rc1. >> >> Reviewed-by: Sebastian Ott >> Reviewed-by: Eric Auger >> Signed-off-by: Cornelia Huck >> --- > > Does it make sense to include all these extra registers? > Some of them are not simple ID registers at all, > for example ID_CCSIDR_EL1 is an array of registers, not > a single value (in QEMU, stored in cpu->ccsidr[]), > and CSSELR_EL1 is not an ID register at all, it's a > normal read/write sysreg. Oops, I think the generator needs to check for op1=={0,1,3} instead of including op1==2... [Another issue that came up in recent discussions for the cpu model series is that recent kernels have made {MIDR,REVIDR,AIDR}_EL1 writable, but even though they are in the range the kernel reports writable registers in, the source sysreg file does not include them. I've changed the script to add them manually so far, but not sure if that is the best solution here.]