Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8407C43219 for ; Thu, 19 May 2022 12:39:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L3qDS72j8z2yny for ; Thu, 19 May 2022 22:39:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ixEjEQjW; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L3qCm3h32z2yV6 for ; Thu, 19 May 2022 22:38:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ixEjEQjW; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L3qCk1prqz4xD8; Thu, 19 May 2022 22:38:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1652963922; bh=0TLro0SA/18NlSBFMn34S0cBax5+uzY+PqBTBfpLaa8=; h=From:To:Subject:In-Reply-To:References:Date:From; b=ixEjEQjW69Mx2eWMN4fzDXSXawcYVEirqaPxB7v9sgT6QIHXCbcjAdsivobDJaLJK UMzbL6sTifdgbTHOOU6oKJVvTm0q04bc7PJM2wS/IWMAjcMjnIeXOZQpqLtYU92GFX SrXMtaKo/xULjAoQGw5uO6Is+G13WPNSOWVP3ID7nn3udbbjz6e8cpPnPBBE8JpuVL cpgiui4vGw9cjSf1tHpfU7DUQrV7bG4FZ+xAYAwqIdXpMH2pnwc/ij+5+YbHvh86Er OZQikVMlCJGVfunRptq97E9fGMR1sPk5PwxVo7qhrfZqYCvOBD3sPbStq7Nj55e1GY HLeMXjObQxQUw== From: Michael Ellerman To: Christophe Leroy , Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/powernv/pci: Drop VF MPS fixup In-Reply-To: <23fd8d03-965b-a252-020e-4185c2ef5681@csgroup.eu> References: <20200902035159.1762596-1-oohall@gmail.com> <23fd8d03-965b-a252-020e-4185c2ef5681@csgroup.eu> Date: Thu, 19 May 2022 22:38:40 +1000 Message-ID: <871qwpofxr.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Christophe Leroy writes: > Le 02/09/2020 =C3=A0 05:51, Oliver O'Halloran a =C3=A9crit=C2=A0: >> The MPS field in the VF config space is marked as reserved in current >> versions of the SR-IOV spec. In other words, this fixup doesn't do >> anything. >>=20 >> Signed-off-by: Oliver O'Halloran > > A lot of cleanup patches from Oliver were merged in Septembre 2020 but=20 > not this one. > > Any reason ? It wasn't clear to me that it's safe to remove. The commit that added it seemed to think it was important. The fact that it's out-of-spec doesn't mean we don't have some hardware somewhere that relies on that. cheers