Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819A8C433F5 for ; Tue, 11 Jan 2022 14:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241371AbiAKOSr (ORCPT ); Tue, 11 Jan 2022 09:18:47 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:58510 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241089AbiAKOSq (ORCPT ); Tue, 11 Jan 2022 09:18:46 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1409615FC for ; Tue, 11 Jan 2022 14:18:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 291DCC36AEB; Tue, 11 Jan 2022 14:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641910725; bh=zJ1/eiV6n61IaOYz5GcKJ/BzFdPcMZQiPxj1RRI1D0U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DR3OyCoSMVR4IjpUSbBdm0ZEi8PFPavi+GATwK2x82EUmq26AXrF7ippC6FjbcZta e9sWEuk8U/hDShkUNhWuXqmzNTYdF5wYl12mOMDOJ+BuW9obpwH1Zv5pHpsKTtnT4n +Y/BU7UM+cga+MNW2dwhEc4O13bHwhhv7LnZp4+olSA3P5NZCji4YbrQ0EZF/xaQbj +4CmXDJMz3Gc/agh4YdYegfuBFo3R9H/mi2lxCSSuVu2KTkaoqob4Mib0xz9/fLMEN 3GFDEat/+5VkBqLd2iycocAIHs3WzJaFyMuk8GgU8tFw+ijF90E7nA5cMdyLroKflp Pdb+u1ZXebJOQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n7Hz1-00HOuY-87; Tue, 11 Jan 2022 14:18:43 +0000 Date: Tue, 11 Jan 2022 14:18:42 +0000 Message-ID: <871r1etkxp.wl-maz@kernel.org> From: Marc Zyngier To: Peter Maydell Cc: Richard Henderson , qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com, Eric Auger , Andrew Jones Subject: Re: [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host In-Reply-To: References: <20220107150154.2490308-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: peter.maydell@linaro.org, richard.henderson@linaro.org, qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com, eric.auger@redhat.com, drjones@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 11 Jan 2022 13:58:49 +0000, Peter Maydell wrote: > > On Sat, 8 Jan 2022 at 13:42, Marc Zyngier wrote: > > > > On 2022-01-07 20:23, Richard Henderson wrote: > > > On 1/7/22 7:01 AM, Marc Zyngier wrote: > > >> @@ -1380,17 +1380,10 @@ void arm_cpu_finalize_features(ARMCPU *cpu, > > >> Error **errp) > > >> return; > > >> } > > >> - /* > > >> - * KVM does not support modifications to this feature. > > >> - * We have not registered the cpu properties when KVM > > >> - * is in use, so the user will not be able to set them. > > >> - */ > > >> - if (!kvm_enabled()) { > > >> - arm_cpu_pauth_finalize(cpu, &local_err); > > >> - if (local_err != NULL) { > > >> + arm_cpu_pauth_finalize(cpu, &local_err); > > >> + if (local_err != NULL) { > > >> error_propagate(errp, local_err); > > >> return; > > >> - } > > >> } > > > > > > Indentation is still off -- error + return should be out-dented one > > > level. > > > > > > > Duh. Clearly, my brain can't spot these. Apologies for the extra noise. > > > > > Otherwise, > > > Reviewed-by: Richard Henderson > > > > Thanks. I'll repost a version shortly, unless someone shouts. > > Don't worry about it -- I've applied this to target-arm.next and > fixed the indent there. Awesome, thanks Peter. M. -- Without deviation from the norm, progress is not possible.