From: Vitaly Kuznetsov Date: Tue, 27 Aug 2019 12:28:09 +0000 Subject: Re: [PATCH] x86: KVM: svm: Fix a check in nested_svm_vmrun() Message-Id: <871rx6n67a.fsf@vitty.brq.redhat.com> List-Id: References: <20190827093852.GA8443@mwanda> In-Reply-To: <20190827093852.GA8443@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Paolo Bonzini Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter writes: > We refactored this code a bit and accidentally deleted the "-" character > from "-EINVAL". The kvm_vcpu_map() function never returns positive > EINVAL. > > Fixes: c8e16b78c614 ("x86: KVM: svm: eliminate hardcoded RIP advancement from vmrun_interception()") > Signed-off-by: Dan Carpenter > --- > From static analysis. I don't really know the impact. > > > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 1f220a85514f..ef646e22d1ab 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -3598,7 +3598,7 @@ static int nested_svm_vmrun(struct vcpu_svm *svm) > vmcb_gpa = svm->vmcb->save.rax; > > ret = kvm_vcpu_map(&svm->vcpu, gpa_to_gfn(vmcb_gpa), &map); > - if (ret = EINVAL) { > + if (ret = -EINVAL) { > kvm_inject_gp(&svm->vcpu, 0); > return 1; > } else if (ret) { I was hoping that my patch was OK and Paolo screwed it upon commit but no, it's the same in my local branch and I'm left without excuses :-) Reviewed-by: Vitaly Kuznetsov -- Vitaly