Received: from eggs.gnu.org ([2001:4830:134:3::10]:50634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Aa1-000816-K9 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 11:48:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4AZu-000068-84 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 11:48:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4AZu-00005T-2N for qemu-devel@nongnu.org; Wed, 02 Dec 2015 11:48:26 -0500 From: Markus Armbruster References: <1449033659-25497-1-git-send-email-eblake@redhat.com> <1449033659-25497-14-git-send-email-eblake@redhat.com> <87lh9dukyw.fsf@blackfin.pond.sub.org> <565EF521.5030307@redhat.com> Date: Wed, 02 Dec 2015 17:48:21 +0100 In-Reply-To: <565EF521.5030307@redhat.com> (Eric Blake's message of "Wed, 2 Dec 2015 06:41:53 -0700") Message-ID: <871tb4kd9m.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v14 13/15] qapi: Enforce (or whitelist) case conventions on qapi members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > On 12/02/2015 04:51 AM, Markus Armbruster wrote: >> This is the fixup I mentioned in the v13 thread. The "Unreachable and >> not implemented" hunk should probably be its own patch. > > In fact, that hunk... > >> >> diff --git a/scripts/qapi.py b/scripts/qapi.py >> index 6d38d7c..870e476 100644 >> --- a/scripts/qapi.py >> +++ b/scripts/qapi.py > >> @@ -1073,7 +1071,8 @@ class QAPISchemaMember(object): >> return '(parameter of %s)' % owner[:-4] >> else: >> assert owner.endswith('-wrapper') >> - return '(branch of %s)' % owner[:-8] >> + # Unreachable and not implemented >> + assert False >> if owner.endswith('Kind'): >> # See QAPISchema._make_implicit_enum_type() >> return '(branch of %s)' % owner[:-4] > > ...should probably just be squashed directly into commit 8f3a05b on your > current qapi-next branch, since it hasn't landed upstream yet. Good idea. > Your fixup looks sane, and eliminates the need for 12/15. So I'm fine Yes, let's set that patch aside for now. We can bring it back if we find a need. > if you'd like to make that change when updating qapi-next. > Reviewed-by: Eric Blake Checkout out your later fixups now.