Received: from eggs.gnu.org ([2001:4830:134:3::10]:51394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2FlS-0002gs-Bv for qemu-devel@nongnu.org; Fri, 27 Nov 2015 04:56:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2FlN-0005GH-UL for qemu-devel@nongnu.org; Fri, 27 Nov 2015 04:56:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2FlN-0005Fz-Kr for qemu-devel@nongnu.org; Fri, 27 Nov 2015 04:56:21 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 129E1C0D2230 for ; Fri, 27 Nov 2015 09:56:21 +0000 (UTC) From: Markus Armbruster References: <1448040300-968-1-git-send-email-eblake@redhat.com> Date: Fri, 27 Nov 2015 10:56:18 +0100 In-Reply-To: <1448040300-968-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Fri, 20 Nov 2015 10:24:46 -0700") Message-ID: <871tbb935p.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspection cleanups, subset D) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Eric Blake writes: > Pending prerequisites: > + Markus' "typedefs: Put them back into alphabetical order" > https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04417.html > + Markus' qapi-next branch > http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/qapi-next > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv13d > > and will soon be part of my branch with the rest of the v5 series, at: > http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi I'm not too fond of PATCH 11, but can't see a better way to do what it does. However, I don't yet understand why doing it is useful. I inquired about its use in PATCH 12, perhaps you can enlighten me there. Other than that, just a few nitpicks. One more respin should take care of them.