Received: from eggs.gnu.org ([2001:4830:134:3::10]:58220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuj8T-0002iH-KT for qemu-devel@nongnu.org; Fri, 06 Nov 2015 10:41:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuj8O-00045s-16 for qemu-devel@nongnu.org; Fri, 06 Nov 2015 10:41:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuj8N-00045h-HZ for qemu-devel@nongnu.org; Fri, 06 Nov 2015 10:40:59 -0500 From: Markus Armbruster References: <1446791754-23823-1-git-send-email-eblake@redhat.com> <1446791754-23823-8-git-send-email-eblake@redhat.com> Date: Fri, 06 Nov 2015 16:40:56 +0100 In-Reply-To: <1446791754-23823-8-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 5 Nov 2015 23:35:31 -0700") Message-ID: <871tc316gn.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > By moving err into data, we can let test teardown take care > of cleaning up any collected error; it also gives us fewer > lines of code between repeated tests where init runs teardown > on our behalf. I think this paragraph is no longer valid: you aren't moving err anywhere in this version. > Rather than duplicate code between .c files, I added a new > test-qmp-common.h. I debated about putting > error_free_or_abort() in error.h, but it seems like something > that is only useful for tests. Maybe, maybe not. I'd accept it into error.h. > Signed-off-by: Eric Blake Patch looks okay.