Received: from eggs.gnu.org ([2001:4830:134:3::10]:47840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YY88z-00010d-Ir
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 03:11:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YY88y-0005or-EL
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 03:11:57 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1426625899-25348-1-git-send-email-jsnow@redhat.com>
Date: Wed, 18 Mar 2015 08:11:48 +0100
In-Reply-To: <1426625899-25348-1-git-send-email-jsnow@redhat.com> (John Snow's
	message of "Tue, 17 Mar 2015 16:58:19 -0400")
Message-ID: <871tkmkcej.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0
	error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org

John Snow <jsnow@redhat.com> writes:

> A thinko that clang 3.5.0 caught.
> Thankfully does not introduce any new failures.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

How you caught the bug is interesting enough to be mentioned in the
commit message, but the nature of the bug surely is more interesting
than that.  Suggest to change the subject to

    qtest/ahci: Fix a bit mask expression

Perhaps it can be fixed up on commit.

Reviewed-by: Markus Armbruster <armbru@redhat.com>