Received: from eggs.gnu.org ([208.118.235.92]:57938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHw17-0001kV-Da for qemu-devel@nongnu.org; Tue, 19 Mar 2013 08:51:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHw16-0004Ms-50 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 08:51:49 -0400 From: Markus Armbruster References: <1363692343-22299-1-git-send-email-kwolf@redhat.com> Date: Tue, 19 Mar 2013 13:51:44 +0100 In-Reply-To: <1363692343-22299-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 19 Mar 2013 12:25:43 +0100") Message-ID: <871ubba6xr.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] serial: Fix debug format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc'ing qemu-trivial Kevin Wolf writes: > This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. > > Signed-off-by: Kevin Wolf > --- > hw/serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/serial.c b/hw/serial.c > index 48a5eb6..0ccc499 100644 > --- a/hw/serial.c > +++ b/hw/serial.c > @@ -306,7 +306,7 @@ static void serial_ioport_write(void *opaque, hwaddr addr, uint64_t val, > SerialState *s = opaque; > > addr &= 7; > - DPRINTF("write addr=0x%02x val=0x%02x\n", addr, val); > + DPRINTF("write addr=0x%" HWADDR_PRIx " val=0x%" PRIx64 "\n", addr, val); > switch(addr) { > default: > case 0: > @@ -527,7 +527,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr addr, unsigned size) > ret = s->scr; > break; > } > - DPRINTF("read addr=0x%02x val=0x%02x\n", addr, ret); > + DPRINTF("read addr=0x%" HWADDR_PRIx " val=0x%02x\n", addr, ret); > return ret; > }