Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqZAf-0007CM-3P for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqZAZ-00078Y-7J for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:39 -0400 Received: from [199.232.76.173] (port=54997 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqZAY-00078N-Cz for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45237) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqZAX-0005Q1-SA for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8NLEWCG031994 for ; Wed, 23 Sep 2009 17:14:33 -0400 Subject: Re: [Qemu-devel] [PATCH 0/9] ide: convert to qdev. References: <1252943364-32705-1-git-send-email-kraxel@redhat.com> From: Markus Armbruster Date: Wed, 23 Sep 2009 21:00:15 +0200 In-Reply-To: <1252943364-32705-1-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Mon\, 14 Sep 2009 17\:49\:15 +0200") Message-ID: <871vlxh4g0.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > Hi, > > Here is a patch series which starts the conversion of ide to qdev. > It brings the core infrastructure and converts pci+isa ide adapters > to qdev. Also some minor preparatory patches and bugfixes. > > v2 changes: > * check qdev_init for failure. > * move whitespace changes to separate patch. > * drop some needless code reorderings. > > cheers, > Gerd Looks good to me. I'd still like to see the relationship between struct IDEBus members master, slave and ifs[] documented, but that's detail. ISA interrupt sharing may need further refinement later on.