From: Florian Weimer Subject: Re: Correct behavior on O_DIRECT sparse file writes Date: Sat, 13 Oct 2007 13:24:55 +0200 Message-ID: <871wbzp88o.fsf@mid.deneb.enyo.de> References: <1192221567.1375.81.camel@think.oraclecorp.com> <20071012140233.ad7b517d.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Mason , linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from mail.enyo.de ([212.9.189.167]:3369 "EHLO mail.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbXJMLlM (ORCPT ); Sat, 13 Oct 2007 07:41:12 -0400 In-Reply-To: <20071012140233.ad7b517d.akpm@linux-foundation.org> (Andrew Morton's message of "Fri, 12 Oct 2007 14:02:33 -0700") Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org * Andrew Morton: > I don't think it's a bug. Sure, O_DIRECT is synchronous, but that's > because it is, err, direct. Not because it provides extra data-integrity > guarantees. If you want those guarantees, use O_SYNC as well. This needs to be prominently documented. Right now, it's far from clear that you need both O_DIRECT and O_SYNC.