Received: from eggs.gnu.org ([209.51.188.92]:38767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hERNb-0005Ix-CC for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hERNa-0005Ue-Dx for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33478) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hERNa-0005UX-6B for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:02 -0400 From: Markus Armbruster References: <20190409174018.25798-1-armbru@redhat.com> <874l764eez.fsf@dusky.pond.sub.org> <38442eb0-501e-dbf8-60e0-74675a999dba@redhat.com> <87bm1e2yfa.fsf@dusky.pond.sub.org> Date: Thu, 11 Apr 2019 06:31:53 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 10 Apr 2019 17:47:44 +0200") Message-ID: <8736mpw4au.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Alistair Francis , Peter Maydell , Alistair Francis , "qemu-devel@nongnu.org Developers" , Sergio Lopez , David Gibson Philippe Mathieu-Daud=C3=A9 writes: > On 4/10/19 8:34 AM, Alistair Francis wrote: >> On Tue, Apr 9, 2019 at 10:59 PM Markus Armbruster wr= ote: >>> Philippe Mathieu-Daud=C3=A9 writes: >>>> On 4/10/19 7:28 AM, Markus Armbruster wrote: >>>>> Philippe Mathieu-Daud=C3=A9 writes: [...] >>>>>> BTW how did you figure that out? >>>>> >>>>> Downstream handling of upstream commit da885fe1ee8 led me to the >>>>> function. I spotted dt_size =3D get_image_size(filename_path). >>>>> Experience has taught me to check the left hand side's type. Bad. T= hen >>>>> I saw how dt_size gets increased. Worse. >>>> >>>> So you genuinely neglected to mention Kurtis Miller then :) >>> >>> Explanation, not excuse: the only occurence of the name in my downstream >>> reading was a two-liner BZ comment, which I totally missed in my haste >>> to give the fix a chance to make 4.0. I certainly didn't mean to >>> deprive him of credit! > > My English teacher explained me neglected sounds like a > reprimand/reproach (as in negligence), sorry I didn't mean to be rude > here, I wanted to say something like "Peter remarked you did gave > credits to the first one who reported this issue, but since you figured > this bug via your own way, the omission was not intentional then." Don't worry, my social interactions teacher taught me to assume good intent ;) [...]