Received: from eggs.gnu.org ([2001:4830:134:3::10]:55665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhAJX-0003e0-E9 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 02:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhAJS-0000hq-I5 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 02:56:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhAJS-0000hf-CR for qemu-devel@nongnu.org; Tue, 06 Sep 2016 02:56:54 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB2787DD0F for ; Tue, 6 Sep 2016 06:56:53 +0000 (UTC) From: Markus Armbruster References: <1473095135-15915-1-git-send-email-berrange@redhat.com> Date: Tue, 06 Sep 2016 08:56:51 +0200 In-Reply-To: <1473095135-15915-1-git-send-email-berrange@redhat.com> (Daniel P. Berrange's message of "Mon, 5 Sep 2016 18:05:35 +0100") Message-ID: <8737ldqzws.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] crypto: report enum strings instead of values in errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org "Daniel P. Berrange" writes: > Several error messages print out the raw enum value, which > is less than helpful to users, as these values are not > documented, nor stable across QEMU releases. Switch to use > the enum string instead. > > The nettle impl also had two typos where it said "algorithm" > instead of "mode". It doesn't just say "algorithm", it actually prints it: error_setg(errp, "Unsupported cipher algorithm %d", cipher->alg); > Signed-off-by: Daniel P. Berrange Reviewed-by: Markus Armbruster