Received: from eggs.gnu.org ([2001:4830:134:3::10]:41826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9UU9-0002ye-H2 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 04:04:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9UU5-0001WT-En for qemu-devel@nongnu.org; Thu, 17 Dec 2015 04:04:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9UU5-0001WH-AE for qemu-devel@nongnu.org; Thu, 17 Dec 2015 04:04:25 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 00B718E221 for ; Thu, 17 Dec 2015 09:04:24 +0000 (UTC) From: Markus Armbruster References: <1448267731-32678-1-git-send-email-armbru@redhat.com> <20151123110101-mutt-send-email-mst@redhat.com> <87egfh3pq3.fsf@blackfin.pond.sub.org> Date: Thu, 17 Dec 2015 10:04:22 +0100 In-Reply-To: <87egfh3pq3.fsf@blackfin.pond.sub.org> (Markus Armbruster's message of "Mon, 23 Nov 2015 12:44:04 +0100") Message-ID: <8737v1zbs9.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, ehabkost@redhat.com Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: >>> qmp_query_memdev() has two error paths: >>> >>> * When object_get_objects_root() returns null. It never does, so >>> simply drop the useless error handling. >>> >>> * When query_memdev() fails. It leaks err then. But any failure >>> there is actually a programming error. Switch it to &error_abort, >>> and drop the useless error handling. >>> >>> Messed up in commit 76b5d85 "qmp: add query-memdev". >>> >>> Signed-off-by: Markus Armbruster >> >> >> Post 2.5 right? > > I don't mind. I meant v1 for 2.5, but we've since convinced ourselves > that errors can't happen, and the memory leak is only latent. Friendly ping for 2.6.