Received: from eggs.gnu.org ([2001:4830:134:3::10]:37919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzJtS-0000mt-Ow for qemu-devel@nongnu.org; Thu, 19 Nov 2015 02:44:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzJtS-00049W-0G for qemu-devel@nongnu.org; Thu, 19 Nov 2015 02:44:34 -0500 From: Markus Armbruster References: <1447836791-369-1-git-send-email-eblake@redhat.com> <1447836791-369-30-git-send-email-eblake@redhat.com> <87mvubjhbl.fsf@blackfin.pond.sub.org> <564D0952.9010306@redhat.com> Date: Thu, 19 Nov 2015 08:44:27 +0100 In-Reply-To: <564D0952.9010306@redhat.com> (Eric Blake's message of "Wed, 18 Nov 2015 16:27:14 -0700") Message-ID: <8737w2fn6s.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v12 29/36] qobject: Rename qtype_code to QType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Michael Roth , qemu-devel@nongnu.org, "open list:Block layer core" , Luiz Capitulino Eric Blake writes: > On 11/18/2015 11:25 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The name QType is more in line with our conventions for qapi >>> types, and matches the fact that each enum member has a prefix >>> of QTYPE_. >>> >>> Signed-off-by: Eric Blake >> >> At this point, the connection to QAPI is unobvious. >> >> You can either point to CODING_STYLE, which ask for type names in >> CamelCase, or to the next patch. > > How about: > > The name QType matches our CODING_STYLE conventions for type names in > CamelCase. It also matches the fact that we are already naming all the > enum members with a prefix of QTYPE, not QTYPE_CODE. And doing the > rename will also make it easier for the next patch to use QAPI for the > enum, which also wants CamelCase type names. > > Feel free to touch up the commit message as you see fit. Sold!