Received: from eggs.gnu.org ([2001:4830:134:3::10]:44289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrqiX-0003rX-5i for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:10:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrqiT-0002nQ-4T for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:10:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrqiS-0002nB-Vl for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:10:21 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6253AA37CD for ; Thu, 29 Oct 2015 17:10:20 +0000 (UTC) From: Markus Armbruster References: <1446057425-16891-1-git-send-email-ehabkost@redhat.com> <1446057425-16891-10-git-send-email-ehabkost@redhat.com> Date: Thu, 29 Oct 2015 18:10:17 +0100 In-Reply-To: <1446057425-16891-10-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Wed, 28 Oct 2015 16:36:58 -0200") Message-ID: <8737wtwqh2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Andrew Jones , qemu-devel@nongnu.org Eduardo Habkost writes: > Signed-off-by: Eduardo Habkost > --- > vl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index af8d09c..67147e0 100644 > --- a/vl.c > +++ b/vl.c > @@ -3667,8 +3667,8 @@ int main(int argc, char **argv, char **envp) > { /* end of list */ } > }; > > - error_report("warning: option deprecated, use " > - "lost_tick_policy property of kvm-pit instead"); > + error_report("warning: -no-kvm-pit-reinjection deprecated by " > + "-global kvm-pit.lost_tick_policy=discard"); > qdev_prop_register_global_list(kvm_pit_lost_tick_policy); > break; > } Repeating the option in the error message rarely improves the message, because error_report() already shows it. It's actually misleading when the option comes from a configuration file read with -readconfig. Fortunately, -readconfig doesn't support the option, so that's not an issue here. For the command line, the message changes from qemu-system-x86_64: -no-kvm-pit-reinjection: warning: option deprecated, use lost_tick_policy property of kvm-pit instead to qemu-system-x86_64: -no-kvm-pit-reinjection: warning: -no-kvm-pit-reinjection deprecated by -global kvm-pit.lost_tick_policy=discard Perhaps: qemu-system-x86_64: -no-kvm-pit-reinjection: warning: deprecated, replaced by -global kvm-pit.lost_tick_policy=discard Similar argument for PATCH 08.