From: Eric Anholt Subject: Re: [PATCH 01/12] Stop trying to out-guess mesa for BO allocation Date: Mon, 04 Aug 2014 09:58:02 -0700 Message-ID: <8738dcp4yt.fsf@eliezer.anholt.net> References: <1406243908-1123-1-git-send-email-keithp@keithp.com> <1406243908-1123-2-git-send-email-keithp@keithp.com> <87silie2qa.fsf@eliezer.anholt.net> <86fvhidqub.fsf@hiro.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1104892572==" Return-path: In-Reply-To: <86fvhidqub.fsf@hiro.keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Keith Packard , xorg-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1104892572== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Keith Packard writes: > Eric Anholt writes: > >> Keith Packard writes: >> >> I don't see anything indicating that this code path is only used by >> glamor. > > True. It's a fix for DRI3 for either UXA or "none". Mesa allocates a > single page for a 1x1 texture, but this code thinks that should take two > pages causing a texture-to-pixmap operation to fail. OK, but isn't the problem with the code you're #if 0ing (which, really? #if 0 in a patch being submitted for review?) that it's aligning to 2*height instead of height? --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJT37uaAAoJELXWKTbR/J7o9qkP/039U6DCptB/1WwM0I80Lsd/ CwdnOg9eNMrSM/3hEzo7PnCUZ2srS/Vi6lbkXZk88nnq/GNKL8Caas9R3ECGFGaf 5qPQ2n2xRHmfv2y2uVT5EpSci05sQLKoC9T1hWhV06G6PSF8nfBwUQW1liTdbYk2 JFiycXiCC67G9NYJsX1k0myzmzsVZQa/+j0wvbAy09WmVgKvYWy2h4PPev2ZvDP6 eGOafT31sRgf9x2r++rOwFwMq6YMnLbcnw/zMrlT2Afytqz0fG+zbUiGcQkFtMmb pR35ssgKHMR1UQQntnkap1oJDSy+yITiRtK49DNNfdOj49IMV3FoXCQOK09ekuxJ cDzhNNPKxEhUmtV7/421/7NCEb7ClcLY/wFhojddts6OSi00hejHYZD/CkmKdAeM oM4m+nN1KIMYlhnngRbJRwSTWKY3CaPTwmPt3argZkKYTyLuI/dT0LZER6wjzgXZ E2rOK/OpzwGJHJqfTUQXr7FrhGPClHdRvkzD6o4jIMChle+2Q4JGG/bSe2Z6PMan L3b8OgvPCOsOxo6XWAeJBueN+0HZCDO6ybyRB2Ujr0DY59JzoaDwJHhmHmPgZ/gD OYMm1kG1bJsl0FkSo4s1GKHmdcj96VmjCubrpxMt6xCsNo0NHF4uEYW3ncxDH5Ay CP7iFSvu1EXvJHYhSq/K =oxSf -----END PGP SIGNATURE----- --=-=-=-- --===============1104892572== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1104892572==--