Received: from eggs.gnu.org ([2001:4830:134:3::10]:46212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHrSW-0002G8-5f for qemu-devel@nongnu.org; Mon, 24 Feb 2014 04:04:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHrSR-0007ws-50 for qemu-devel@nongnu.org; Mon, 24 Feb 2014 04:04:20 -0500 From: Markus Armbruster References: <1393164341-7196-1-git-send-email-kroosec@gmail.com> Date: Mon, 24 Feb 2014 10:04:05 +0100 In-Reply-To: <1393164341-7196-1-git-send-email-kroosec@gmail.com> (Hani Benhabiles's message of "Sun, 23 Feb 2014 15:05:41 +0100") Message-ID: <8738j86fwa.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] balloon: Fix device name in error message. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Luiz Capitulino Hani Benhabiles writes: > Also fix trailing whitespace. > > Signed-off-by: Hani Benhabiles > --- > balloon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/balloon.c b/balloon.c > index e321f2c..b66710a 100644 > --- a/balloon.c > +++ b/balloon.c > @@ -125,8 +125,8 @@ void qmp_balloon(int64_t value, Error **errp) > error_set(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size"); > return; > } > - > + > if (qemu_balloon(value) == 0) { > - error_set(errp, QERR_DEVICE_NOT_ACTIVE, "balloon"); > + error_set(errp, QERR_DEVICE_NOT_ACTIVE, "virtio-balloon-pci"); > } > } I agree the error message is bad, but I'm afraid your patch makes it worse :) qemu_balloon() returns zero when balloon_event_fn has not been set with qemu_add_balloon_handler(). Right now, the only device that calls qemu_add_balloon_handler() is virtio-balloon-device. In theory, there could be others in the future. virtio-balloon-device is a virtio-bus device. The bus can be provided by virtio-balloon-pci or virtio-balloon-ccw. Your error message is misleading when it's provided by the latter. Moreover, you missed qmp_query_balloon(). QERR_DEVICE_NOT_ACTIVE is also used with argument "spice", and the resulting error message is similarly bad. Perhaps something like this would do: #define QERR_DEVICE_NOT_ACTIVE \ ERROR_CLASS_DEVICE_NOT_ACTIVE, "No %s device has been activated"