Received: from eggs.gnu.org ([2001:4830:134:3::10]:42387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGXpu-0000wA-A0 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:55:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGXpn-0002oj-Op for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:55:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGXpn-0002nv-G9 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:54:55 -0500 From: Markus Armbruster References: <1392827321-10205-1-git-send-email-roland@kernel.org> <5304E4E4.10703@redhat.com> <5304F3D4.9060501@suse.de> <53052B92.7080305@redhat.com> <530620C7.7060208@redhat.com> <5306270E.4020105@suse.de> <53062910.3030009@redhat.com> Date: Thu, 20 Feb 2014 18:54:52 +0100 In-Reply-To: <53062910.3030009@redhat.com> (Paolo Bonzini's message of "Thu, 20 Feb 2014 17:10:56 +0100") Message-ID: <8738jdu0sz.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Roland Dreier , Andreas =?utf-8?Q?F=C3=A4rber?= , qemu-devel@nongnu.org Paolo Bonzini writes: > Il 20/02/2014 17:02, Andreas F=C3=A4rber ha scritto: >> Not unexpected, it's the older; the - convention was introduced possibly >> with QOM around start of 2012. Or at least there it's been enforced, and QMP preferred '-' from the start, but insufficient decoupling from command line and HMP let in many '_', and the bad examples then got copied around, as usual. >> by my understanding of QOM and QMP visibility it then applies to devices >> as well. >> >> Regarding QMP, I consider it smarter to do the _ -> - matching at >> QemuOpts level than somewhere inside QOM. > > That's fine, because device_add uses QemuOpts internally. > >> For -cpu we have such compatibility code (although non-QemuOpts) in >> target-i386/cpu.c, converting all underscores. Unfortunately that won't >> work as long as there are underscores in old properties. Maybe you have >> some cool patch idea? > > Well, no cool idea except "once conversion is done at the QemuOpts > level, do a full sweep of s/_/-/". Required anyway, to get the help texts consistent, and to get rid of the bad examples. > This should be done before we'll > be able to create devices with object-add. I think as long as we have > a plan, consistency trumps design-by-committee convention.