Received: from eggs.gnu.org ([208.118.235.92]:60710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG7Ma-00035n-Va for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:34:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG7MW-0006bu-Gv for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:34:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG7MW-0006bn-83 for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:34:24 -0400 From: Markus Armbruster References: <1363109492-1901-1-git-send-email-chouteau@adacore.com> <1363109492-1901-4-git-send-email-chouteau@adacore.com> <87mwu6z7ze.fsf@blackfin.pond.sub.org> <5141AD9B.3060702@adacore.com> Date: Thu, 14 Mar 2013 13:34:20 +0100 In-Reply-To: <5141AD9B.3060702@adacore.com> (Fabien Chouteau's message of "Thu, 14 Mar 2013 11:59:39 +0100") Message-ID: <8738vyw46r.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org Fabien Chouteau writes: > On 03/14/2013 09:44 AM, Markus Armbruster wrote: >> Fabien Chouteau writes: >> >>> We introduce a new command line option. It's a generic option to >>> customize the gdb server: >>> >>> -gdb-opts [attached=on|off] >>> >>> The only parameter for now is "attached". >>> >>> Signed-off-by: Fabien Chouteau >> >> --gdb-opts complements existing --gdb. You need to use both for full >> control. >> >> I figure you do this because you can't extend --gdb, as its argument is >> in legacy character device syntax, not QemuOpts. >> > > That's right, maybe we can do some string manipulations to handle this case. > > -gdb tcp::1234,attached=off > > find ',attached={on|off}' and remove it from the string. That way is madness :) >> We had similar cases before, and solved them differently: create a more >> general option, then make the old one sugar for the new one. >> >> For instance, --monitor and --qmp are sugar for --mon. Desugaring code >> is in monitor_parse(). >> > > Something like: > > -chardev socket,id=gdb1,host=localhost,port=1234,server,nowait,nodelay > -gdb-remote chardev=gdb1,attached=off > > You still need two options for full control. Yes, but following precedence is good. Our command line is inconsistent enough as it is. Just my two cents.