From: khilman@ti.com (Kevin Hilman) Date: Wed, 16 Mar 2011 08:35:18 -0700 Subject: [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device. In-Reply-To: (Nishanth Menon's message of "Tue, 15 Mar 2011 10:48:37 +0530") References: <1299926361-28482-1-git-send-email-shweta.gulati@ti.com> Message-ID: <8739mngjt5.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "Menon, Nishanth" writes: > On Sat, Mar 12, 2011 at 16:09, Shweta Gulati wrote: >> OMAP4 has two different Devices IVA and DSP. DSP is bound >> with IVA for DVFS. The registration of IVA dev in API >> 'omap2_init_processor_devices' was missing. Init dev for >> 'iva_dev' is added. >> >> This also fixes the following error seen during boot as >> omap2_set_init_voltage can now find the iva device >> >> ? ? ? ?omap2_set_init_voltage: Invalid parameters! >> ? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage >> >> Signed-off-by: Shweta Gulati >> --- >> >> Tested on OMAP4430 SDP Board. >> Baseline: >> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git >> Branch :pm-core >> >> V2: >> Rephrased the Commit log. >> >> ?arch/arm/mach-omap2/pm.c | ? ?1 + >> ?1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c >> index 30af335..49486f5 100644 >> --- a/arch/arm/mach-omap2/pm.c >> +++ b/arch/arm/mach-omap2/pm.c >> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void) >> ? ? ? ?if (cpu_is_omap44xx()) { >> ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1", &l3_dev); >> ? ? ? ? ? ? ? ?_init_omap_device("dsp", &dsp_dev); >> + ? ? ? ? ? ? ? _init_omap_device("iva", &iva_dev); >> ? ? ? ?} else { >> ? ? ? ? ? ? ? ?_init_omap_device("l3_main", &l3_dev); >> ? ? ? ?} >> -- > Looks fine to me. Thanks, I'll take this as an ack. Will queue as a fix for the .39-rc fixes cycle. Kevin