From: Eric Anholt Subject: Re: [PATCH] drm/i915/gen4: Fix interrupt setup ordering Date: Fri, 04 Jun 2010 11:01:35 -0700 Message-ID: <8739x2pthc.fsf@pollan.anholt.net> References: <1274995605-4035-1-git-send-email-ajax@redhat.com> <1275600683.14943.21.camel@atropine.boston.devel.redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2064708257==" Return-path: In-Reply-To: <1275600683.14943.21.camel@atropine.boston.devel.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2064708257== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 03 Jun 2010 17:31:22 -0400, Adam Jackson wrote: > On Thu, 2010-05-27 at 17:26 -0400, Adam Jackson wrote: > > Unmask, then enable interrupts, then enable interrupt sources; matches > > PCH ordering. The old way (sources, enable, unmask) gives a window > > during which interrupt conditions would appear in ISR but would never > > reach IIR and thus never raise an IRQ. Since interrupts only trigger > > on rising edges in ISR, this would lead to conditions where (for > > example) output hotplugging would never fire an interrupt because it > > was already stuck on in ISR. > >=20 > > Also, since we know IIR and PIPExSTAT have been cleared during > > irq_preinstall, don't clear them again during irq_postinstall, nothing > > good can come of that. > >=20 > > Signed-off-by: Adam Jackson >=20 > Just to follow up, I've tested this (combined with the already-merged > VGA paranoia patch) on GM45. Output hotplug still works and I'm no > longer seeing stuck bits in ISR. Thanks for the followup. It really helps me to know what people have tested on, and whether they were fixing a bug due to code inspection or due to actually solving a problem they were hitting on hardware. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwJP38ACgkQHUdvYGzw6ve9sACeIvmLFqXJdZd54jbFoEQqioRT xCoAn0KowGfeDMOc7EPgXcYDgPTXX+kj =JPY5 -----END PGP SIGNATURE----- --=-=-=-- --===============2064708257== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2064708257==--