From: OGAWA Hirofumi Subject: Re: [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos Date: Mon, 18 Jan 2010 10:59:10 +0900 Message-ID: <873a24kwb5.fsf@devron.myhome.or.jp> References: <20100115013954.311049665@intel.com> <20100115014422.959401729@intel.com> <87bpgurz00.fsf@devron.myhome.or.jp> <20100118091527.7a0e2c6e.kamezawa.hiroyu@jp.fujitsu.com> <87y6jwnrcz.fsf@devron.myhome.or.jp> <873a24mc3i.fsf@devron.myhome.or.jp> <20100118104913.66c8d90c.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wu Fengguang , Andrew Morton , Al Viro , Heiko Carstens , Christoph Hellwig , LKML , Eric Paris , Nick Piggin , Andi Kleen , David Howells , Jonathan Corbet , To: KAMEZAWA Hiroyuki Return-path: In-Reply-To: <20100118104913.66c8d90c.kamezawa.hiroyu@jp.fujitsu.com> (KAMEZAWA Hiroyuki's message of "Mon, 18 Jan 2010 10:49:13 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org KAMEZAWA Hiroyuki writes: >> BTW, another concern by negative "pos" value is, the following like code >> >> pos >> shift_bits >> >> it will break the above. So, I think it should be checked if not yet. > > Where do we check ? > > FMODE_NEG_OFFSET is just used by /dev/mem and /proc//mem. And I don't > think there are no additonal users. So, I myself don't have has such concerns... Sorry, it's just my concern. I'm not checking real path (e.g. vfs) of related to /dev/mem, if there is no user of such code, it's ok. Thanks. -- OGAWA Hirofumi