From: OGAWA Hirofumi Subject: Re: [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos Date: Mon, 18 Jan 2010 10:32:49 +0900 Message-ID: <873a24mc3i.fsf@devron.myhome.or.jp> References: <20100115013954.311049665@intel.com> <20100115014422.959401729@intel.com> <87bpgurz00.fsf@devron.myhome.or.jp> <20100118091527.7a0e2c6e.kamezawa.hiroyu@jp.fujitsu.com> <87y6jwnrcz.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wu Fengguang , Andrew Morton , Al Viro , Heiko Carstens , Christoph Hellwig , LKML , Eric Paris , Nick Piggin , Andi Kleen , David Howells , Jonathan Corbet , To: KAMEZAWA Hiroyuki Return-path: In-Reply-To: <87y6jwnrcz.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Mon, 18 Jan 2010 10:17:48 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org OGAWA Hirofumi writes: >>> Um... How do lseek() work? It sounds like to violate error code range. >> >> This is for read-write. As far as I know, >> - generic_file_llseek, >> - default_llseek >> - no_llseek >> >> doesn't call this function. > > It seems to allow to set negative value to ->f_pos, right? So, lseek() > returns (uses) it? BTW, another concern by negative "pos" value is, the following like code pos >> shift_bits it will break the above. So, I think it should be checked if not yet. -- OGAWA Hirofumi