From: Markus Armbruster Subject: Re: [Patch] fix xenfb_update_screen bogus rect Date: Thu, 29 Jan 2009 15:29:33 +0100 Message-ID: <873af2xk1e.fsf@pike.pond.sub.org> References: <497E784B.7060003@jp.fujitsu.com> <497ED10A.76E4.0078.0@novell.com> <498009CC.1000101@jp.fujitsu.com> <49802E40.76E4.0078.0@novell.com> <87zlhb1own.fsf@pike.pond.sub.org> <49817304.4080509@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <49817304.4080509@jp.fujitsu.com> (Akio Takebe's message of "Thu\, 29 Jan 2009 18\:12\:36 +0900") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Akio Takebe Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Akio Takebe writes: > Hi, Markus and Jan > > Markus Armbruster wrote: >> "Jan Beulich" writes: >> >>> Generally this looks okay (assuming it works), but couldn't the update_wanted >>> field then go away altogether? >>> >>> Jan >> >> I think so, yes. Start the kthread only when request-update. >> > Thank you for your review. > The patch was commited already. > So I made an additional patch which eliminate the update_wanted field. > > Signed-off-by: Akio Takebe > > Best Regards, > > Akio Takebe Looks good to me. A possible reason not to take this cleanup is the fact that this version of the driver is a dead end (the living end lives in current upstream kernels). Perhaps only true fixes with minimal structural impact are desired because of that. Not my call to make.