From: OGAWA Hirofumi Subject: Re: [patch 3/3] fs: fix cont vs deadlock patches Date: Fri, 01 Dec 2006 10:11:14 +0900 Message-ID: <873b80v2rx.fsf@duaron.myhome.or.jp> References: <20061130072058.GA18004@wotan.suse.de> <20061130072202.GB18004@wotan.suse.de> <20061130072247.GC18004@wotan.suse.de> <20061130113241.GC12579@wotan.suse.de> <87r6vkzinv.fsf@duaron.myhome.or.jp> <20061201002750.GA455@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel Mailing List , Andrew Morton , linux-fsdevel@vger.kernel.org Return-path: Received: from mail.parknet.jp ([210.171.160.80]:35595 "EHLO parknet.jp") by vger.kernel.org with ESMTP id S1031685AbWLABLX (ORCPT ); Thu, 30 Nov 2006 20:11:23 -0500 Received: from ibmpc.myhome.or.jp ([210.171.168.39]:2132) by parknet.jp with [XMail 1.21 ESMTP Server] id for from ; Fri, 1 Dec 2006 10:12:17 +0900 To: Nick Piggin In-Reply-To: <20061201002750.GA455@wotan.suse.de> (Nick Piggin's message of "Fri\, 1 Dec 2006 01\:27\:50 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Nick Piggin writes: > I would be happy if you come up with a quick fix, I'm just trying to > stamp out a few big bugs in mm. However I did prefer my way of moving > all the exapand code into generic_cont_expand, out of prepare_write, and > avoiding holding the target page locked while we're doing all the expand > work (strictly, you might be able to get away with this, but it is > fragile and ugly). > > AFAIKS, the only reason to use prepare_write is to avoid passing the > get_block into generic_cont_expand? IIRC, because generic_cont_expand is designed as really generic. It can also use for non moronic filesystem. In the case of reiserfs, it ->prepare_write might be necessary. -- OGAWA Hirofumi