Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99F01C433F5 for ; Sun, 16 Jan 2022 21:06:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CAA1B81E3E; Sun, 16 Jan 2022 22:06:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="A9+m7MZI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46B3583458; Sun, 16 Jan 2022 22:06:14 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7F9E6810EC for ; Sun, 16 Jan 2022 22:06:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2f.google.com with SMTP id c2so6746275qvw.3 for ; Sun, 16 Jan 2022 13:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AjFbT3cuvPzBsyLV5h3bppUnuVxvtRK3hBWzi1VCe5k=; b=A9+m7MZIp9KVQBA4Hym9CjeyimMumy0sCun7kxfPHmdw0joLOq/BCUVLnKsCf9kXcg QNogi850OMNGUISiObqmAzaTjTLiS1rocIC8XuSNqzQyhJvw6/rVZTS2g3AtuYJxMwdo Eu5KudBaVZygbwOUlLpPw5kVdkdsUzWqtQ38aU4ryQJUGpl4ayDSDBFJrlTnDgJqCUTf ZzoAGhc2SoTBB8Zk0htGCf35KLGNA3RepOSAY5Xp9Jg3AOZr2QoW4m9S3eM/gzrEgIci Eh7DIx/NTcdoqj6321b6Q9E9pn9+ZCCKjVZrGvvrwd4EVeP71i44ILlhlisCTNHfmAVB /ZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AjFbT3cuvPzBsyLV5h3bppUnuVxvtRK3hBWzi1VCe5k=; b=EerxrywtrsfNfgNnsdW6k3lAQTPlWWxnmC17K2YWFyYOv9Fs0+fcr7Bt/fGnH3gsVP 0mDTHkNsWKRWt7wHv7z4AErX69PVLYugpqTMuh2dG47ABJSRF5lj6etTl1ZMVfHwS6tI kE7z6wWwVt8ypt2iBKdEk64qz4Z7JiVCgkuv5eE9sd2UXrZWi1hK0PIgA6RLooXh5tYp /oDDsSwkMkeVug0VgWBDoOTpptNp+a8WqA1uHo25Mmkioy6Xy8hDRrrF/0FcT/+/euWp 0hEr/yvOmKXLPs+0jvs8zNemmM4sWTllU6GAij6HjeON7k4Vb13reEfr1uViTvHRkqjo CwTw== X-Gm-Message-State: AOAM53039/YpizdDGGBbIZvhtfKl+GqHg+cHqdpeEek2ZKszPWtL8U+B 03QbcuSx7+pIMszGAKCmUcM= X-Google-Smtp-Source: ABdhPJyzux7KVIBp+floK7+7j3Avo8WhVSoSYXuohpFgpHgm78EgXVHROutWn7GMFocNik7fuPFT8w== X-Received: by 2002:a05:6214:2aac:: with SMTP id js12mr15849883qvb.71.1642367170210; Sun, 16 Jan 2022 13:06:10 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id br17sm4237644qkb.79.2022.01.16.13.06.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jan 2022 13:06:09 -0800 (PST) Subject: Re: [PATCH v4 03/13] mmc: fsl: Use brackets around if() To: Simon Glass , U-Boot Mailing List Cc: Tom Rini , Rasmus Villemoes , Jaehoon Chung , Peng Fan References: <20220116201937.1387697-1-sjg@chromium.org> <20220116131907.v4.3.I1dc474c992ec58cc19f8053464c13e50efa56c14@changeid> From: Sean Anderson Message-ID: <8742334b-5e4d-4c40-711e-43bc7238dcba@gmail.com> Date: Sun, 16 Jan 2022 16:06:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220116131907.v4.3.I1dc474c992ec58cc19f8053464c13e50efa56c14@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/16/22 3:19 PM, Simon Glass wrote: > At present the IS_ENABLED() macro has extra brackets, making it possible > to write: > > if IS_ENABLED(CONFIG_XXX) > > but it is a bit confusing. Add the missing brackets. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c > index 9299635f509..08ea98fe81a 100644 > --- a/drivers/mmc/fsl_esdhc_imx.c > +++ b/drivers/mmc/fsl_esdhc_imx.c > @@ -453,7 +453,7 @@ static int esdhc_send_cmd_common(struct fsl_esdhc_priv *priv, struct mmc *mmc, > > /* Send the command */ > esdhc_write32(®s->cmdarg, cmd->cmdarg); > - if IS_ENABLED(CONFIG_FSL_USDHC) { > + if (IS_ENABLED(CONFIG_FSL_USDHC)) { > u32 mixctrl = esdhc_read32(®s->mixctrl); > > esdhc_write32(®s->mixctrl, > Reviewed-by: Sean Anderson